mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
To: netdev@vger.kernel.org
Cc: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Donald Hunter" <donald.hunter@gmail.com>,
	"Danielle Ratson" <danieller@nvidia.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Simon Horman" <horms@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH net-next v2 1/9] netlink: specs: rt-link: re-align IPv4 devconf
Date: Fri, 25 Sep 2026 21:39:04 +0000	[thread overview]
Message-ID: <20260925213918.204767-2-ast@fiberby.net> (raw)
In-Reply-To: <20260925213918.204767-1-ast@fiberby.net>

The YNL "ipv4-devconf" enum is misaligned with the IPV4_DEVCONF_* enum.

IPV4_DEVCONF_* starts at 1, ipv4-devconf starts at 0.

$ git grep -B3 -A1 IPV4_DEVCONF_FORWARDING include/
inc../uapi/linux/ip.h-/* index values for the variables in ipv4_devconf */
inc../uapi/linux/ip.h-enum
inc../uapi/linux/ip.h-{
inc../uapi/linux/ip.h:        IPV4_DEVCONF_FORWARDING=1,
inc../uapi/linux/ip.h-        IPV4_DEVCONF_MC_FORWARDING,

Re-align the YNL spec by explicitly setting the first value to 1.

This misalignment has been present since the spec was added in
commit b2f63d904e72 ("doc/netlink: Add spec for rt link messages").

Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
---
Note for Sashiko/Clashiko: Targeting net-next, so no "Fixes" tag.

 Documentation/netlink/specs/rt-link.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/netlink/specs/rt-link.yaml b/Documentation/netlink/specs/rt-link.yaml
index 7a72cd1b7e1e..8d63933f9910 100644
--- a/Documentation/netlink/specs/rt-link.yaml
+++ b/Documentation/netlink/specs/rt-link.yaml
@@ -309,6 +309,7 @@ definitions:
     entries:
       -
         name: forwarding
+        value: 1
       -
         name: mc-forwarding
       -
-- 
2.55.0


  reply	other threads:[~2026-09-25 21:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25 21:39 [PATCH net-next v2 0/9] netlink: specs: enum alignment fixes Asbjørn Sloth Tønnesen
2026-09-25 21:39 ` Asbjørn Sloth Tønnesen [this message]
2026-09-25 21:39 ` [PATCH net-next v2 2/9] netlink: specs: rt-link: re-align ifla-inet6-stats Asbjørn Sloth Tønnesen
2026-09-25 21:39 ` [PATCH net-next v2 3/9] netlink: specs: rt-link: fix ifinfo-flags names Asbjørn Sloth Tønnesen
2026-09-25 21:39 ` [PATCH net-next v2 4/9] netlink: specs: devlink: fix resource-scope type Asbjørn Sloth Tønnesen
2026-09-25 21:39 ` [PATCH net-next v2 5/9] netlink: specs: ethtool: re-align c33-pse-ext-state Asbjørn Sloth Tønnesen
2026-09-25 21:39 ` [PATCH net-next v2 6/9] netlink: specs: ethtool: re-align module-fw-flash-status Asbjørn Sloth Tønnesen
2026-09-25 21:39 ` [PATCH net-next v2 7/9] netlink: specs: nl80211: fix naming of enum members Asbjørn Sloth Tønnesen
2026-09-25 21:39 ` [PATCH net-next v2 8/9] netlink: specs: tc: fix typo in cls-flags Asbjørn Sloth Tønnesen
2026-09-25 21:39 ` [PATCH net-next v2 9/9] netlink: specs: fix incorrect name-prefixes Asbjørn Sloth Tønnesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260925213918.204767-2-ast@fiberby.net \
    --to=ast@fiberby.net \
    --cc=danieller@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®