mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Grzegorz Nitka <grzegorz.nitka@intel.com>
To: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	richardcochran@gmail.com, andrew+netdev@lunn.ch,
	przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com,
	arkadiusz.kubalewski@intel.com, davem@davemloft.net,
	edumazet@google.com, Grzegorz Nitka <grzegorz.nitka@intel.com>
Subject: [PATCH iwl-net 0/2] ice: fix E825 PTP timer race and drop redundant cross-timestamp access
Date: Sat, 26 Sep 2026 00:28:22 +0200	[thread overview]
Message-ID: <20260925222824.270640-1-grzegorz.nitka@intel.com> (raw)

This series fixes a race in the E825 PHY timer start path and removes a
redundant cross-timestamp command programming sequence.

The first patch serializes the E825 PHY timer start sequence with the PTP
lock and keeps the shared GLTSYN_CMD register access and incval programming
within the same critical section. This prevents concurrent PTP updates from
clobbering the source timer command and leaving the E825 PHY clock offset
from the PHC.

The second patch removes the redundant cross-timestamp programming of
GLTSYN_CMD in the capture path. The register accesses were mistakenly
assumed to be required for E823-class devices. In fact, it was the
E824-family (not supported by this driver) not E823.

Grzegorz Nitka (1):
  ice: remove redundant cross-timestamp PTP command

Maciek Machnikowski (1):
  ice: ptp: serialize E825 PHY timer start with PTP lock and incval

 drivers/net/ethernet/intel/ice/ice_ptp.c    |  6 ---
 drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 48 +++++++++------------
 2 files changed, 21 insertions(+), 33 deletions(-)


base-commit: 349099e5d8082ab01e60d91fba9d107591c17371
-- 
2.39.3


             reply	other threads:[~2026-09-25 22:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25 22:28 Grzegorz Nitka [this message]
2026-09-25 22:28 ` [PATCH iwl-net 1/2] ice: ptp: serialize E825 PHY timer start with PTP lock and incval Grzegorz Nitka
2026-09-26 17:05   ` Simon Horman
2026-09-28 15:19   ` Loktionov, Aleksandr
2026-09-25 22:28 ` [PATCH iwl-net 2/2] ice: remove redundant cross-timestamp PTP command Grzegorz Nitka
2026-09-26 17:06   ` Simon Horman
2026-09-28 15:19   ` Loktionov, Aleksandr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260925222824.270640-1-grzegorz.nitka@intel.com \
    --to=grzegorz.nitka@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=arkadiusz.kubalewski@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®