From: Anton Danilov <littlesmilingcloud@gmail.com>
To: Ido Schimmel <idosch@nvidia.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
David Ahern <dsahern@kernel.org>, Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 03/10] gre: make gre_parse_header() report a drop reason
Date: Sat, 26 Sep 2026 02:12:05 +0300 [thread overview]
Message-ID: <20260925231207.542162-1-littlesmilingcloud@gmail.com> (raw)
In-Reply-To: <20260923145931.GA2859441@shredder>
On Wed, Sep 23, 2026 at 05:59:31PM +0300, Ido Schimmel wrote:
> On Wed, Sep 23, 2026 at 01:15:00AM +0300, Anton Danilov wrote:
> > if (unlikely(!pskb_may_pull(skb, nhs + sizeof(struct gre_base_hdr))))
> > - return -EINVAL;
> > + return SKB_DROP_REASON_HDR_TRUNC;
>
> Please use pskb_may_pull_reason() as is done throughout the kernel.
> AFAICT, there's only one user of HDR_TRUNC (in tun) and it should also
> be converted to pskb_may_pull_reason() so that we could remove
> HDR_TRUNC. Can you send a patch?
Sure, I will send it separately. It does not depend on this series, as
v5 will no longer use HDR_TRUNC.
...
> > - if (ver >= GREPROTO_MAX)
> > + if (ver >= GREPROTO_MAX) {
> > + reason = SKB_DROP_REASON_UNHANDLED_PROTO;
>
> This should be TUNNEL_INVALID_HDR to be consistent with the hunk above.
Agreed, will change in v5.
next prev parent reply other threads:[~2026-09-25 23:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 22:14 [PATCH net-next v4 00/10] tunnels: add core and gre drop reasons Anton Danilov
2026-09-22 22:14 ` [PATCH net-next v4 01/10] ip_tunnel: add drop reasons to the generic RX path Anton Danilov
2026-09-22 22:14 ` [PATCH net-next v4 02/10] ip6_tunnel: " Anton Danilov
2026-09-22 22:15 ` [PATCH net-next v4 03/10] gre: make gre_parse_header() report a drop reason Anton Danilov
2026-09-23 14:59 ` Ido Schimmel
2026-09-25 23:12 ` Anton Danilov [this message]
2026-09-22 22:15 ` [PATCH net-next v4 04/10] ip_tunnel: add __iptunnel_pull_header_reason() Anton Danilov
2026-09-23 15:41 ` Ido Schimmel
2026-09-25 23:12 ` Anton Danilov
2026-09-22 22:15 ` [PATCH net-next v4 05/10] ip_gre: add drop reasons to the RX path Anton Danilov
2026-09-22 22:15 ` [PATCH net-next v4 06/10] ip6_gre: " Anton Danilov
2026-09-22 22:15 ` [PATCH net-next v4 07/10] ip_tunnel: add drop reasons to the transmit path Anton Danilov
2026-09-23 15:53 ` Ido Schimmel
2026-09-22 22:15 ` [PATCH net-next v4 08/10] ip_gre: " Anton Danilov
2026-09-22 22:15 ` [PATCH net-next v4 09/10] ip6_gre: make prepare_ip6gre_xmit_other() void Anton Danilov
2026-09-22 22:15 ` [PATCH net-next v4 10/10] ip6_tunnel: add drop reasons to the transmit path Anton Danilov
2026-09-23 14:19 ` [PATCH net-next v4 00/10] tunnels: add core and gre drop reasons Ido Schimmel
2026-09-25 23:11 ` Anton Danilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925231207.542162-1-littlesmilingcloud@gmail.com \
--to=littlesmilingcloud@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®