From: Adam Azuddin via B4 Relay <devnull+azuddinadam.gmail.com@kernel.org>
To: Aun-Ali Zaidi <admin@kodeit.net>,
Aditya Garg <aditya.garg@linux.dev>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>,
Atharva Tiwari <evepolonium@gmail.com>,
Kerem Karabay <kekrby@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Adam Azuddin <azuddinadam@gmail.com>
Subject: [PATCH] drm/appletbdrm: Fix incorrect error message on encoder attach failure
Date: Sat, 26 Sep 2026 21:18:11 +0800 [thread overview]
Message-ID: <20260926-fix-err-msg-appletbdrm-v1-1-bb578a7dbdda@gmail.com> (raw)
From: Adam Azuddin <azuddinadam@gmail.com>
drm_connector_attach_encoder() replaced an earlier call to
drm_simple_display_pipe_init() during review, but the error message
logged on failure was not updated to match and still refers to the
old call.
Fixes: 0670c2f56e45 ("drm/tiny: add driver for Apple Touch Bars in x86 Macs")
Signed-off-by: Adam Azuddin <azuddinadam@gmail.com>
---
drivers/gpu/drm/tiny/appletbdrm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/appletbdrm.c b/drivers/gpu/drm/tiny/appletbdrm.c
index 4297d9c1125e..91a51b513911 100644
--- a/drivers/gpu/drm/tiny/appletbdrm.c
+++ b/drivers/gpu/drm/tiny/appletbdrm.c
@@ -724,7 +724,7 @@ static int appletbdrm_setup_mode_config(struct appletbdrm_device *adev)
ret = drm_connector_attach_encoder(connector, encoder);
if (ret) {
- drm_err(drm, "Failed to initialize simple display pipe\n");
+ drm_err(drm, "Failed to attach connector to encoder\n");
return ret;
}
---
base-commit: 98c7fc4219b93f953ee85c07fb6c8256046aba73
change-id: 20260926-fix-err-msg-appletbdrm-63865f293290
Best regards,
--
Adam Azuddin <azuddinadam@gmail.com>
reply other threads:[~2026-09-26 13:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260926-fix-err-msg-appletbdrm-v1-1-bb578a7dbdda@gmail.com \
--to=devnull+azuddinadam.gmail.com@kernel.org \
--cc=aditya.garg@linux.dev \
--cc=admin@kodeit.net \
--cc=airlied@gmail.com \
--cc=azuddinadam@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=evepolonium@gmail.com \
--cc=kekrby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®