mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Heidelberg via B4 Relay <devnull+david.ixit.cz@kernel.org>
To: Alexey Minnekhanov <alexeymin@minlexx.ru>,
	 Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	 Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	 Bjorn Andersson <andersson@kernel.org>,
	 Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	 Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	 Lee Jones <lee@kernel.org>, Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
	 linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	 phone-devel@vger.kernel.org, mfd@lists.linux.dev,
	 David Heidelberg <david@ixit.cz>
Subject: [PATCH RFC 03/12] dt-bindings: usb: Add Qualcomm 1st-gen PMIC Type-C
Date: Sat, 26 Sep 2026 14:40:22 +0200	[thread overview]
Message-ID: <20260926-typec-v1-3-31adc19f32c6@ixit.cz> (raw)
In-Reply-To: <20260926-typec-v1-0-31adc19f32c6@ixit.cz>

From: David Heidelberg <david@ixit.cz>

Add a binding for the first generation of the Qualcomm PMIC USB Type-C
port controller, found on the PM660 and PMI8998 PMICs.

Unlike the later standalone Type-C peripheral at 0x1500 (e.g. PM8150B),
the gen1 Type-C CC logic is part of the charger's USBIN peripheral
(base 0x1300) and signals all Type-C events (CC state change,
tCCDebounce done, VBUS change and error) through a single aggregate
"type-c-change" interrupt. The USB PD PHY at 0x1700 is register
compatible with PM8150B.

The different interrupt set and register layout make it a separate
binding rather than another variant of qcom,pmic-typec. As with PM8150B,
the Type-C block and PD PHY are described as a separate SPMI node from
the charger.

Allow typec nodes of the Qualcomm SPMI PMIC to use the new binding as
well.

Assisted-by: LLM
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml    |   4 +-
 .../bindings/usb/qcom,pmic-typec-gen1.yaml         | 130 +++++++++++++++++++++
 2 files changed, 133 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 5e0ed30a9a466..d7a43aa423c8a 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -199,17 +199,19 @@ patternProperties:
     $ref: /schemas/thermal/qcom,spmi-temp-alarm.yaml#
 
   "^temperature-sensor@[0-9a-f]+$":
     type: object
     $ref: /schemas/thermal/qcom,pm8775-mbg-tm.yaml#
 
   "^typec@[0-9a-f]+$":
     type: object
-    $ref: /schemas/usb/qcom,pmic-typec.yaml#
+    oneOf:
+      - $ref: /schemas/usb/qcom,pmic-typec.yaml#
+      - $ref: /schemas/usb/qcom,pmic-typec-gen1.yaml#
 
   "^usb-detect@[0-9a-f]+$":
     type: object
     $ref: /schemas/extcon/qcom,pm8941-misc.yaml#
 
   "^usb-vbus-regulator@[0-9a-f]+$":
     type: object
     $ref: /schemas/regulator/qcom,usb-vbus-regulator.yaml#
diff --git a/Documentation/devicetree/bindings/usb/qcom,pmic-typec-gen1.yaml b/Documentation/devicetree/bindings/usb/qcom,pmic-typec-gen1.yaml
new file mode 100644
index 0000000000000..8e93719fac3d1
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/qcom,pmic-typec-gen1.yaml
@@ -0,0 +1,130 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/qcom,pmic-typec-gen1.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm PMIC USB Type-C block (gen1)
+
+maintainers:
+  - David Heidelberg <david@ixit.cz>
+
+description:
+  First generation of the Qualcomm PMIC Type-C port controller.
+
+properties:
+  compatible:
+    enum:
+      - qcom,pm660-typec
+      - qcom,pmi8998-typec
+
+  reg:
+    items:
+      - description: USBIN peripheral base (Type-C CC logic)
+      - description: USB PD PHY peripheral base
+
+  interrupts:
+    items:
+      - description: Type-C change - CC state, tCCDebounce done, VBUS change or error
+      - description: Power Domain Signal TX - HardReset or CableReset signal TX
+      - description: Power Domain Signal RX - HardReset or CableReset signal RX
+      - description: Power Domain TX complete
+      - description: Power Domain RX complete
+      - description: Power Domain TX fail
+      - description: Power Domain TX message discard
+      - description: Power Domain RX message discard
+      - description: Power Domain Fast Role Swap event
+
+  interrupt-names:
+    items:
+      - const: type-c-change
+      - const: sig-tx
+      - const: sig-rx
+      - const: msg-tx
+      - const: msg-rx
+      - const: msg-tx-failed
+      - const: msg-tx-discarded
+      - const: msg-rx-discarded
+      - const: fr-swap
+
+  vdd-pdphy-supply:
+    description: VDD regulator supply to the PDPHY.
+
+  connector:
+    type: object
+    $ref: /schemas/connector/usb-connector.yaml#
+    unevaluatedProperties: false
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - interrupt-names
+  - vdd-pdphy-supply
+  - connector
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/usb/pd.h>
+
+    pmic {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        typec@1300 {
+            compatible = "qcom,pmi8998-typec";
+            reg = <0x1300>,
+                  <0x1700>;
+
+            interrupts = <0x2 0x13 0x7 IRQ_TYPE_EDGE_RISING>,
+                         <0x2 0x17 0x0 IRQ_TYPE_EDGE_RISING>,
+                         <0x2 0x17 0x1 IRQ_TYPE_EDGE_RISING>,
+                         <0x2 0x17 0x2 IRQ_TYPE_EDGE_RISING>,
+                         <0x2 0x17 0x3 IRQ_TYPE_EDGE_RISING>,
+                         <0x2 0x17 0x4 IRQ_TYPE_EDGE_RISING>,
+                         <0x2 0x17 0x5 IRQ_TYPE_EDGE_RISING>,
+                         <0x2 0x17 0x6 IRQ_TYPE_EDGE_RISING>,
+                         <0x2 0x17 0x7 IRQ_TYPE_EDGE_RISING>;
+            interrupt-names = "type-c-change",
+                              "sig-tx",
+                              "sig-rx",
+                              "msg-tx",
+                              "msg-rx",
+                              "msg-tx-failed",
+                              "msg-tx-discarded",
+                              "msg-rx-discarded",
+                              "fr-swap";
+
+            vdd-pdphy-supply = <&vreg_l24a_3p075>;
+
+            connector {
+                compatible = "usb-c-connector";
+
+                power-role = "dual";
+                data-role = "dual";
+                try-power-role = "sink";
+
+                source-pdos = <PDO_FIXED(5000, 900, PDO_FIXED_DUAL_ROLE |
+                               PDO_FIXED_USB_COMM | PDO_FIXED_DATA_SWAP)>;
+                sink-pdos = <PDO_FIXED(5000, 3000, PDO_FIXED_DUAL_ROLE |
+                             PDO_FIXED_USB_COMM | PDO_FIXED_DATA_SWAP)>;
+                op-sink-microwatt = <15000000>;
+
+                ports {
+                    #address-cells = <1>;
+                    #size-cells = <0>;
+
+                    port@0 {
+                        reg = <0>;
+                        endpoint {
+                            remote-endpoint = <&usb_dwc3_hs>;
+                        };
+                    };
+                };
+            };
+        };
+    };
+...

-- 
2.55.0



  parent reply	other threads:[~2026-09-26 12:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-26 12:40 [PATCH RFC 00/12] Qualcomm Type-C support for 1st generation David Heidelberg via B4 Relay
2026-09-26 12:40 ` [PATCH RFC 01/12] usb: typec: tcpm: qcom: Release the connector fwnode reference David Heidelberg via B4 Relay
2026-09-26 12:40 ` [PATCH RFC 02/12] dt-bindings: usb: qcom,pmic-typec: Update example with vbus-supply David Heidelberg via B4 Relay
2026-09-26 12:40 ` David Heidelberg via B4 Relay [this message]
2026-09-26 12:40 ` [PATCH RFC 04/12] usb: typec: qcom: Make PMIC port probe selectable David Heidelberg via B4 Relay
2026-09-26 12:40 ` [PATCH RFC 05/12] usb: typec: qcom: Make typec_port accept also different structure David Heidelberg via B4 Relay
2026-09-26 12:40 ` [PATCH RFC 06/12] usb: typec: qcom: Add gen1 Type-C port support David Heidelberg via B4 Relay
2026-09-26 12:40 ` [PATCH RFC 07/12] arm64: dts: qcom: pm660: Add USB Type-C port controller node David Heidelberg via B4 Relay
2026-09-26 12:40 ` [PATCH RFC 08/12] arm64: dts: qcom: pmi8998: " David Heidelberg via B4 Relay
2026-09-26 12:40 ` [PATCH RFC 09/12] arm64: dts: qcom: sdm670-google-common: Enable USB Type-C port controller David Heidelberg via B4 Relay
2026-09-26 12:40 ` [PATCH RFC 10/12] arm64: dts: qcom: sdm845-google-common: " David Heidelberg via B4 Relay
2026-09-26 12:40 ` [PATCH RFC 11/12] arm64: dts: qcom: sdm845-oneplus-common: " David Heidelberg via B4 Relay
2026-09-26 12:40 ` [PATCH RFC 12/12] arm64: dts: qcom: sdm845-shift-axolotl: " David Heidelberg via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260926-typec-v1-3-31adc19f32c6@ixit.cz \
    --to=devnull+david.ixit.cz@kernel.org \
    --cc=alexeymin@minlexx.ru \
    --cc=andersson@kernel.org \
    --cc=broonie@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mfd@lists.linux.dev \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®