From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy2-f43.google.com (mail-dy2-f43.google.com [74.125.229.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D3EB3911D5 for ; Sat, 26 Sep 2026 04:29:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.229.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790396971; cv=none; b=haqiCQGIia9CUti12/RfqHJkwbqlcv1aBbRLNLjGKEcqGq3+CjB/zgPcdyNZVl2Gvj9IJ+Jm+RPjsSR0a+k9mB1WZytITQNLCIlmDhOjYNlCaBip8wbjH5MJLJ/26ZF4kcmLB6YjQVl7Pg59beCwlrYwApmnzo061D3e9Nuv02U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790396971; c=relaxed/simple; bh=GpUUZlRSGDZdH9l14gIIKqilWznEEoD/ZnFf4baX0dE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X6oQZvZ32Vkbz9Cppwa6icxSSmogE4BtX3XS0s3iWFWuH/meXoR74/9aj5o47X/xiR9k55hOta5js0+/mfRpUX9xB8P7UgzpaDKDyZP4EuYC4TubAjVh4JqNtP/RArsjZtUmTb8b/mcYVKdDcO9y5VDsXvYB+8WP2N/vwWUQaRA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=o+aKNqdq; arc=none smtp.client-ip=74.125.229.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o+aKNqdq" Received: by mail-dy2-f43.google.com with SMTP id 5a478bee46e88-33e46a15703so1292592eec.0 for ; Fri, 25 Sep 2026 21:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790396968; x=1791001768; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0D44r2HU7mPFEg3suXmYiSPEArkz6cxgDH4F/lCy9n8=; b=o+aKNqdq49edaUmqOxV9wdMXAUpN2UdejH9ruAGkLUpa9wisc6YKoOG+VO6S4TFIV6 DB02QVhKYW5CEJix3im32GHtcVsc7Tv5BQQ0w1+ZPhoCLWJxPW+ACgFeKUl9mT4CmJ0w lFAo9nibq8PtGz57bSCSzEIW0PH4Xe7K16Vl6orZTqFNObiSLCClZwjVBXEiRRkUU2p+ I+toP5woQoWWwa2pPEEbcLLv0omn1h5eR9wp+eXxEtXh1/AYXurtiZw1gpkb2DBQ4hEX mho99dkAylMhIrQhke7WqH5CWZhESaZOqduMCxfTCKkIn3R5IgMQ0HMx6ez9tMZJxg88 vU0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790396968; x=1791001768; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=0D44r2HU7mPFEg3suXmYiSPEArkz6cxgDH4F/lCy9n8=; b=Y4fVQKXAwF8SmXtYxj/v3UaWckyxX+aqd2xyF9c1z8NfzOD9gZJ1H35UeYwqgJi/3P 5khQ2sZ336KzUU/7oG3CPFv06Kluqexm9/qZvz2f1s3ddNQ8EKL9v0LObtcMKWLfuaFp paUrrDAQIzneEHJ71RLLBN4e2gWlAfyRHOPA9nP3PswfzhOx4cDrkA3pDfsks0xMT7H8 gGsdHQE2n4UFv88UISifDBKMdnKPkVCRLh8OcsT6//Gf9pz0ysxrHt/D8JG/RiHTgL4L 50ZoycukFq+1H9+TPx5geQHnyUMbw9o87buVZmtGjL5QaFxNNrzQWlDDBHcTfY8+2J1l 4vfQ== X-Forwarded-Encrypted: i=1; AKwUvBzPQ2gWuU3QPiqySd8sIdaDStfSXMl//QayvC1DFQbV8Ei4Ex8iCqc99UtTq5Y1cZit2gmD4HbD89oYEco=@vger.kernel.org X-Gm-Message-State: AFuF++mhMgBAiPBfwEBvUDzQFFkNgqJXjIMRhkp0EuqFxRBW4Vo6+Ynr Z2btxnrTlSNXcwmGepKV4zueAz/ym8cnmYDp74vspESS/adsi0DvPD2D X-Gm-Gg: AYBFou3pTgfz6bBVGvD5DBiOr+H+Uh/7VU/6qQcZLFZ/gGhWOnUP3Uix3tc4jex1i73 ODh1GcuDgEPdEpzlk4DX1A5IhdXHTyBwZ6GQJwIbIYXPFXv0qDgsjNw8DBCsFtQsArWF63cdFAL KDFrRkyCO1w1vf1Z+q+/BJYGbWl79RvizECDlDP47QnPneyzqqr04tcoyuSYBC19RlE1kIn/lDK 9qlFMj4hKZdpw6nss6nhq0wiAR1OveN7qHjAobPquTVKbHCuzf2lvyk7ST74383aLGFokjJ+qIT ZcA2v1EdI3kQobTE4LgnFM+VUlsTYrumpW/EkuA9V6Z1/cgMEDdzG34xFDzASVKYJmwWBpkWPUM EA9nIb2ph9J9DogIPh3ejPkNZhI3iZpZ7FmUv/Mrbqb1+2MA9i3YHpLuq9rpy+3lkqDr/cn3OwV PzFM71gvozf2YkGKoKaSor/PRGyZhQJ20p0cMXUtp+8zEKURGEA3fwUrh4kT3jaAuCCgKPI7zE9 JtE6BnUp9UMqMNTWnr4cGV1S5zSt/nIKu4/5hE+Y55E/UzViIvUsSUJ46hz/wZSTk3+ABXuY5QW IN+CjlDwj/qnVglnjCFn4+N8xUJLbvvYj4EAPY95yY6WBWDrWq+9FIAknGg= X-Received: by 2002:a05:7301:b95:b0:33c:16f1:2e3f with SMTP id 5a478bee46e88-3426fcc8442mr1784295eec.6.1790396968201; Fri, 25 Sep 2026 21:29:28 -0700 (PDT) Received: from spider.bream-herring.ts.net ([103.6.151.236]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3421dbb2971sm6342963eec.10.2026.09.25.21.29.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2026 21:29:27 -0700 (PDT) From: Matthias Goergens To: Jan Kara Cc: Christian Brauner , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/4] isofs: shrink the name conversion buffer Date: Sat, 26 Sep 2026 12:29:16 +0800 Message-ID: <20260926042916.3277409-5-matthias.goergens@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260926042916.3277409-1-matthias.goergens@gmail.com> References: <20260926042916.3277409-1-matthias.goergens@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit isofs_readdir() and isofs_lookup() allocate 1024 bytes for the name converters. Now that get_rock_ridge_filename() and get_joliet_filename() are told the buffer size, nothing writes beyond JOLIET_NAME_MAX + 1 bytes: get_joliet_filename() is passed that size, get_rock_ridge_filename() is passed NAME_MAX + 1, isofs_name_translate() copies at most the 222 bytes of name a directory record can hold, and get_acorn_filename() appends at most five bytes to that. Allocate JOLIET_NAME_MAX + 1 bytes, matching what the Joliet callers pass. No functional change. Signed-off-by: Matthias Goergens --- fs/isofs/dir.c | 2 +- fs/isofs/namei.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/isofs/dir.c b/fs/isofs/dir.c index dd8958617340..8b5f03b696b2 100644 --- a/fs/isofs/dir.c +++ b/fs/isofs/dir.c @@ -236,7 +236,7 @@ static int isofs_readdir(struct file *file, struct dir_context *ctx) char *tmpname; struct inode *inode = file_inode(file); - tmpname = kmalloc(1024, GFP_KERNEL); + tmpname = kmalloc(JOLIET_NAME_MAX + 1, GFP_KERNEL); if (tmpname == NULL) return -ENOMEM; diff --git a/fs/isofs/namei.c b/fs/isofs/namei.c index 9025ff74eb60..c2222504fde9 100644 --- a/fs/isofs/namei.c +++ b/fs/isofs/namei.c @@ -157,7 +157,7 @@ struct dentry *isofs_lookup(struct inode *dir, struct dentry *dentry, unsigned i struct inode *inode; char *tmpname; - tmpname = kmalloc(1024, GFP_USER); + tmpname = kmalloc(JOLIET_NAME_MAX + 1, GFP_USER); if (!tmpname) return ERR_PTR(-ENOMEM); -- 2.55.0