From: sashiko-bot@kernel.org
To: "Matthias Goergens" <matthias.goergens@gmail.com>,
"Rafael J . Wysocki" <rafael@kernel.org>
Cc: scardracs@disroot.org, linux-kernel@vger.kernel.org,
mingo@redhat.com, tglx@kernel.org, dyoung@redhat.com,
io@r-ricci.it, x86@kernel.org, linux-pm@vger.kernel.org,
yu.c.chen@intel.com, kexec@lists.infradead.org,
baoquan.he@linux.dev, hpa@zytor.com, moravec@ukf.sk,
jlee@suse.com, dave.hansen@linux.intel.com, bp@alien8.de,
pavel@kernel.org
Subject: Re: [PATCH v2] x86/hibernate: Ignore page-zero RAM in E820 checksum
Date: Sat, 26 Sep 2026 05:26:13 +0000 [thread overview]
Message-ID: <20260926052613.CD9971F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260926052117.3613637-1-matthias.goergens@gmail.com>
> The legacy kexec_load path reconstructs the E820 map exported through
> sysfs. kexec-tools leaves the first 1 KiB unavailable for the real-mode
> transition, so a kernel entered through kexec_load can see conventional
> RAM starting at 0x400. A subsequent firmware boot reports the same RAM
> range starting at zero.
>
> The hibernation E820 checksum compares those byte representations and
> rejects the image, even though the maps agree from page one onwards.
> A QEMU guest showed this transition:
>
> firmware: RAM [0-0x9fbff]
> kexec_load: gap [0-0x3ff], RAM [0x400-0x9fbff]
> firmware: RAM [0-0x9fbff]
>
> The checksum covers e820_table_firmware, which trim_bios_range() leaves
> [ ... ]
> kernel carries on.
>
> Fixes: 62a03defeabd ("PM / hibernate: Verify the consistent of e820 memory map by md5 digest")
> Reported-by: Roberto Ricci <io@r-ricci.it>
> Signed-off-by: Matthias Goergens <matthias.goergens@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260926052117.3613637-1-matthias.goergens@gmail.com?part=1
prev parent reply other threads:[~2026-09-26 5:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 7:09 [PATCH] " Matthias Goergens
2026-09-25 16:51 ` Rafael J. Wysocki (Intel)
2026-09-26 5:21 ` [PATCH v2] " Matthias Goergens
2026-09-26 5:26 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260926052613.CD9971F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=baoquan.he@linux.dev \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=io@r-ricci.it \
--cc=jlee@suse.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.goergens@gmail.com \
--cc=mingo@redhat.com \
--cc=moravec@ukf.sk \
--cc=pavel@kernel.org \
--cc=rafael@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=scardracs@disroot.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®