From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 788F538DC60 for ; Sat, 26 Sep 2026 06:33:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790404414; cv=none; b=hCDulkcEOYVbMG3kO4n1+cU6lVNp3gQ7IuI3wnEuTOT2af3kzzo6IziUOUTkWD1XMs99vR6QrVtalj1FdGCHlPl9mZ6P1z6+6RZ4+NNxaT5QXoGWDbdajXWRuTsCeIpv4FQeYlnDc7rynfxrnUawl5BhKfPU7Mc9eEIOqjcImC4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790404414; c=relaxed/simple; bh=67sOexwvNB8oNwHlLhm0JdMRdQfyPnVTudrDRY1E+3o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JB2EIS+xRfIrc/xPgNwh2GJMbHLvzmzYELCvLJXRtPfq1bHsnyokIRWmNgLgiKgx8Nkl3rDAf1GruhGDh/AOxZdlyAhg0t/aqy61h2PdY373eR4i6PhOybrWufTJQQYrnnPgg5z0uFYMcamXHyZFrAhnaQpOG9nuR6qWzuuWRM4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F0IVx87Y; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F0IVx87Y" Received: by mail-pj2-f12.google.com with SMTP id d9443c01a7336-2d747eb79f7so7228845ad.1 for ; Fri, 25 Sep 2026 23:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790404412; x=1791009212; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=v8XYO5YM5s3vZvbrjVcN9xgfREmdqmZ1B6r1XIDErl8=; b=F0IVx87Y/9+d1Wst+TMmPwJlaLnlHRKq3RYmtFQH9f5u7MeSNCJzqOv73+6FTrtxmH U0SHRRLPUkJEnBjjW0mLxhRy8NuVBRsVwjRinkj5eAaTsgtzAQ0smDPGQVf6+dTRH3U+ rBiIpyY3AgUfei8fB00qgNKX7LHtcRghyPtRc1etjdi/3W5meNrDYj0yAChkc4Nb8l/H VGW/2gcfN7HRkKjtOiYwEaG4DFnZMqifiC2GfqV9DrJVUxbwe0I74wLX/6q4gKm9H2E2 BNK/G6RNL2XfMspXD8dxkUAQundW5YMnp5lePPeZ+pYSia3DUuwl0ateA6G8fTXjz+f/ tl8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790404412; x=1791009212; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=v8XYO5YM5s3vZvbrjVcN9xgfREmdqmZ1B6r1XIDErl8=; b=QjiSdk3vO03qAVINNEb8g5Wyf0mwd6gMDovRmG0+MB4b9rDr+vYS0NAfl2DvQRq+MB tehb4tqdp5VdBDuNrmN5uJkvF7+Vs5gInvgHzGtN7vsNXvrx7+1CiV4u65z+K2FTOWZT kf6Zbpth4c2Gfq8UB3//Eq0tDwSGfWHgfWa2SfVBirpy8ciWpAVsMVWyuvK8zTQVcBJQ a2ImZtfsnymdY79CL1VxUbVJ957+gG5YbLciPk+HsuGrvFhYAn35tfy0a/IUEPciunOI dWWmDqtzIzEOZdi2Eb3Fl4YncadnaDp6Qm5bN1F70X5HnFpBnEfzxF9zMM/fHR2KxY9F d5eQ== X-Forwarded-Encrypted: i=1; AKwUvByqWQAtzerqFmAy1VV11wucvuW2M9S1jjfrDnoUQJHIn7gSZog/hIWxQgVzFWQgvmBOf7UJx14s2+Hq2Mg=@vger.kernel.org X-Gm-Message-State: AFq9FYLUiQYxgeiwOHDiYn4QpiYjYGy5rik26NLS1/FjGTUyhv4j0LbZ 14oQATq/OjG+w3S7BaBZ4uHsFLWy90Ec5rb1eSnCTlOPECFDe33Sb7ZW X-Gm-Gg: AYBFou2p/+5utHRtjqt/hXe3WTAKW52/p1GAft3UcEGEkmNKwWdb60/ntH2xKMAfB9R NJ36AUCnRdxr4vS9d8y7fpBWudPfSh4QcLQfau7K/7Y6nO2paL3ZsbASBzyIBiVb32HibIs9hDD cLp61IzAvOmXVuDngoT4V/AUxs5qIoZ/4gcTXThqM2vRT6OZ2vIZyGzCB6wHMk3t5DRBpl1Lmgf Q1je0FT/CU82NH+eESRu4IbzOedrqoDENslKsQCNJPVGTUTKMwmYdVT9bDj01W/lhDj3lZJKmBa e+a4rtnC7QjRgDlUxC4rwlD7dp1mdXXgWPaXUIuJcgKNrbQTl7W/3ZEMJSK2NUHTABObd+BiRvc LryzgDlTqJE5kgvo/aQcvz16kybD6jptqNDsjIOPAbm55soJlAX5FPC1GRXmo7OKQ1GCwZxFlYO stQHRZjZe1JM/Bx1kcCoXscevuU2Uegnx00c+dcWmLNskMvfnBmrzf185DHNhTCaIeZl04D7Ewa c6qeQVcI0GYYOw9rPRNPTmD+t/VelkET8YN+q0drDqwF2ymsjlSZPZPGDdFIsQPI3ZH6UsZaC86 oKc= X-Received: by 2002:a17:902:c404:b0:2dd:c0ff:e728 with SMTP id d9443c01a7336-2df7dfdda93mr62813445ad.58.1790404411724; Fri, 25 Sep 2026 23:33:31 -0700 (PDT) Received: from yupeng-XPS-15-9520.. (c-73-169-192-12.hsd1.wa.comcast.net. [73.169.192.12]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2df91460aaasm19196895ad.73.2026.09.25.23.33.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2026 23:33:31 -0700 (PDT) From: Peng Yu To: Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni Cc: Tejun Heo , Johannes Weiner , =?UTF-8?q?Michal=20Koutn=C3=BD?= , Josef Bacik , Jens Axboe , Maurizio Lombardi , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Yu Subject: [PATCH v5 0/2] nvmet: add cgroup_id to charge namespace I/O to a cgroup Date: Fri, 25 Sep 2026 23:33:26 -0700 Message-ID: <20260926063328.257023-1-yupeng0921@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Scenario: * Create multiple nvmet subsystems/namespaces. * The namespaces are backed by different LVM logical volumes. * Some of the logical volumes share the same physical volumes. * The subsystems are exported to different users. * We should provide each user a specific iops/bps quota, thus a noisy neighbor won't impact the performance of other logical volumes. Test: 1 Load kernel modules. sudo modprobe brd rd_nr=2 rd_size=1048576 sudo modprobe nvmet sudo modprobe nvmet_tcp sudo modprobe nvme_tcp 2 The two brd devices are used for a bdev backed namespace and a file backed namespace, remember their major/minor. lsblk --noheadings --nodeps --output NAME,MAJ:MIN,SIZE /dev/ram0 /dev/ram1 ram0 1:0 1G ram1 1:1 1G 3 Enable the io controller and create two cgroups, one for the bdev backed namespace, another for the file backed namespace. echo "+io" | sudo tee /sys/fs/cgroup/cgroup.subtree_control sudo mkdir -p /sys/fs/cgroup/nvmet-bdev sudo mkdir -p /sys/fs/cgroup/nvmet-file 4 Create a file system and a file on ram0. sudo mkfs.ext4 /dev/ram0 sudo mkdir -p /mnt/nvmet-file sudo mount -o noatime /dev/ram0 /mnt/nvmet-file sudo dd if=/dev/zero of=/mnt/nvmet-file/ns.img bs=1M count=512 oflag=direct 5 Create the bdev backed subsystem and namespace. sudo mkdir -p /sys/kernel/config/nvmet/subsystems/nqn.2026-09.io.test01:bdev/namespaces/1 echo 1 | sudo tee /sys/kernel/config/nvmet/subsystems/nqn.2026-09.io.test01:bdev/attr_allow_any_host echo /dev/ram1 | sudo tee /sys/kernel/config/nvmet/subsystems/nqn.2026-09.io.test01:bdev/namespaces/1/device_path stat -c %i /sys/fs/cgroup/nvmet-bdev | sudo tee /sys/kernel/config/nvmet/subsystems/nqn.2026-09.io.test01:bdev/namespaces/1/cgroup_id echo 1 | sudo tee /sys/kernel/config/nvmet/subsystems/nqn.2026-09.io.test01:bdev/namespaces/1/enable 6 Create the file backed subsystem and namespace. sudo mkdir -p /sys/kernel/config/nvmet/subsystems/nqn.2026-09.io.test01:file/namespaces/1 echo 1 | sudo tee /sys/kernel/config/nvmet/subsystems/nqn.2026-09.io.test01:file/attr_allow_any_host echo /mnt/nvmet-file/ns.img | sudo tee /sys/kernel/config/nvmet/subsystems/nqn.2026-09.io.test01:file/namespaces/1/device_path stat -c %i /sys/fs/cgroup/nvmet-file | sudo tee /sys/kernel/config/nvmet/subsystems/nqn.2026-09.io.test01:file/namespaces/1/cgroup_id echo 1 | sudo tee /sys/kernel/config/nvmet/subsystems/nqn.2026-09.io.test01:file/namespaces/1/enable 7 Export the two subsystems to 127.0.0.1. sudo mkdir -p /sys/kernel/config/nvmet/ports/1 echo ipv4 | sudo tee /sys/kernel/config/nvmet/ports/1/addr_adrfam echo tcp | sudo tee /sys/kernel/config/nvmet/ports/1/addr_trtype echo 127.0.0.1 | sudo tee /sys/kernel/config/nvmet/ports/1/addr_traddr echo 4420 | sudo tee /sys/kernel/config/nvmet/ports/1/addr_trsvcid sudo ln -s /sys/kernel/config/nvmet/subsystems/nqn.2026-09.io.test01:bdev /sys/kernel/config/nvmet/ports/1/subsystems/nqn.2026-09.io.test01:bdev sudo ln -s /sys/kernel/config/nvmet/subsystems/nqn.2026-09.io.test01:file /sys/kernel/config/nvmet/ports/1/subsystems/nqn.2026-09.io.test01:file 8 Connect the two subsystems from 127.0.0.1. sudo nvme connect -t tcp -a 127.0.0.1 -s 4420 -n nqn.2026-09.io.test01:bdev sudo nvme connect -t tcp -a 127.0.0.1 -s 4420 -n nqn.2026-09.io.test01:file sudo udevadm settle 9 Set riops to 20k and run fio. echo "1:1 riops=20000 wiops=max rbps=max wbps=max" | sudo tee /sys/fs/cgroup/nvmet-bdev/io.max echo "1:0 riops=20000 wiops=max rbps=max wbps=max" | sudo tee /sys/fs/cgroup/nvmet-file/io.max sudo fio --name=t --filename=/dev/nvme0n1 --rw=randread --bs=4k --iodepth=32 --numjobs=1 \ --direct=1 --ioengine=libaio --time_based --runtime=10 --ramp_time=3 \ --group_reporting 2>/dev/null | grep -E '^ +(read|write): IOPS' read: IOPS=20.0k, BW=78.1MiB/s (81.9MB/s)(781MiB/10001msec) sudo fio --name=t --filename=/dev/nvme1n1 --rw=randread --bs=4k --iodepth=32 --numjobs=1 \ --direct=1 --ioengine=libaio --time_based --runtime=10 --ramp_time=3 \ --group_reporting 2>/dev/null | grep -E '^ +(read|write): IOPS' read: IOPS=20.0k, BW=78.2MiB/s (82.0MB/s)(782MiB/10001msec) 10 Set rbps to 100M and run fio. echo "1:1 riops=max wiops=max rbps=104857600 wbps=max" | sudo tee /sys/fs/cgroup/nvmet-bdev/io.max echo "1:0 riops=max wiops=max rbps=104857600 wbps=max" | sudo tee /sys/fs/cgroup/nvmet-file/io.max sudo fio --name=t --filename=/dev/nvme0n1 --rw=read --bs=1M --iodepth=32 --numjobs=1 \ --direct=1 --ioengine=libaio --time_based --runtime=10 --ramp_time=3 \ --group_reporting 2>/dev/null | grep -E '^ +(read|write): IOPS' read: IOPS=97, BW=100MiB/s (105MB/s)(1041MiB/10399msec) sudo fio --name=t --filename=/dev/nvme1n1 --rw=read --bs=1M --iodepth=32 --numjobs=1 \ --direct=1 --ioengine=libaio --time_based --runtime=10 --ramp_time=3 \ --group_reporting 2>/dev/null | grep -E '^ +(read|write): IOPS' read: IOPS=97, BW=100MiB/s (105MB/s)(1031MiB/10299msec) 11 Set wiops to 20k and run fio. echo "1:1 riops=max wiops=20000 rbps=max wbps=max" | sudo tee /sys/fs/cgroup/nvmet-bdev/io.max echo "1:0 riops=max wiops=20000 rbps=max wbps=max" | sudo tee /sys/fs/cgroup/nvmet-file/io.max sudo fio --name=t --filename=/dev/nvme0n1 --rw=randwrite --bs=4k --iodepth=32 --numjobs=1 \ --direct=1 --ioengine=libaio --time_based --runtime=10 --ramp_time=3 \ --group_reporting 2>/dev/null | grep -E '^ +(read|write): IOPS' write: IOPS=20.0k, BW=78.1MiB/s (81.9MB/s)(781MiB/10001msec); 0 zone resets sudo fio --name=t --filename=/dev/nvme1n1 --rw=randwrite --bs=4k --iodepth=32 --numjobs=1 \ --direct=1 --ioengine=libaio --time_based --runtime=10 --ramp_time=3 \ --group_reporting 2>/dev/null | grep -E '^ +(read|write): IOPS' write: IOPS=20.0k, BW=78.1MiB/s (81.9MB/s)(781MiB/10002msec); 0 zone resets 12 Set wbps to 100M and run fio. echo "1:1 riops=max wiops=max rbps=max wbps=104857600" | sudo tee /sys/fs/cgroup/nvmet-bdev/io.max echo "1:0 riops=max wiops=max rbps=max wbps=104857600" | sudo tee /sys/fs/cgroup/nvmet-file/io.max sudo fio --name=t --filename=/dev/nvme0n1 --rw=write --bs=1M --iodepth=32 --numjobs=1 \ --direct=1 --ioengine=libaio --time_based --runtime=10 --ramp_time=3 \ --group_reporting 2>/dev/null | grep -E '^ +(read|write): IOPS' write: IOPS=97, BW=100MiB/s (105MB/s)(1032MiB/10307msec); 0 zone resets sudo fio --name=t --filename=/dev/nvme1n1 --rw=write --bs=1M --iodepth=32 --numjobs=1 \ --direct=1 --ioengine=libaio --time_based --runtime=10 --ramp_time=3 \ --group_reporting 2>/dev/null | grep -E '^ +(read|write): IOPS' write: IOPS=97, BW=100MiB/s (105MB/s)(1033MiB/10296msec); 0 zone resets 13 Cleanup the environment. sudo nvme disconnect -n nqn.2026-09.io.test01:bdev sudo nvme disconnect -n nqn.2026-09.io.test01:file sudo udevadm settle sudo rm -f /sys/kernel/config/nvmet/ports/1/subsystems/nqn.2026-09.io.test01:bdev sudo rm -f /sys/kernel/config/nvmet/ports/1/subsystems/nqn.2026-09.io.test01:file sudo rmdir /sys/kernel/config/nvmet/ports/1 echo 0 | sudo tee /sys/kernel/config/nvmet/subsystems/nqn.2026-09.io.test01:bdev/namespaces/1/enable sudo rmdir /sys/kernel/config/nvmet/subsystems/nqn.2026-09.io.test01:bdev/namespaces/1 sudo rmdir /sys/kernel/config/nvmet/subsystems/nqn.2026-09.io.test01:bdev echo 0 | sudo tee /sys/kernel/config/nvmet/subsystems/nqn.2026-09.io.test01:file/namespaces/1/enable sudo rmdir /sys/kernel/config/nvmet/subsystems/nqn.2026-09.io.test01:file/namespaces/1 sudo rmdir /sys/kernel/config/nvmet/subsystems/nqn.2026-09.io.test01:file sudo umount /mnt/nvmet-file sudo rmdir /mnt/nvmet-file sudo modprobe -r brd sudo rmdir /sys/fs/cgroup/nvmet-bdev sudo rmdir /sys/fs/cgroup/nvmet-file sudo rmmod nvme_tcp sudo rmmod nvmet_tcp sudo rmmod nvmet Peng Yu (2): cgroup: export cgroup_e_css() nvmet: add cgroup_id to charge namespace I/O to a cgroup drivers/nvme/target/configfs.c | 47 ++++++++++++++++++++++++ drivers/nvme/target/core.c | 54 ++++++++++++++++++++++++++++ drivers/nvme/target/io-cmd-bdev.c | 18 +++++++++- drivers/nvme/target/io-cmd-file.c | 21 +++++++++-- drivers/nvme/target/nvmet.h | 59 +++++++++++++++++++++++++++++++ drivers/nvme/target/zns.c | 5 +++ kernel/cgroup/cgroup.c | 1 + 7 files changed, 202 insertions(+), 3 deletions(-) base-commit: d9cc476535d29a44df3f2aa3b14af9a833fddf90 -- 2.53.0