From: Kayra Cizmeci <kayracizmeci@gmail.com>
To: sshegde@linux.ibm.com
Cc: arighi@nvidia.com, chleroy@kernel.org, christian.loehle@arm.com,
corbet@lwn.net, dietmar.eggemann@arm.com, frederic@kernel.org,
gregkh@linuxfoundation.org, hdanton@sina.com,
huschle@linux.ibm.com, iii@linux.ibm.com, jgross@suse.com,
juri.lelli@redhat.com, kernellwp@gmail.com,
kprateek.nayak@amd.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, maddy@linux.ibm.com,
maz@kernel.org, meted@linux.ibm.com, mingo@kernel.org,
pauld@redhat.com, pbonzini@redhat.com, peterz@infradead.org,
rafael@kernel.org, rdunlap@infradead.org, rostedt@goodmis.org,
seanjc@google.com, srikar@linux.ibm.com, sunlightlinux@gmail.com,
tglx@kernel.org, tj@kernel.org, tommaso.cucinotta@gmail.com,
vincent.guittot@linaro.org, vineeth@bitbyteword.org,
virtualization@lists.linux.dev, vschneid@redhat.com,
ynorov@nvidia.com, yury.norov@gmail.com
Subject: Re: [PATCH v13 01/13] sched/cputime: Add kcpustat_field_total helper
Date: Sat, 26 Sep 2026 10:31:46 +0300 [thread overview]
Message-ID: <20260926073147.140907-1-kayracizmeci@gmail.com> (raw)
In-Reply-To: <20260909135617.871006-2-sshegde@linux.ibm.com>
Weekends...
> Provide a new helper function which sums up a given type of cpustat
> over a specified cpumask.
> This allows the caller's code to be simpler and avoids duplication.
> For example, subsequent patch in the steal governor use this exact
> same pattern when calculating steal time.
> @@ -207,16 +207,12 @@ static unsigned long hd_calculate_steal_percentage(void)
> {
> unsigned long time_delta, steal_delta, steal, percentage;
> static ktime_t prev;
> - int cpus, cpu;
> + int cpus;
> ktime_t now;
>
> - cpus = 0;
> - steal = 0;
> percentage = 0;
> - for_each_cpu(cpu, &hd_vmvl_cpumask) {
> - steal += kcpustat_cpu(cpu).cpustat[CPUTIME_STEAL];
> - cpus++;
> - }
> + steal = kcpustat_field_total(CPUTIME_STEAL, &hd_vmvl_cpumask);
> + cpus = cpumask_weight(&hd_vmvl_cpumask);
nit. The cpumask_weight() change is not mentioned in the commit message.
Thanks,
Kayra :>
next prev parent reply other threads:[~2026-09-26 7:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 13:56 [PATCH v13 00/13] sched, steal_governor: Introduce preferred CPUs and steal-driven vCPU backoff Shrikanth Hegde
2026-09-09 13:56 ` [PATCH v13 01/13] sched/cputime: Add kcpustat_field_total helper Shrikanth Hegde
2026-09-26 7:31 ` Kayra Cizmeci [this message]
2026-09-09 13:56 ` [PATCH v13 02/13] cpumask: Introduce cpumask_intersects_and Shrikanth Hegde
2026-09-09 16:03 ` Yury Norov
2026-09-09 13:56 ` [PATCH v13 03/13] sched/docs: Document cpu_preferred_mask and Preferred CPU concept Shrikanth Hegde
2026-09-09 13:56 ` [PATCH v13 04/13] cpumask: Introduce cpu_preferred_mask Shrikanth Hegde
2026-09-09 13:56 ` [PATCH v13 05/13] sysfs: Add preferred CPU file Shrikanth Hegde
2026-09-09 13:56 ` [PATCH v13 06/13] sched/core: Try to use a preferred CPU in is_cpu_allowed Shrikanth Hegde
2026-09-25 7:43 ` Peter Zijlstra
2026-09-25 9:16 ` Shrikanth Hegde
2026-09-09 13:56 ` [PATCH v13 07/13] sched/fair: Load balance only among preferred CPUs Shrikanth Hegde
2026-09-09 17:19 ` Yury Norov
2026-09-09 13:56 ` [PATCH v13 08/13] sched/core: Push current task from non preferred CPU Shrikanth Hegde
2026-09-25 7:49 ` Peter Zijlstra
2026-09-25 9:47 ` Shrikanth Hegde
2026-09-09 13:56 ` [PATCH v13 09/13] sched/debug: Add migration stats due to non preferred CPUs Shrikanth Hegde
2026-09-25 7:51 ` Peter Zijlstra
2026-09-25 9:49 ` Shrikanth Hegde
2026-09-25 15:45 ` Peter Zijlstra
2026-09-25 16:30 ` Shrikanth Hegde
2026-09-09 13:56 ` [PATCH v13 10/13] virt: Introduce steal governor driver Shrikanth Hegde
2026-09-09 13:56 ` [PATCH v13 11/13] virt/steal_governor: Add control knobs for handling steal values Shrikanth Hegde
2026-09-09 13:56 ` [PATCH v13 12/13] virt/steal_governor: Implement steal_governor policy loop Shrikanth Hegde
2026-09-09 13:56 ` [PATCH v13 13/13] virt/steal_governor: Enable the driver Shrikanth Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260926073147.140907-1-kayracizmeci@gmail.com \
--to=kayracizmeci@gmail.com \
--cc=arighi@nvidia.com \
--cc=chleroy@kernel.org \
--cc=christian.loehle@arm.com \
--cc=corbet@lwn.net \
--cc=dietmar.eggemann@arm.com \
--cc=frederic@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdanton@sina.com \
--cc=huschle@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=jgross@suse.com \
--cc=juri.lelli@redhat.com \
--cc=kernellwp@gmail.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=maz@kernel.org \
--cc=meted@linux.ibm.com \
--cc=mingo@kernel.org \
--cc=pauld@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=seanjc@google.com \
--cc=srikar@linux.ibm.com \
--cc=sshegde@linux.ibm.com \
--cc=sunlightlinux@gmail.com \
--cc=tglx@kernel.org \
--cc=tj@kernel.org \
--cc=tommaso.cucinotta@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=vineeth@bitbyteword.org \
--cc=virtualization@lists.linux.dev \
--cc=vschneid@redhat.com \
--cc=ynorov@nvidia.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®