From: Hungyu Lin <dennylin0707@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Dan Carpenter <error27@gmail.com>,
Hungyu Lin <dennylin0707@gmail.com>
Subject: [PATCH] staging: rtl8723bs: make rtw_register_tx_alive() return bool
Date: Sat, 26 Sep 2026 11:11:25 +0000 [thread overview]
Message-ID: <20260926111125.5036-1-dennylin0707@gmail.com> (raw)
rtw_register_tx_alive() only reports whether the transmit path can
continue, and its only caller treats the return value as a boolean.
Change the return type to bool and replace _SUCCESS and _FAIL with true
and false. Update the caller accordingly.
No functional change.
Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 12 ++++++------
drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 4 +---
drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
3 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
index 448611ad8237..007ead477a51 100644
--- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
+++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
@@ -771,13 +771,13 @@ void rtw_unregister_task_alive(struct adapter *padapter, u32 task)
* _SUCCESS rtw_xmit_thread can write fifo/txcmd afterwards.
* _FAIL rtw_xmit_thread can not do anything.
*/
-s32 rtw_register_tx_alive(struct adapter *padapter)
+bool rtw_register_tx_alive(struct adapter *padapter)
{
- s32 res;
+ bool res;
struct pwrctrl_priv *pwrctrl;
u8 pslv;
- res = _SUCCESS;
+ res = true;
pwrctrl = adapter_to_pwrctl(padapter);
pslv = PS_STATE_S2;
@@ -788,7 +788,7 @@ s32 rtw_register_tx_alive(struct adapter *padapter)
if (pwrctrl->fw_current_in_ps_mode) {
if (pwrctrl->cpwm < pslv) {
if (pwrctrl->cpwm < PS_STATE_S2)
- res = _FAIL;
+ res = false;
if (pwrctrl->rpwm < pslv)
rtw_set_rpwm(padapter, pslv);
}
@@ -796,9 +796,9 @@ s32 rtw_register_tx_alive(struct adapter *padapter)
mutex_unlock(&pwrctrl->lock);
- if (res == _FAIL)
+ if (!res)
if (pwrctrl->cpwm >= PS_STATE_S2)
- res = _SUCCESS;
+ res = true;
return res;
}
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
index 0441e84ea87d..e4d216924262 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
@@ -139,10 +139,8 @@ s32 rtl8723bs_xmit_buf_handler(struct adapter *padapter)
if (!queue_pending)
return _SUCCESS;
- ret = rtw_register_tx_alive(padapter);
- if (ret != _SUCCESS) {
+ if (!rtw_register_tx_alive(padapter))
return _SUCCESS;
- }
do {
queue_empty = rtl8723_dequeue_writeport(padapter);
diff --git a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
index 49f19b6ee329..1605d32c8bf8 100644
--- a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
+++ b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
@@ -217,7 +217,7 @@ void rtw_free_pwrctrl_priv(struct adapter *adapter);
s32 rtw_register_task_alive(struct adapter *adapter, u32 task);
void rtw_unregister_task_alive(struct adapter *adapter, u32 task);
-s32 rtw_register_tx_alive(struct adapter *padapter);
+bool rtw_register_tx_alive(struct adapter *padapter);
void rtw_unregister_tx_alive(struct adapter *padapter);
s32 rtw_register_cmd_alive(struct adapter *padapter);
void rtw_unregister_cmd_alive(struct adapter *padapter);
--
2.43.0
reply other threads:[~2026-09-26 11:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260926111125.5036-1-dennylin0707@gmail.com \
--to=dennylin0707@gmail.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®