From: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
To: akpm@linux-foundation.org, rppt@kernel.org
Cc: peterx@redhat.com, surenb@google.com, aarcange@redhat.com,
david@kernel.org, ljs@kernel.org, liam@infradead.org,
vbabka@kernel.org, mhocko@suse.com, shuah@kernel.org,
kirill@shutemov.name, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
donggeunyoo.kernel@gmail.com
Subject: [PATCH v3 0/2] userfaultfd: clear the inherited uffd bit in move_swap_pte()
Date: Sat, 26 Sep 2026 21:41:43 +0900 [thread overview]
Message-ID: <20260926124145.2878520-1-donggeunyoo.kernel@gmail.com> (raw)
UFFDIO_MOVE on a swapped-out page installs the source PTE at the
destination unchanged, so a uffd bit set on a write-protected or
RWP-protected source lands in a destination VMA that was never
registered for either, and nothing clears it afterwards. Patch 1 clears the bit, then re-arms it if
the destination is RWP-registered, which is what the present-page and
zeropage move paths already do. Patch 2 adds the tests that catch it.
v1: https://lore.kernel.org/all/20260919004630.1159895-1-donggeunyoo.kernel@gmail.com/
v2: https://lore.kernel.org/all/20260925042907.2330519-1-donggeunyoo.kernel@gmail.com/
Changes in v3:
- patch 1: describe the userspace-visible effects and the backport
(Andrew Morton, David Hildenbrand)
- patch 2: drop the MADV_PAGEOUT retry loop (David Hildenbrand)
- patch 2: add an RWP case (David Hildenbrand)
Changes in v2:
- patch 1: clear the bit unconditionally (Kiryl Shutsemau)
- patch 1: rewrite the changelog for readability (Mike Rapoport)
- add Assisted-by: LLM (Mike Rapoport)
x86_64 defconfig plus USERFAULTFD, TRANSPARENT_HUGEPAGE,
PAGE_TABLE_CHECK_ENFORCED and a swap device, under QEMU, on
6812ce4e4379:
uffd-unit-tests before after
move-swap-wp on anon not ok ok
move-swap-rwp on anon not ok ok
the other 103 unit tests ok ok
uffd-wp-mremap, 38 tests ok ok
11 unit tests skip on both, as CONFIG_GUP_TEST is not set.
pagemap bit 57 at the destination before after
swapped page, dst not armed set clear
swapped page, dst WP-armed set clear
swapped page, dst RWP-armed set set
resident page, dst WP-armed clear clear
MADV_COLLAPSE over 2 MB at dst EINVAL 0
fault on the moved page at dst WARNING none
Donggeun Yoo (2):
userfaultfd: clear the inherited uffd bit in move_swap_pte()
selftests/mm: add tests for UFFDIO_MOVE of a uffd-protected swap entry
mm/userfaultfd.c | 1 +
tools/testing/selftests/mm/uffd-unit-tests.c | 84 ++++++++++++++++++++
2 files changed, 85 insertions(+)
--
2.53.0
next reply other threads:[~2026-09-26 12:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 12:41 Donggeun Yoo [this message]
2026-09-26 12:41 ` [PATCH v3 1/2] " Donggeun Yoo
2026-09-26 12:41 ` [PATCH v3 2/2] selftests/mm: add tests for UFFDIO_MOVE of a uffd-protected swap entry Donggeun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260926124145.2878520-1-donggeunyoo.kernel@gmail.com \
--to=donggeunyoo.kernel@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=kirill@shutemov.name \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®