From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB1A23939B9 for ; Sat, 26 Sep 2026 18:31:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790447528; cv=none; b=mAwG2PHtnDNLsS1nd2oNZc0i92PGPnHonDOe7H++ZYVLvd+aPapfH7aOATc2EG8wM0xMX0sXjPfR0E4sskICHzEGNMadjiTJNTqm2jfQZCl0VKTvY8JGrUFnQQXguyWpl165BYgemUT8jJjyS+yOBkdK5TEn5buMDTcMbHha4h0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790447528; c=relaxed/simple; bh=apgf8vIWTkwBl/+0WMf8Eoc00UQokqsqAOnW9G/KdIk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gX5GA7wQfnSQfpFtRlzTV/viCuSvlg4CBHaA+Vn6fsotgDvGve6m8oM8pejadUFQkOfQpREa5zzPTrS6iBLMCStgEgCVbAw/rGCeJo28tRdrfCi9CetBWoQTaMMYZ3Ko6IyBfDcX3M2PSBib982ir4bPrSwxpw86FjmKqXQZGRU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lQXusu/G; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=F9nKNqt9; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lQXusu/G"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="F9nKNqt9" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68QGxW4b499170 for ; Sat, 26 Sep 2026 18:31:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=zk3EFZth1oJ /gVFkRmzbBP0BnUbUUlEChymi6rBEiHw=; b=lQXusu/GJwD5OG/M8IwZrtRKLXP 7CpNTJfQtYJ0uNldqoOUBanEgRO3r0EsrY0Il44hvlgCaJgYdn8R6Obqn5pQgL2q XT4Zm9OjJs6tRZpieL/qG3Yev2qwFeovQafyvvGktpBsF1Mtrcbe/CVeQIxqY+/M 0x8dgKhf/v8d15hP75wc7cDA0A3tbSFtDVELAjVC4D7WA9W16notzwJ1ToTPkAUb Fw/9jmoaf89m/2BxdJxKm5sXfThflzVEmtJbA6ny2D1yCt95LAwvMqrmAE1SerFj kTOpUy7Ib1nTNX1jfKDW2rMbTh9Q5PSlWzTeyk0SPDJmRbuqRo1KXWN78HQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gx64uskgu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 26 Sep 2026 18:31:58 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2ccb687f82eso12429955ad.3 for ; Sat, 26 Sep 2026 11:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790447518; x=1791052318; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zk3EFZth1oJ/gVFkRmzbBP0BnUbUUlEChymi6rBEiHw=; b=F9nKNqt9xpTvvqNlOUz9DSPqMNu0VfxJ+H5lWKlUtH1twmUrt+snBn/S3DCs+ert7B 2CQlyWB1F2t0zSXR8dVa0eShUawPP4f+pX6DdohG3g/IcWQ/XSatS4QzRfwRlNT64rai PmOK3LmdKqxsbpuU0PMBI9zbINBxXgk8AxvBNJz9PzBqvEpPWdBjZ9kgyWbaHXHOYf/9 5TYfFKQ89os4lOcbXn3AlSMefj9jBzvuC4pi6iGs37iHpRSzHDPOkxaxxJZrQ3up7Kl3 ANADB1M24cp6c/Y+y17ZdUWCw2fLxDZAytK/VR2pQRKg/2Frnv7zv7tL0O4c7su7Zo3i yZMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790447518; x=1791052318; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=zk3EFZth1oJ/gVFkRmzbBP0BnUbUUlEChymi6rBEiHw=; b=aNBD8jc0lxttdcr6vtnnHldZ1s4eiZuVI9T4vEjTnetSVZLin456kuANMiSIoZDpJo 6WU9o93Gdyy/XXC8VW8O5Y0RvSUHuGlNe3+AsLo//AktHutFQH+ZAqeq/NbZjFZt7aUr vRIsZUILCYdatH27yoQQ7Hdzp9Sy9IRg7zgVSARf2dZ7gAGJ3ipRmBDaZuFpF1Iau7T9 xozEvbe8r3YK4UlYF9kW20mQ/1J/5h8rTH1qiBP8MRNGVbXwZmu+kBasCQ/1h8xwjBnX ruTCBdjC9wRtTxpPrREfAaEOpGJMD4IOshOXEhNXVYLnYQNnDbEGWtYvY7QSyLC6iS1k W1tg== X-Forwarded-Encrypted: i=1; AKwUvBy6am8GYFRWIW2RpmIF/KZGev5gxeBwbFOAzR/fTnQLGvzY7OFmakRah8lnWx1E3gaPq+uPznqUTLjgeF4=@vger.kernel.org X-Gm-Message-State: AFq9FYK/2CLSLiwZzGcMyBwfp2WIUpMNIGULOAXLY+FV5y4zj+f4p8qe 4XZu1UgY8sbO/sJjR502csj+spB5OzRQQMcE9VZvEhcu9FYJLV4FOIKoXS9OL7qgxduQxkzB0o2 lpejnU6j+RRrdjk8ba76zOLLAcrKAY4ZCnYpG7iHw6srMPviLRtS/e/rOZfyZi1GHg+s= X-Gm-Gg: AYBFou3BnjHbsGqMmsAWx8xZz/C+6617I4hAxkRk3ZjdCLI7M9IE2wKW1rsWRjIwvc0 rKibMVMbEGvYLummo983Y+YsD7oK2JoBjcQA3rv6WiENxwMvDRXJWPMl32B3XAcl3Rj4pxYBoOS HKTD5hpDpAlvTVkb4RDdj02Rr6ZxnLtu1sG1nJfHzVvD6xlj6Q3MSSoWayZF04qd8phm/HmbzxH 4/WcGHDq0sJsrci96jpctwKGXVgsJdE81h5RDH2DwZRECLxYawM89Bg9PYxXXwlsMR4k+EXkjIp JN/6VTX31nJMKQMlN2Fr56+5hd/5wwt0HKK/nz4jnytr46yppHkWT01xqbmTpoVhXq84i1ab6lD dLlup9dcBCqiRtXxwX0t+PVCi3x+whwH3OmWvaw4lXIl7Nw== X-Received: by 2002:a17:90b:2683:b0:3a0:dbe7:971b with SMTP id 98e67ed59e1d1-3a0dbe79bc2mr2071270a91.67.1790447517583; Sat, 26 Sep 2026 11:31:57 -0700 (PDT) X-Received: by 2002:a17:90b:2683:b0:3a0:dbe7:971b with SMTP id 98e67ed59e1d1-3a0dbe79bc2mr2071253a91.67.1790447517113; Sat, 26 Sep 2026 11:31:57 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a0b9355e49sm10921274a91.4.2026.09.26.11.31.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Sep 2026 11:31:56 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Jianfeng Liu , =?UTF-8?q?Christian=20K=C3=B6nig?= , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 5/6] drm/msm/gem: Stop calling get_pages() for imported dma-bufs Date: Sat, 26 Sep 2026 11:30:45 -0700 Message-ID: <20260926183051.25754-6-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260926183051.25754-1-robin.clark@oss.qualcomm.com> References: <20260926183051.25754-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI2MDA3MyBTYWx0ZWRfX4jgMcWsdbZ+G ySrOeNDedn/tml1WQxe645B/R7q8dfUcAycDWSl92UbjaF6rU173GX9CGEnNisH52zRn22bO0x0 Mq7GwhC5yBRStDMn8cVSnw+I6QMWVCg= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI2MDA3MyBTYWx0ZWRfXyC03xDkNBV9e sJeQe29jHe2ke7Ae70kw5RgQ5fYXxwFnEY+rp9CWTvRXVLu3mpRHlekfAJr5g3nBULo2ufmrSHp lfXLvIJ2kKnaIVTC+EYUWAT4XPNRE5hgwSqQ5sqQEbPDFk9dmsxpEuDdY0rRL9GyIlVjVu4Z/N9 RvHyFa9S4Jugy9NH59QBBTenhs4EMHG2Gm0RY18ZDA//7qG/Z8VXlV1J55KIny6VGdJNTkBySN8 w0wwOnP4iXhzgfcJEmoi2HPoUpOzaY0Ts0aRlS907dInmSGqmptA9vSPcL+oUhMUEsZhxiYYpim 2ejhPaaKzJbCvAbLC7cKSR4XuJTCK6gnd21NphYjZotLMXiEba3DGdNNlB4jVV6iEwhIzngaskh b0/n+k5q+/Y542EQvRHsmX8wtBxaBAuRmED/a1tZ2g4ZBxO3wuX4NnOrTGz0XxUUHsNAbImeZWh sOU7VwqjbhyExPw80ig== X-Proofpoint-ORIG-GUID: qZNnm5HU-DXBDFwgJFAyMI_ot_knnmaO X-Authority-Analysis: v=2.4 cv=E6xYNqdl c=1 sm=1 tr=0 ts=6ab80f9e cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=isCY8TonHXl0-fnU9HAA:9 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: qZNnm5HU-DXBDFwgJFAyMI_ot_knnmaO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-26_05,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 impostorscore=0 malwarescore=0 adultscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609260073 Use msm_obj->sgt rather than msm_obj->pages to determine that a obj is resident. The sgt is populated up-front for imported dma-bufs, so we will never go down the get_pages() path for imported objects. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 6 ++++++ drivers/gpu/drm/msm/msm_gem.h | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index 2341f209adf5..3111d7389572 100644 --- a/drivers/gpu/drm/msm/msm_gem.c +++ b/drivers/gpu/drm/msm/msm_gem.c @@ -193,6 +193,9 @@ static struct page **get_pages(struct drm_gem_object *obj) msm_gem_assert_locked(obj); + if (drm_WARN_ON_ONCE(obj->dev, drm_gem_is_imported(obj))) + return ERR_PTR(-EINVAL); + if (!msm_obj->pages) { struct drm_device *dev = obj->dev; struct page **p; @@ -286,6 +289,9 @@ int msm_gem_make_resident_locked(struct drm_gem_object *obj, unsigned madv) if (err) return err; + if (is_resident(to_msm_bo(obj))) + return 0; + struct page **pages = get_pages(obj); if (IS_ERR(pages)) return PTR_ERR(pages); diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h index 4f681100ecb0..e92c6723d352 100644 --- a/drivers/gpu/drm/msm/msm_gem.h +++ b/drivers/gpu/drm/msm/msm_gem.h @@ -422,7 +422,7 @@ static inline bool is_unevictable(struct msm_gem_object *msm_obj) /* Are backing pages/sgt allocated? */ static inline bool is_resident(struct msm_gem_object *msm_obj) { - return !!msm_obj->pages; + return !!msm_obj->sgt; } void msm_gem_purge(struct drm_gem_object *obj); -- 2.55.0