From: Clover <alex@ironrobin.net>
To: "Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Steev Klimaszewski <threeway@gmail.com>,
platform-driver-x86@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/3] arm64: dts: qcom: sc8280xp-x13s: Add embedded controller
Date: Sat, 26 Sep 2026 19:54:56 +0000 [thread overview]
Message-ID: <20260926195415.5995-4-alex@ironrobin.net> (raw)
In-Reply-To: <20260926195415.5995-1-alex@ironrobin.net>
Enable the embedded controller at address 0x28 on i2c8, with GPIO103 as
its falling-edge event interrupt and wake source.
Configure the QUP8 bus on GPIO43 and GPIO44 with 2 mA drive strength and
pull-ups, matching the working firmware-established pin configuration.
Configure GPIO103 as an input without overriding its existing pull
configuration. Describe GPIO176 as the separate active-high power-state
output and configure it initially high with bias disabled.
Assisted-by: LLM
Signed-off-by: Clover <alex@ironrobin.net>
---
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
index 218573a97785b04528854b03a99c837558a33c1e..1b875809773dac3bb0d1dafb1c9bb41a88f5027f 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
@@ -806,6 +806,25 @@ &i2c4 {
};
};
+&i2c8 {
+ clock-frequency = <400000>;
+
+ pinctrl-0 = <&i2c8_default>;
+ pinctrl-names = "default";
+
+ status = "okay";
+
+ embedded-controller@28 {
+ compatible = "lenovo,thinkpad-x13s-ec";
+ reg = <0x28>;
+ interrupts-extended = <&tlmm 103 IRQ_TYPE_EDGE_FALLING>;
+ power-state-gpios = <&tlmm 176 GPIO_ACTIVE_HIGH>;
+ pinctrl-0 = <&ec_int_n>, <&ec_power_state>;
+ pinctrl-names = "default";
+ wakeup-source;
+ };
+};
+
&i2c11 {
clock-frequency = <400000>;
@@ -1571,6 +1590,21 @@ cam_rgb_default: cam-rgb-default-state {
};
};
+ ec_int_n: ec-int-n-state {
+ pins = "gpio103";
+ function = "gpio";
+ input-enable;
+ /* Preserve firmware pull configuration; no bias override. */
+ };
+
+ ec_power_state: ec-power-state {
+ pins = "gpio176";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ output-high;
+ };
+
edp_reg_en: edp-reg-en-state {
pins = "gpio25";
function = "gpio";
@@ -1591,6 +1625,13 @@ i2c4_default: i2c4-default-state {
bias-disable;
};
+ i2c8_default: i2c8-default-state {
+ pins = "gpio43", "gpio44";
+ function = "qup8";
+ drive-strength = <2>;
+ bias-pull-up;
+ };
+
i2c11_default: i2c11-default-state {
pins = "gpio18", "gpio19";
function = "qup11";
prev parent reply other threads:[~2026-09-26 19:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 19:54 [PATCH v2 0/3] Lenovo ThinkPad X13s embedded controller support Clover
2026-09-26 19:54 ` [PATCH v2 1/3] dt-bindings: embedded-controller: Add Lenovo ThinkPad X13s EC Clover
2026-09-27 17:21 ` Krzysztof Kozlowski
2026-09-28 2:53 ` Alex R
2026-09-26 19:54 ` [PATCH v2 2/3] platform: arm64: Add Lenovo ThinkPad X13s EC driver Clover
2026-09-26 19:54 ` Clover [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260926195415.5995-4-alex@ironrobin.net \
--to=alex@ironrobin.net \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh@kernel.org \
--cc=threeway@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®