From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f3.google.com (mail-pj2-f3.google.com [74.125.227.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BFE02F3614 for ; Sun, 27 Sep 2026 02:56:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790477803; cv=none; b=cFYK5+XyVyQm70FqPNQlVWNlkv1/Y92ZehtD3KOMBcpwmBxf7DMapeJuNheW+a2Is20o5dBNKlL2uuFk/tFAXz+7LNERzuKHoawqBvmGdqlxbxFvrXIg7bJ452NTSiL9FeRctWSCOABdNCZ93DLhhXRK+7R8jUnaNuDVGa/3tg4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790477803; c=relaxed/simple; bh=eMvIylI6UdB4voWaYZ2XSYSfydZcKpLaBkAqaZ9abjI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=SkzdkXKJEeJazZt5QFJzYZXf/EiZfZRAEnzsmMec5ZTqfgenjGAvRE8/xiGKsahVcrg//noBoH7IGJEg4Lo/fFGidgVSjN7TyMi4/KfY/w2XjnZHxdhe9wuiHLyMy2zqXmQQmlVFfTa3dMwCqunD6qCcjFIThz90c76Y/EeZQIU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=embeddedlinux.blog; spf=pass smtp.mailfrom=embeddedlinux.blog; dkim=pass (2048-bit key) header.d=embeddedlinux.blog header.i=@embeddedlinux.blog header.b=gm8UKq5k; arc=none smtp.client-ip=74.125.227.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=embeddedlinux.blog Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=embeddedlinux.blog Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=embeddedlinux.blog header.i=@embeddedlinux.blog header.b="gm8UKq5k" Received: by mail-pj2-f3.google.com with SMTP id d9443c01a7336-2dfb6149d59so3016475ad.0 for ; Sat, 26 Sep 2026 19:56:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embeddedlinux.blog; s=google; t=1790477802; x=1791082602; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qyMsLj0hkCZGFDmY3GbC7EId9UWnZfSNH3ILjJaXTeM=; b=gm8UKq5kGslTGA/oSdr1Tcgs/Xd/sqHIXTMtNWtGxjP/GEoYFG3Hb2MGN0JoGx2MYF 2WIqt8m+XBzEXhqEtsc8ofJAC/zR6qmwn7QVlVC2x4nXIFLLMXgcAjahc4AsvkH14+iy XXbSRA/iM1Br7/3TRiyPol30diJXmXTEYGL9uiaajgQKPUKBCggXfGWt3+NJqz88Zcrz C9FvZtzNmXEwieZ4COLSgqBn2JVNqPHyyhhL6NLMZBz2DQkN4OT3wOA9n8nixwP607Hl I+TKm/jEMxyXzKs86VEKn854f5JqppgtoVQEUJhHXSDtYaFQXdJoLOhpZYJRKSpPVoQs cr+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790477802; x=1791082602; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qyMsLj0hkCZGFDmY3GbC7EId9UWnZfSNH3ILjJaXTeM=; b=VKmQgllC0NAHUWjYODQSKJvX1NfW3dgvwsjFuRBKU6ACDGzufqNXU7LFeQQFdC54a7 d6ObWwlsPhmeVaIqSmJFLFL7I3PFzR31VPaRhU0MvViKpRaDzw1S0BCcZiL9q6CEgN1D 5Bb6YkrPMzyah5udnL0JD8Q18X0vXOaX7GiPfpvnHqMZSo+0v46DA7WJpl8XWK8/USbo jzf4jstCdmbRirb5GTlnio+ihg5dFz4eRhGue37i4AVMBP7FEs3PLeuLIJBsmSF4vZrI SVnBIhllXwsOs5fbTh2zLEHrTgPOQtM+m/slGxT7kOSDUdmbA/zulJi9tNtA6AudVckl VQsw== X-Forwarded-Encrypted: i=1; AKwUvBwTMrRGmPGYCmFa5zsrCHdz4q4TGqSZlZywThv70sX9FpJU6E12BMXhyHEd980f+3f/ASaKHA9aTLpSdH8=@vger.kernel.org X-Gm-Message-State: AFq9FYIhJNgosT+1wIBScmzDMllloR4VoX4QPxpXK3JGCNXS/2jk8wTq qlyuY4fjJcH8cVj0rdhW8wbIloeezaDw/AGEWPLIx/6H88jA+/2oFR9c7N5fGKD5vDVV X-Gm-Gg: AYBFou39dZrAijLT3PhREeq7gwIv1PlSRiSicqejZ+fYmcm5GcV7hTb5j32M5raEnA8 Zq5aNheuyx2t95M0PYxMyWkj6XF6i3Jy0QZ7xITyxIT9LNy64in5HuHT70f6r39PJ6xKrgtECuP gmwaCUuIZ4qvU0epsp4q5ByOx4THuy6A9dIrJQzW/fw5LEXL6UC0LChgB2OgZoDB2zjandRMsw5 sxUD62yeeT7nJum4vVkkn9BdXrCGMfKTvH5b5oznB9OBOAj0u4byDray6IuGxbXSy6mfgllRKMO ng/R13HNX9/nKxjBH1M8/M1ijDng38RsL1sLNQVZs845aMwZLqPtGCIceJCdScNTkPg1o6X5wWX NQVfp/2q5q5Zb+RHSBiRUOzLcDuxeDMaSTHfsbVjLdMB+5+5BbB74yh0hyJyJ8RNS0aSpxLuDbT DJjMXUBTKHVf6Ocr9LH2G4p6YHdlMIlc4kOC3PaRK8JtPAE2ZhetWRABXA7bq+oc+qOA== X-Received: by 2002:a17:902:e94f:b0:2df:a4a0:6443 with SMTP id d9443c01a7336-2dfa4a06479mr31921045ad.13.1790477801815; Sat, 26 Sep 2026 19:56:41 -0700 (PDT) Received: from ltu.. ([171.245.4.151]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2df9142bfd4sm25512285ad.52.2026.09.26.19.56.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Sep 2026 19:56:40 -0700 (PDT) From: Nguyen Minh Tien To: Wilken Gottwalt , Bjorn Andersson Cc: Baolin Wang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Philipp Zabel , Andre Przywara , Bastian Germann , linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, tien.nguyenminh@embeddedlinux.blog Subject: [PATCH 1/3] hwspinlock: sun6i: Get the clock and the reset without names Date: Sun, 27 Sep 2026 09:56:24 +0700 Message-Id: <20260927025626.69614-2-tien.nguyenminh@embeddedlinux.blog> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260927025626.69614-1-tien.nguyenminh@embeddedlinux.blog> References: <20260927025626.69614-1-tien.nguyenminh@embeddedlinux.blog> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver looks up its clock and reset by the name "ahb", but the binding doesn't define clock-names or reset-names, so a node that follows the binding fails to probe: sun6i_hwspinlock 3005000.hwlock: unable to get AHB clock (-2) There is only one of each, so get them without a name. That is what was asked for when the names were added to an A64 node, and nodes that do set "ahb" keep working. For the reset, call the explicit devm_reset_control_get_exclusive(), which devm_reset_control_get() only wraps. Fixes: 3c881e05c814 ("hwspinlock: add sun6i hardware spinlock support") Link: https://lore.kernel.org/f720eaf9-01d0-0e57-f6bf-9aade00aafb8@linaro.org Signed-off-by: Nguyen Minh Tien --- drivers/hwspinlock/sun6i_hwspinlock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwspinlock/sun6i_hwspinlock.c b/drivers/hwspinlock/sun6i_hwspinlock.c index c2d3145880..e7cc121310 100644 --- a/drivers/hwspinlock/sun6i_hwspinlock.c +++ b/drivers/hwspinlock/sun6i_hwspinlock.c @@ -104,14 +104,14 @@ static int sun6i_hwspinlock_probe(struct platform_device *pdev) if (!priv) return -ENOMEM; - priv->ahb_clk = devm_clk_get(&pdev->dev, "ahb"); + priv->ahb_clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(priv->ahb_clk)) { err = PTR_ERR(priv->ahb_clk); dev_err(&pdev->dev, "unable to get AHB clock (%d)\n", err); return err; } - priv->reset = devm_reset_control_get(&pdev->dev, "ahb"); + priv->reset = devm_reset_control_get_exclusive(&pdev->dev, NULL); if (IS_ERR(priv->reset)) return dev_err_probe(&pdev->dev, PTR_ERR(priv->reset), "unable to get reset control\n"); -- 2.34.1