From: Andrew Morton <akpm@linux-foundation.org>
To: Jiale Yao <yaojiale02@163.com>
Cc: Dan Williams <djbw@kernel.org>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Joao Martins <joao.m.martins@oracle.com>,
nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] dax/device: defer publishing the dynamic pgmap
Date: Sun, 27 Sep 2026 13:05:26 -0700 [thread overview]
Message-ID: <20260927130526.a6da56f1515cf1772cb45631@linux-foundation.org> (raw)
In-Reply-To: <20260927114736.1113965-1-yaojiale02@163.com>
On Sun, 27 Sep 2026 19:47:36 +0800 Jiale Yao <yaojiale02@163.com> wrote:
> The dynamic device-dax probe path publishes its devm-allocated pgmap
> before several operations that can still fail. If one of them fails,
> devres frees the pgmap while dev_dax->pgmap remains non-NULL. A later
> bind then fails the dynamic-dax invariant check and leaves the device
> unusable until its region is recreated.
>
> Defer assigning dev_dax->pgmap until the final devm action has been
> installed and probe can no longer fail. A failed probe then never
> publishes the temporary pgmap.
lgtm, thanks.
> Fixes: fc65c4eb0b2a ("device-dax: ensure dev_dax->pgmap is valid for dynamic devices")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jiale Yao <yaojiale02@163.com>
I'll queue this for next-merge-window as it doesn't seem very urgent.
Retaining cc:stable. I've marked it as "needs maintainer acks".
prev parent reply other threads:[~2026-09-27 20:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 11:47 Jiale Yao
2026-09-27 20:05 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260927130526.a6da56f1515cf1772cb45631@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alison.schofield@intel.com \
--cc=dave.jiang@intel.com \
--cc=djbw@kernel.org \
--cc=joao.m.martins@oracle.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
--cc=yaojiale02@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®