From: Francesco Dolcini <francesco@dolcini.it>
To: Jiale Yao <yaojiale02@163.com>
Cc: Wei Fang <wei.fang@nxp.com>, Frank Li <frank.li@nxp.com>,
Shenwei Wang <shenwei.wang@nxp.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Fabio Estevam <fabio.estevam@freescale.com>,
imx@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 2/7] net: fec: manage the netdev lifetime with devres
Date: Sun, 27 Sep 2026 16:37:45 +0200 [thread overview]
Message-ID: <20260927143745.GA54546@francesco-nb> (raw)
In-Reply-To: <20260927111005.1035089-3-yaojiale02@163.com>
On Sun, Sep 27, 2026 at 07:09:59PM +0800, Jiale Yao wrote:
> fec_drv_remove() frees the netdev before devres releases the managed
> IRQs whose handlers use it as their data pointer. A late interrupt can
> therefore access the freed netdev.
>
> Allocate the netdev with devres so that the later IRQ registrations are
> released first during teardown.
>
> Fixes: 0d9b2ab1c376 ("fec: Use devm_request_irq()")
>
remove the empty line, tags should be all together without any empty
line in-between. same applies to the other commits.
> Cc: stable@vger.kernel.org
> Signed-off-by: Jiale Yao <yaojiale02@163.com>
Francesco
next prev parent reply other threads:[~2026-09-27 14:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 11:09 [PATCH 0/7] net: ethernet: release managed IRQs before freeing netdevs Jiale Yao
2026-09-27 11:09 ` [PATCH 1/7] net: macb: manage the netdev lifetime with devres Jiale Yao
2026-09-27 11:09 ` [PATCH 2/7] net: fec: " Jiale Yao
2026-09-27 14:37 ` Francesco Dolcini [this message]
2026-09-27 14:53 ` jiale yao
2026-09-27 11:10 ` [PATCH 3/7] net: hip04: " Jiale Yao
2026-09-27 11:10 ` [PATCH 4/7] net: hisi_femac: " Jiale Yao
2026-09-27 11:10 ` [PATCH 5/7] net: hix5hd2: " Jiale Yao
2026-09-27 11:10 ` [PATCH 6/7] net: ravb: fix resource teardown ordering Jiale Yao
2026-09-27 11:10 ` [PATCH 7/7] net: sxgbe: manage IRQ data lifetimes with devres Jiale Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260927143745.GA54546@francesco-nb \
--to=francesco@dolcini.it \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fabio.estevam@freescale.com \
--cc=frank.li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenwei.wang@nxp.com \
--cc=stable@vger.kernel.org \
--cc=wei.fang@nxp.com \
--cc=yaojiale02@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®