From: Lorenzo Delgado <lnsdev@proton.me>
To: Danilo Krummrich <dakr@kernel.org>
Cc: "Lorenzo Delgado" <lnsdev@proton.me>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Tamir Duberstein" <tamird@kernel.org>,
"Onur Özkan" <work@onurozkan.dev>,
"Abdiel Janulgue" <abdiel.janulgue@gmail.com>,
"Robin Murphy" <robin.murphy@arm.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
nova-gpu@lists.linux.dev, driver-core@lists.linux.dev,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v3] rust: io: convert ResourceSize into a transparent newtype
Date: Sun, 27 Sep 2026 18:11:57 +0000 [thread overview]
Message-ID: <20260927181154.1757237-1-lnsdev@proton.me> (raw)
In-Reply-To: <DLNPXJ4WPH4L.2MBUGV1TAESYY@kernel.org>
On Thu Sep 24, 2026 at 7:21 PM CEST, Danilo Krummrich wrote:
> So, I think we should change dma_len() to just return u32 (I'm also fine with a
> new type, but it might be slighly overkill).
>
> I'd usually pick this patch regardless and leave that for a follow-up, as it is
> a separate issue. But if we change dma_len() first, we only have to update tyr
> once, whereas if change it after we end up touching nova and tyr twice.
Makes sense, thanks. I sent v4 with a patch in front that makes dma_len()
return u32, so the newtype patch no longer touches tyr or nova-core:
https://lore.kernel.org/r/20260927-resource-size-newtype-v4-0-447a08af23fb@proton.me
Heads-up: patch 1 interacts with Alexandre's nova_num on one line in
gsp.rs. Whichever lands second needs a two-line fixup; details in the
cover letter.
prev parent reply other threads:[~2026-09-27 18:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 12:13 Lorenzo Delgado
2026-09-24 17:21 ` Danilo Krummrich
2026-09-27 18:11 ` Lorenzo Delgado [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260927181154.1757237-1-lnsdev@proton.me \
--to=lnsdev@proton.me \
--cc=a.hindborg@kernel.org \
--cc=abdiel.janulgue@gmail.com \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=driver-core@lists.linux.dev \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nova-gpu@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®