From: Jonathan Cameron <jic23@kernel.org>
To: "jiale yao" <19888972804@163.com>
Cc: "Andy Shevchenko" <andriy.shevchenko@intel.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Danilo Krummrich" <dakr@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: accel: kxcjk-1013: reject duplicate event disable
Date: Sun, 27 Sep 2026 18:14:58 +0100 [thread overview]
Message-ID: <20260927181458.22f022e3@jic23-hlaptop> (raw)
In-Reply-To: <7fec18d8.e8d.1a0dc78eba2.Coremail.19888972804@163.com>
On Sat, 26 Sep 2026 14:48:27 +0800 (CST)
"jiale yao" <19888972804@163.com> wrote:
> At 2026-09-26 08:49:42, "Jonathan Cameron" <jic23@kernel.org> wrote:
> >On Fri, 25 Sep 2026 22:38:07 +0800 (CST)
> >"jiale yao" <19888972804@163.com> wrote:
> >
> >> At 2026-09-25 22:17:19, "Andy Shevchenko" <andriy.shevchenko@intel.com> wrote:
> >> >On Fri, Sep 25, 2026 at 10:09:43PM +0800, Jiale Yao wrote:
> >> >> The IIO core does not filter duplicate writes to the event enable
> >> >> attribute. kxcjk1013_write_event_config() already ignores repeated
> >> >> enable requests, but a repeated disable request still calls
> >> >> kxcjk1013_set_power_state(data, false), dropping a runtime PM reference
> >> >> that was not acquired for this request. This can underflow the runtime
> >> >> PM usage count and trigger a "Runtime PM usage count underflow" warning.
> >> >>
> >> >> Return early when the requested state already matches ev_enable_state.
> >> >
> >> >Sounds like a bug that needs to be fixed and hence Fixes tag to be applied.
> >> Sure, I'll add the Fixes tag in v2, 24h later, for any other comments before sending it.
> >For a simple request for a fixes tag, I'm also fine with you just
> >replying with that tag. b4 will pick it up (though technically in the
> >wrong place so I'll massage things whilst applying)
> Thanks.
> Fixes: b4b491c0832e ("iio: accel: kxcjk-1013: Support thresholds")
Applied to the fixes-togreg branch of iio.git
Thanks,
Jonathan
> >
> >Fix looks good to me.
> >
> >Jonathan
> >
> >> >
> >> >--
> >> >With Best Regards,
> >> >Andy Shevchenko
> >> >
prev parent reply other threads:[~2026-09-27 17:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 14:09 Jiale Yao
2026-09-25 14:17 ` Andy Shevchenko
2026-09-25 14:38 ` jiale yao
2026-09-26 0:49 ` Jonathan Cameron
2026-09-26 6:48 ` jiale yao
2026-09-27 17:14 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260927181458.22f022e3@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=19888972804@163.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=bhelgaas@google.com \
--cc=dakr@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®