From: Mariia Nikitash <nikitash.mariiaw@gmail.com>
To: krzk@kernel.org, s.nawrocki@samsung.com,
peter.griffin@linaro.org, linusw@kernel.org
Cc: alim.akhtar@samsung.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
morbo@google.com, kees@kernel.org, justinstitt@google.com,
aleksandr.loktionov@intel.com,
codemender-patching+linux@google.com,
Mariia Nikitash <nikitash.mariiaw@gmail.com>
Subject: [PATCH] pinctrl: samsung: Use snprintf() to construct pin bank names
Date: Sun, 27 Sep 2026 12:07:58 -0700 [thread overview]
Message-ID: <20260927190758.609156-1-nikitash.mariiaw@gmail.com> (raw)
From: Bill Wendling <morbo@google.com>
samsung_banks_node_get() constructs each pin bank node name by copying
bank->name with strscpy() and appending the suffix with strlcat().
In preparation for removing the deprecated strlcat() API[1], format the
node name in a single snprintf() call, which preserves the existing
truncation check against sizeof(node_name).
Link: https://github.com/KSPP/linux/issues/370 [1]
Cc: codemender-patching+linux@google.com
Assisted-by: LLM
Signed-off-by: Bill Wendling <morbo@google.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Signed-off-by: Mariia Nikitash <nikitash.mariiaw@gmail.com>
---
drivers/pinctrl/samsung/pinctrl-samsung.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
index 5ecc9ed4c44d..0d639eec689c 100644
--- a/drivers/pinctrl/samsung/pinctrl-samsung.c
+++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
@@ -1155,8 +1155,7 @@ static void samsung_banks_node_get(struct device *dev, struct samsung_pinctrl_dr
bank = d->pin_banks;
for (i = 0; i < d->nr_banks; ++i, ++bank) {
- strscpy(node_name, bank->name, sizeof(node_name));
- len = strlcat(node_name, suffix, sizeof(node_name));
+ len = snprintf(node_name, sizeof(node_name), "%s%s", bank->name, suffix);
if (len >= sizeof(node_name)) {
dev_err(dev, "Too long pin bank name '%s', ignoring\n",
bank->name);
--
2.43.0
next reply other threads:[~2026-09-27 19:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 19:07 Mariia Nikitash [this message]
2026-09-28 21:43 ` Justin Stitt
2026-09-28 22:00 ` Bill Wendling
2026-09-28 22:07 ` Justin Stitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260927190758.609156-1-nikitash.mariiaw@gmail.com \
--to=nikitash.mariiaw@gmail.com \
--cc=aleksandr.loktionov@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=codemender-patching+linux@google.com \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=krzk@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=morbo@google.com \
--cc=peter.griffin@linaro.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®