mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Abdelnasser Hussein <abdelnasserhussein11@gmail.com>
Cc: gregkh@linuxfoundation.org, nuno.sa@analog.com,
	Michael.Hennerich@analog.com, dlechner@baylibre.com,
	andy@kernel.org, linux@analog.com, linux-iio@vger.kernel.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	joshua.crofts1@gmail.com, error27@gmail.com
Subject: Re: [PATCH v3] staging: iio: adc: ad7816: Protect sysfs attributes with mutex
Date: Sun, 27 Sep 2026 20:05:25 +0100	[thread overview]
Message-ID: <20260927200525.4b31c449@jic23-hlaptop> (raw)
In-Reply-To: <20260923110745.3836-1-abdelnasserhussein11@gmail.com>

On Wed, 23 Sep 2026 14:07:45 +0300
Abdelnasser Hussein <abdelnasserhussein11@gmail.com> wrote:

> The sysfs store functions modify driver state that is critical during
> SPI transactions. ad7816_store_mode toggles hardware GPIO pins, while
> ad7816_store_channel updates the internal software state
> (chip->channel_id).
> 
> If these are modified concurrently by userspace while an SPI transfer
> is in progress, it could corrupt the hardware transaction or cause the
> driver to communicate with the wrong channel.
> 
> Add the existing chip->lock guard to these functions to serialize
> access and prevent these race conditions.
> 
> Fixes: 7924425db04a ("staging: iio: adc: new driver for AD7816 devices")
> Suggested-by: Joshua Crofts <joshua.crofts1@gmail.com>
> Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
> Signed-off-by: Abdelnasser Hussein <abdelnasserhussein11@gmail.com>
Applied to the testing branch of iio.git.

Thanks,

Jonathan

      reply	other threads:[~2026-09-27 19:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23 11:07 Abdelnasser Hussein
2026-09-27 19:05 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260927200525.4b31c449@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=abdelnasserhussein11@gmail.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=error27@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joshua.crofts1@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=linux@analog.com \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®