From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f24.google.com (mail-wr2-f24.google.com [74.125.225.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6AFF3B7765 for ; Sun, 27 Sep 2026 22:33:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.88 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790548428; cv=none; b=aman7fID7tSlFnFjOj/REnW4d3lTTBYUrgxZ/qmPHAZZEdzgLGS4NEUlslzsm+FejOxYDHkHP1f9X9D325lEAyHCtTPly0J/Xihw48LpZTBFOwJVzCUqB53ruGNvTV513BwclOrGg+QkxlwLliRXwcM3T7wGi3vlzMLg3M6xzAI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790548428; c=relaxed/simple; bh=1sRcSFppOrgktFqdfKHTNDuzVX5pBsaOKugd6hcDcIU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=AXc1mJ97f6I6O+T0COJ5a10BTbZHd/AOXR9GFsbZRB2K7HfzaeRxfE3JRxHxoXJSe6HxzmwhqJavEl0z1WPjBRI24Kvh1Bj2MLIClQHmtFU9lhxVco1VDZ19yPmJF/tbLp3wpBQoQlFd5RUh8lznRQTcD0BDjC7qAvm1x6ULVjc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Kx+xJFff; arc=none smtp.client-ip=74.125.225.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kx+xJFff" Received: by mail-wr2-f24.google.com with SMTP id ffacd0b85a97d-482f63546c3so1930932f8f.1 for ; Sun, 27 Sep 2026 15:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790548425; x=1791153225; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3HVeOlrU5+9T0TXxv7ji/SUxWihY/QvPKpNCrdEuPA0=; b=Kx+xJFffzOkSdRikEURxt7j+/Ww29ZE649WMrWE/UUNYDPsDIvcy4YxzigdZPU2SBF eGIUfv6W0k2qFwxMatLKc3n0tcOj8f/AV6u1Tbd6jqIanCo+dBG7hHuHaHckMKiQkFFG zMs6A0QmmXVjfnAv3ITe8mfk0DcXfi5IKu4AFkdhBxuwLNYNODEMjysTIB/6DmCdXrkq 7d22wLlqKPDrLbV6w/BL5rXrbZfjdGpJ/4tqQ8IEuJoTOFRb8vM92xis5WT5mNROz+xc wQwkRvSV9Xy6FzSFJT2NGxvn2G3fvORENRR7lz0TL2cKhHmPxkQbrsyB8LaydGLorWn5 ZV1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790548425; x=1791153225; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=3HVeOlrU5+9T0TXxv7ji/SUxWihY/QvPKpNCrdEuPA0=; b=FtUj55hCTQPUSejIjP/ffaScaUuBApE137LEBc/EnI4og3lpTVZlYJKw17klO6/l6T e9GONvQogouhwxEURae2i/cOJr9O0/vJSOjeuXFuSnRYsIkDTbzxhP8vuxGw3R7OYzEO qCSi9bWY03ECyrBM2hpzyL2EDsjPu0Qk0BfEq+tQvLnyI2xB61GGm9sJc8fqrkJASq+T 4BG0pRTobV213ntEG+zSGmvKdoFCGnV5sCB+XuFQ20gAsrO8KIHBtJ3gL+MsU0txQGw0 jguMtgNwssmbFeGzcv/srNUrm63lpwsrMbVWB7nYhES0S61fW6lKfBTY7rgzJzDKu4Zk AnVw== X-Forwarded-Encrypted: i=1; AKwUvBx959UK+qhUhrJ/X1S2O/2hCI3mUC15a+84qbZ5/QHSOaZwLRK3IbwZRlRwrl/6Ht2rJkydY6p60Zixxoo=@vger.kernel.org X-Gm-Message-State: AFq9FYJcz6oCcCP/SY4QLBCPk9hASkOu6s6iN2NgteffTcU4S68DrY38 8YrNy/NO5CzY+MA7T1A+1YWiD5KAy30uj0dhDvZUCieKRIPJVwmBegaV X-Gm-Gg: AYBFou3vBqMHu65+xv65gJm6tLWAQteTKGNpDB6Diqo6FWSwQaTs14ond5/iob/c7rh NQdPv6L14a7nwyoGHn9fZ3jScEgz4YGG1fi8YEMfoJOGjLnUPEqkzbSISgzTTR/YhDXgBMnflr+ +tiDWbeCneTIGBufElCC2/fk0PQSD9CbecZPOdl7L5/6aptHh2/YVtgyekeklRUZc3qhB/ibOGz /vEtVcAv6wqGeC52Rt8sheJoCchipvAFfvl7h3Jej3QrbWVCgIkwYfQ0FcO3hGQQXOkWt9BqUB2 y5z3rbDd7A37EZq42DJXoZBMLfu3B7tNdQGy9id3RIWt9Sn5etvatY5iz++niNtgL9t5+cOU4CS sTj+7OzZJS9MKlGuU3beyNtq0+YGvAGl589l6qD079nRcESgADBJHRvaJhgu6OfNbx6hJkF7d7i +AKlW/Pl039bMpC/hMBkQy08WD0PyXuCteWBqMNg7m/b7Kl3hEc/W3RfDVe1qptGbi6Udx X-Received: by 2002:adf:e19c:0:b0:487:11c3:b004 with SMTP id ffacd0b85a97d-488719760c4mr20369347f8f.52.1790548424757; Sun, 27 Sep 2026 15:33:44 -0700 (PDT) Received: from metepc ([46.197.185.71]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4887a30bcdbsm22517694f8f.2.2026.09.27.15.33.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Sep 2026 15:33:44 -0700 (PDT) From: =?UTF-8?q?=C3=96mer=20Mete=20Kaya?= To: ast@kernel.org, daniel@iogearbox.net Cc: john.fastabend@gmail.com, andrii@kernel.org, eddyz87@gmail.com, memxor@gmail.com, martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev, jolsa@kernel.org, emil@etsalapatis.com, ihor.solodrai@linux.dev, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?=C3=96mer=20Mete=20Kaya?= Subject: [PATCH bpf] bpf: Fix uninitialized known_memory read in check_mem_reg() Date: Mon, 28 Sep 2026 01:28:05 +0300 Message-ID: <20260927223327.414912-1-omermetekaya0@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit check_mem_reg() takes an optional bool *known_memory output parameter. When the register is NULL, the function returns early via mark_arg_precision() without setting *known_memory, leaving it uninitialized. The caller in check_func_arg() declares 'bool known_memory' without initialization and reads it after check_mem_reg() returns: bool known_memory; err = check_mem_reg(..., &known_memory); if (err < 0) { if (known_memory) ... } If mark_arg_precision() returns a negative value and the register was NULL, reading known_memory is undefined behavior. In practice only the diagnostic message selection is affected. Fix by setting *known_memory = false before returning in the NULL register path, matching the intent that a NULL register does not imply the memory region is known. Fixes: 66e2727395dd ("bpf: Report Call Type Safety argument errors") Signed-off-by: Ă–mer Mete Kaya --- kernel/bpf/verifier.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index 535967fc5f12..2cc8a2778c5a 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -7652,8 +7652,11 @@ static int check_mem_reg(struct bpf_verifier_env *env, struct bpf_reg_state *reg { int size, err = 0; - if (bpf_register_is_null(reg)) + if (bpf_register_is_null(reg)) { + if (known_memory) + *known_memory = false; return mark_arg_precision(env, argno); + } if (known_memory) *known_memory = true; -- 2.55.0