mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexandru Chimac <alex@chimac.ro>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
	 Peter Griffin <peter.griffin@linaro.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	 Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	 linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
	 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: pinctrl: samsung: Require clocks for Exynos9610 pinctrl nodes
Date: Mon, 28 Sep 2026 10:06:47 +0200	[thread overview]
Message-ID: <20260928-dynamic-durable-rook-1be9bc@quoll> (raw)
In-Reply-To: <1343593353.60484.1790180095661@app.mailbox.org>

On Wed, Sep 23, 2026 at 07:14:55PM +0300, Alexandru Chimac wrote:
> Hello!
> > On 09/23/2026 5:58 PM EEST Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > 
> >  
> > On 22/09/2026 14:15, Alexandru Chimac wrote:
> > > All Exynos9610 pin controllers (except PINCTRL_TOP) have clocks assigned
> > > to them, so force the nodes to have clocks assigned to them.
> > > 
> > > Signed-off-by: Alexandru Chimac <alex@chimac.ro>
> > > ---
> > > Most Samsung Exynos9610 pin controllers (except TOP) have clocks
> > > designated for them, so allow the device tree node to include clock
> > 
> > I don't understand above. It's contradictory to commit msg which says
> > ALL. Here you say most.
> > 
> 
> On Exynos9610, only TOP pinctrl doesn't have a clock (as far as I'm
> aware; haven't found a clock for it), while the rest of the pin controller
> blocks do.

So how is it supposed to work if you require clock also for TOP pinctrl?

Best regards,
Krzysztof


  reply	other threads:[~2026-09-28  8:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22 12:15 Alexandru Chimac
2026-09-22 14:25 ` Alexandru Chimac
2026-09-23 14:58 ` Krzysztof Kozlowski
2026-09-23 16:14   ` Alexandru Chimac
2026-09-28  8:06     ` Krzysztof Kozlowski [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-09-22 12:07 Alexandru Chimac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260928-dynamic-durable-rook-1be9bc@quoll \
    --to=krzk@kernel.org \
    --cc=alex@chimac.ro \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®