From: Krzysztof Kozlowski <krzk@kernel.org>
To: dongsheng liu <2509730023@qq.com>
Cc: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Daniel Mack <daniel@zonque.org>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: leds: Convert leds-lt3593.txt to yaml format
Date: Mon, 28 Sep 2026 08:18:58 +0200 [thread overview]
Message-ID: <20260928-voracious-shiny-swallow-2dbee5@quoll> (raw)
In-Reply-To: <tencent_67B8796B733C275D1EF565D0D2CDB9B48306@qq.com>
On Tue, Sep 22, 2026 at 01:00:12PM +0800, dongsheng liu wrote:
> Convert binding doc leds-lt3593.txt to yaml format, so that nodes using
> the "lltc,lt3593" compatible are no longer reported by dtbs_check as:
>
> failed to match any schema with compatible: ['lltc,lt3593']
>
> Additional change:
> - reference common.yaml for the LED sub-node properties.
> - require the sub-node, matching the driver's check for exactly one child.
>
> The schema was written with the help of an LLM coding assistant, based on
> the previous binding text and drivers/leds/leds-lt3593.c. It is validated
> with make dt_binding_check, and against the "lltc,lt3593" node in
> arch/arm/boot/dts/intel/pxa/pxa300-raumfeld-controller.dts.
Drop paragraph from commit msg.
>
> Assisted-by: LLM dtschema yamllint
And dtschema and yamllint here. These are not LLM tools.
Regardless, I discourage usage of LLM for conversion by beginners - you
learn not much and you repeat what we already did (these files were
converted with LLM by Rob). If this is part of any mentorship or GSoC
program, then it is actually forbidden in these to use LLM for
conversions.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
prev parent reply other threads:[~2026-09-28 6:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 5:00 dongsheng liu
2026-09-28 6:18 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928-voracious-shiny-swallow-2dbee5@quoll \
--to=krzk@kernel.org \
--cc=2509730023@qq.com \
--cc=conor+dt@kernel.org \
--cc=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®