From: Andrew Halaney <andrew@amutable.com>
To: Jakub Kicinski <kuba@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
Oleg Nesterov <oleg@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Willem de Bruijn <willemb@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org,
Alexander Mikhalitsyn <alexander@mihalicyn.com>,
"Christian Brauner (Amutable)" <brauner@kernel.org>,
Andrew Halaney <andrew@amutable.com>,
Alexander Mikhalitsyn <alexander@mihalicyn.com>
Subject: [PATCH v3 00/10] net: support thread-specific pidfds for send and connect
Date: Mon, 28 Sep 2026 11:27:07 +0200 [thread overview]
Message-ID: <20260928-work-unix-passpidfd-v3-0-532018a91b21@amutable.com> (raw)
SO_PASSPIDFD/SCM_PIDFD and SO_PEERPIDFD allow to retrieve a pidfd for
the thread-group leader. The coredump server using the coredump socket
cannot get a handle on the task that took the signal and is writing the
coredump easily. Workloads interested in per-thread authentification
have similar problems.
Add SO_PASSPIDFD_THREAD/SCM_PIDFD_THREAD and SO_PEERPIDFD_THREAD. We
record the sending and the connecting thread in addition to the
thread-group leader.
SO_PASSPIDFD_THREAD functions like SO_PASSPIDFD but instead of an
SCM_PIDFD message for the thread-group leader, SCM_PIDFD_THREAD sends a
pidfd for the specific thread. SO_PASSPIDFD / SO_PASSPIDFD_THREAD are
independent, allowing callers to get both styles of pidfd back in their
cmsg.
SO_PEERPIDFD_THREAD allows to retrieve a pidfd for the specific thread
that called connect(), listen(), or socketpair().
pidfs_coredump() now also stamps the dumping thread's struct pid so a
pidfd for that thread reports the coredump like the pidfd of the
thread-group leader does.
Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
Signed-off-by: Andrew Halaney <andrew@amutable.com>
---
Changes in v3:
- I picked this series up from Christian at his request (thanks!)
- Make SO_PASSPIDFD and SO_PASSPIDFD_THREAD completely independent (and
in doing so add SCM_PIDFD_THREAD) instead of mutually exclusive. This goes
against Kuniyuki's suggestion for a separate flag option, which I
argued the mutually exclusive nature of the prior implementation +
that would be confusing in v2 thread. I think with it being
independent things are more clear, and useful, and it matches the
SO_PEERPIDFD_THREAD counterpart nicely. For that reason I dropped
Reviewed-by tags present on the implementation / selftests patches
related to that.
- Address grammar, reverse xmas tree, sk_is_unix() feedback from
Kuniyuki Iwashima
- Collect tags
- Rebase on v7.3-rc5 for Christian to make shared branch for net to
pull from
- Link to v2: https://lore.kernel.org/r/20260909-work-unix-passpidfd-v2-0-7bd342abb2d1@kernel.org
Changes in v2:
- Fix a few documentation issues.
- Link to v1: https://patch.msgid.link/20260831-work-unix-passpidfd-v1-0-70cbfda0c7ba@kernel.org
---
Christian Brauner (10):
pid: add helpers to operate on a struct pid array
af_unix: record the pid of the sending thread
net: add SO_PASSPIDFD_THREAD to get a thread-specific SCM_PIDFD
selftests/net: SO_PASSPIDFD_THREAD
net: turn sk_peer_pid into an array indexed by pid type
af_unix: record the pid of the connecting thread
net: add SO_PEERPIDFD_THREAD to get a thread-specific pidfd
selftests/net: SO_PEERPIDFD_THREAD
pidfs: record the coredump on the dumping thread's pid too
selftests/coredump: check the dumping thread's pidfd
arch/alpha/include/uapi/asm/socket.h | 4 +
arch/mips/include/uapi/asm/socket.h | 4 +
arch/parisc/include/uapi/asm/socket.h | 4 +
arch/sparc/include/uapi/asm/socket.h | 4 +
fs/coredump.c | 22 +-
fs/pidfs.c | 27 +-
include/linux/coredump.h | 4 +-
include/linux/pid.h | 53 ++
include/linux/pid_types.h | 8 +
include/linux/pidfs.h | 5 +
include/linux/sched/signal.h | 18 +
include/linux/socket.h | 9 +-
include/net/scm.h | 7 +-
include/net/sock.h | 18 +-
include/trace/events/landlock.h | 2 +-
include/uapi/asm-generic/socket.h | 4 +
net/bluetooth/af_bluetooth.c | 6 +-
net/bluetooth/hci_sock.c | 8 +-
net/bluetooth/l2cap_sock.c | 2 +-
net/core/scm.c | 44 +-
net/core/sock.c | 108 ++--
net/unix/af_unix.c | 68 +--
net/unix/af_unix.h | 3 +-
tools/lib/python/kdoc/xforms_lists.py | 1 +
.../selftests/coredump/coredump_socket_test.c | 175 ++++++
tools/testing/selftests/coredump/coredump_test.h | 2 +
.../selftests/coredump/coredump_test_helpers.c | 49 ++
tools/testing/selftests/net/af_unix/Makefile | 2 +
tools/testing/selftests/net/af_unix/scm_pidfd.c | 602 +++++++++++++++++++++
29 files changed, 1149 insertions(+), 114 deletions(-)
---
base-commit: 72d3fcf802c45d00b300f25b848a93c3a2bd7c7e
change-id: 20260825-work-unix-passpidfd-086a1ec09e8a
Best regards,
--
Andrew Halaney <andrew@amutable.com>
next reply other threads:[~2026-09-28 9:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 9:27 Andrew Halaney [this message]
2026-09-28 9:27 ` [PATCH v3 01/10] pid: add helpers to operate on a struct pid array Andrew Halaney
2026-09-28 9:27 ` [PATCH v3 02/10] af_unix: record the pid of the sending thread Andrew Halaney
2026-09-28 9:27 ` [PATCH v3 03/10] net: add SO_PASSPIDFD_THREAD to get a thread-specific SCM_PIDFD Andrew Halaney
2026-09-28 9:27 ` [PATCH v3 04/10] selftests/net: SO_PASSPIDFD_THREAD Andrew Halaney
2026-09-28 9:27 ` [PATCH v3 05/10] net: turn sk_peer_pid into an array indexed by pid type Andrew Halaney
2026-09-28 9:27 ` [PATCH v3 06/10] af_unix: record the pid of the connecting thread Andrew Halaney
2026-09-28 9:27 ` [PATCH v3 07/10] net: add SO_PEERPIDFD_THREAD to get a thread-specific pidfd Andrew Halaney
2026-09-28 9:27 ` [PATCH v3 08/10] selftests/net: SO_PEERPIDFD_THREAD Andrew Halaney
2026-09-28 9:27 ` [PATCH v3 09/10] pidfs: record the coredump on the dumping thread's pid too Andrew Halaney
2026-09-28 9:27 ` [PATCH v3 10/10] selftests/coredump: check the dumping thread's pidfd Andrew Halaney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928-work-unix-passpidfd-v3-0-532018a91b21@amutable.com \
--to=andrew@amutable.com \
--cc=alexander@mihalicyn.com \
--cc=brauner@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jack@suse.cz \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=pabeni@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®