From: Rob Herring <robh@kernel.org>
To: Alexander Koch <mail@alexanderkoch.net>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Khanh Le <khanh.le.xr@renesas.com>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] SoC: dt-bindings: asahi-kasei,ak4619: Add PDN GPIO support
Date: Mon, 28 Sep 2026 08:12:08 -0500 [thread overview]
Message-ID: <20260928131208.GA3834499-robh@kernel.org> (raw)
In-Reply-To: <20260928114019.1441752-3-mail@alexanderkoch.net>
On Mon, Sep 28, 2026 at 01:40:19PM +0200, Alexander Koch wrote:
> Add documentation for optional property that enables operation of the
> 'PDN' pin during initialization:
>
> codec@10 {
> compatible = "asahi-kasei,ak4619";
> reg = <0x10>;
> pdn-gpios = <&gpio1 0 GPIO_ACTIVE_HIGH>; // <--
> #sound-dai-cells = <0>;
> };
>
> Signed-off-by: Alexander Koch <mail@alexanderkoch.net>
> ---
> .../devicetree/bindings/sound/asahi-kasei,ak4619.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/asahi-kasei,ak4619.yaml b/Documentation/devicetree/bindings/sound/asahi-kasei,ak4619.yaml
> index d412531ef9a2..3c7754351e8a 100644
> --- a/Documentation/devicetree/bindings/sound/asahi-kasei,ak4619.yaml
> +++ b/Documentation/devicetree/bindings/sound/asahi-kasei,ak4619.yaml
> @@ -34,6 +34,12 @@ properties:
> $ref: audio-graph-port.yaml#
> unevaluatedProperties: false
>
> + pdn-gpios:
powerdown-gpios is a standard name for this function.
> + maxItems: 1
> + description:
> + GPIO controlling the AK4619 PDN input pin. Used during driver
> + probing to power up the codec.
When a driver does something is not relevant. Would be useful to state
the active (meaning powered down state based on the naming) state.
Rob
next prev parent reply other threads:[~2026-09-28 13:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 11:40 [PATCH 0/2] ASoC: codecs: ak4619: Add PDN pin handling Alexander Koch
2026-09-28 11:40 ` [PATCH 1/2] ASoC: codecs: ak4619: Add optional PDN pin support Alexander Koch
2026-09-28 11:40 ` [PATCH 2/2] SoC: dt-bindings: asahi-kasei,ak4619: Add PDN GPIO support Alexander Koch
2026-09-28 12:58 ` Rob Herring (Arm)
2026-09-28 13:59 ` Alexander Koch
2026-09-28 13:12 ` Rob Herring [this message]
2026-09-28 14:01 ` Alexander Koch
2026-09-28 13:12 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928131208.GA3834499-robh@kernel.org \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khanh.le.xr@renesas.com \
--cc=krzk+dt@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mail@alexanderkoch.net \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®