From: Hongyan Xu <getshell@seu.edu.cn>
To: gregkh@linuxfoundation.org, vz@mleia.com
Cc: piotr.wojtaszczyk@timesys.com, johan@kernel.org,
make24@iscas.ac.cn, kees@kernel.org, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, jianhao.xu@seu.edu.cn,
Hongyan Xu <getshell@seu.edu.cn>
Subject: [PATCH] usb: gadget: lpc32xx_udc: cancel pullup work on remove
Date: Mon, 28 Sep 2026 21:41:58 +0800 [thread overview]
Message-ID: <20260928134158.117-1-getshell@seu.edu.cn> (raw)
Several device interrupts can queue pullup_job, whose callback accesses
the UDC and its I2C transceiver. The IRQs are device-managed, so they
remain registered throughout the driver remove callback, and no path
drains work queued before the resources are released.
Disable and synchronize all publishing IRQs, then cancel pullup_job
before putting the I2C device and releasing the UDC resources.
Fixes: 24a28e428351 ("USB: gadget driver for LPC32xx")
Signed-off-by: Hongyan Xu <getshell@seu.edu.cn>
---
drivers/usb/gadget/udc/lpc32xx_udc.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c
index 044c31869cfb..0a784c9252c5 100644
--- a/drivers/usb/gadget/udc/lpc32xx_udc.c
+++ b/drivers/usb/gadget/udc/lpc32xx_udc.c
@@ -3184,9 +3184,15 @@ static void lpc32xx_udc_remove(struct platform_device *pdev)
return;
}
+ disable_irq(udc->udp_irq[IRQ_USB_LP]);
+ disable_irq(udc->udp_irq[IRQ_USB_HP]);
+ disable_irq(udc->udp_irq[IRQ_USB_DEVDMA]);
+ disable_irq(udc->udp_irq[IRQ_USB_ATX]);
+
udc_clk_set(udc, 1);
udc_disable(udc);
pullup(udc, 0);
+ cancel_work_sync(&udc->pullup_job);
device_init_wakeup(&pdev->dev, 0);
remove_debug_file(udc);
--
2.50.1.windows.1
reply other threads:[~2026-09-28 13:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928134158.117-1-getshell@seu.edu.cn \
--to=getshell@seu.edu.cn \
--cc=gregkh@linuxfoundation.org \
--cc=jianhao.xu@seu.edu.cn \
--cc=johan@kernel.org \
--cc=kees@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=piotr.wojtaszczyk@timesys.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®