From: Rob Herring <robh@kernel.org>
To: Fuad Tabba <fuad.tabba@linux.dev>
Cc: Saravana Kannan <saravanak@kernel.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Frank Li <Frank.Li@nxp.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Fuad Tabba <tabba@google.com>
Subject: Re: [PATCH v2 0/2] of/irq: msi-parent handling in of_msi_xlate()
Date: Mon, 28 Sep 2026 08:55:42 -0500 [thread overview]
Message-ID: <20260928135542.GA4062773-robh@kernel.org> (raw)
In-Reply-To: <20260907112944.313618-1-fuad.tabba@linux.dev>
On Mon, Sep 07, 2026 at 12:29:42PM +0100, Fuad Tabba wrote:
> Hi folks,
>
> Changes since v1 [1]:
> - Added patch 2: end the walk at the first node that declares an
> msi-parent, with the reference handling moved into of_msi_xlate().
> (Lorenzo)
> - Patch 1 is unchanged.
>
> Patch 1 is the v1 fix: of_check_msi_parent() hands back a node reference
> even when the caller passed one in as a filter, which of_msi_xlate()
> documents as receiving none. Patch 2 is what Lorenzo asked for [2]: a
> node declaring an msi-parent names the MSI controller for what sits
> below it, so the walk ends there rather than carrying on to an
> ancestor's msi-map.
>
> Patch 2 removes the line patch 1 adds, along with the rest of the
> reference handling. They stay separate because patch 1 is a small fix
> for a leak that has been there since v6.18, and patch 2 changes
> behaviour: folding them would hide the fix inside the change.
>
> Based on Linux 7.3-rc1 (cee9395acd804).
>
> Cheers,
> /fuad
>
> [1] https://lore.kernel.org/all/20260904073424.3855365-1-fuad.tabba@linux.dev/
> [2] https://lore.kernel.org/all/apqnaNmeuUjfC8Ng@red-moon/
>
> Fuad Tabba (2):
> of/irq: Fix device node refcount leak in of_check_msi_parent()
> of/irq: Stop the MSI walk at the first msi-parent
Series applied, thanks.
Rob
prev parent reply other threads:[~2026-09-28 13:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 11:29 Fuad Tabba
2026-09-07 11:29 ` [PATCH v2 1/2] of/irq: Fix device node refcount leak in of_check_msi_parent() Fuad Tabba
2026-09-07 11:29 ` [PATCH v2 2/2] of/irq: Stop the MSI walk at the first msi-parent Fuad Tabba
2026-09-28 6:47 ` [PATCH v2 0/2] of/irq: msi-parent handling in of_msi_xlate() Fuad Tabba
2026-09-28 13:55 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928135542.GA4062773-robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fuad.tabba@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=saravanak@kernel.org \
--cc=tabba@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®