Re: [PATCH v10 0/7] Incorporate DRAM address in EDAC messages

[Yazen Ghannam <yazen.ghannam@amd.com>]

On Sun, Sep 27, 2026 at 10:30:40PM -0700, Borislav Petkov wrote:
> On Tue, Sep 22, 2026 at 03:23:10PM -0500, Yazen Ghannam wrote:
> > This revision addresses a couple comments from Boris. Also, the couple
> > of patches originally by Avadhut have gone through a few revisions. So I
> > updated the attributions.
> 
> One Sashiko question here:
> 
> https://sashiko.dev/#/patchset/20260922202318.4079080-1-yazen.ghannam%40amd.com
> 

Looks like a false positive.

The question is on a struct that was added in patch 3. And that patch
was reviewed as good.

Also, pahole shows that the nested struct is packed. Sashiko said is
isn't.

Nested struct => struct atl_umc_addr

 $ pahole build/drivers/ras/amd/atl/prm.o
struct atl_umc_addr {
        u64                        addr;                 /*     0     8 */
        u8                         socket_id;            /*     8     1 */
        u64                        ipid;                 /*     9     8 */

        /* size: 17, cachelines: 1, members: 3 */
        /* last cacheline: 17 bytes */
} __attribute__((__packed__));
struct param_buf {
        struct atl_umc_addr        addr;                 /*     0    17 */
        void *                     out_buf;              /*    17     8 */

        /* size: 25, cachelines: 1, members: 2 */
        /* last cacheline: 25 bytes */
} __attribute__((__packed__));

Thanks,
Yazen