From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7EF0547046; Mon, 28 Sep 2026 18:03:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790618621; cv=none; b=EU1CBxLoqc5IPLf0YgpDarjQMzL45Z8O+ckgkOoioUYaVKjeyi2XTCs3ioWXMThlnGIy/BEiY5f98keuxBm5k3ZzV9MgEPyFnX5DyHZCgD843DefGAAMIx7nwrS/qCMdbGzkPMyJUpJR1ICtaCdlQkK5JdaHclKjHPIAB9TLCHo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790618621; c=relaxed/simple; bh=Em6qkKYb+gUcvRKeEmVxlAsqhkqcC0JJ8qJlMwTzxyE=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=QjImnSEaBITZQ+rxBWQoFhwzHx0Fqfn0Ypv52KJi5cZLa/oTFxdgyGdAKgXJ255r2ArLVSy/zW0t3j38ZdVEgIUnng+Lm787Dpz8DKStLyh9szYO8BwKxqSuwblnVIB8BZXxwlmk2F/GSK/2YqeaEYUPkUE874exVXnBeZC16gA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Rn6zrALh; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Rn6zrALh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F9CE1F000FF; Mon, 28 Sep 2026 18:03:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790618619; bh=Em6qkKYb+gUcvRKeEmVxlAsqhkqcC0JJ8qJlMwTzxyE=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Rn6zrALhktzX3F+Qlx/sCblhKYPW7bRfEE6BJ6xnmgqwaOWPYFxo3ixhEbhKg+r6O e+H0GV5kzwq5abYap6EhWyHAJC1ciZuD2u0jDx9k44qyxiXPne3k2fpLGlOgSPsAvj OwM397eqZzSNjsfzqndd+jf/KLESRjltxZU/R1iVbMDCCWbu/p93B+z3mO8ywoG57y xzafkjNjqPMxcRwwOFpja7N2v1AIZyxgkL4Swwhv1YzEVOo8jIp6dyaAvh4X2Re4Uy hepOuRZUAcK5Ws1/P2ZRnr9lfpFOMkIu3O07XVV7l6pIWnXLAT/YBnrAqtYoAK0XpE XEhnD18itDbdQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 6/6] x86/vmware: Report guest crashes after kmsg dumpers Reply-To: sashiko-reviews@lists.linux.dev To: "Zack Rusin" , "Andrew Morton" , "Dave Young" , "Baoquan He" , "Mike Rapoport" , "Pratyush Yadav" , "Pasha Tatashin" , "Petr Mladek" Cc: "Alexey Makhalov" , "John Ogness" , kexec@lists.infradead.org, "Stephen Brennan" , "Shuah Khan" , bcm-kernel-feedback-list@broadcom.com, "H. Peter Anvin" , "Bo Gan" , "Maaz Mombasawala" , "Joel Granados" , "Ian Forbes" , "Randy Dunlap" , "Michael Kelley" , "Steven Rostedt" , "Eugenio Perez" , "Borislav Petkov" , linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, "Michael S. Tsirkin" , "Kees Cook" , "Jonathan Corbet" , "Guilherme G. Piccoli" , "Sergey Senozhatsky" , "Dave Hansen" , "Ajay Kaher" , linux-doc@vger.kernel.org, "Ingo Molnar" , "Thomas Gleixner" , x86@kernel.org, "Brennan Lamoreaux" In-Reply-To: <996d3ceefd98ed9a7c40508e6f62039ba5a15325.1790014793.git.zack.rusin@broadcom.com> References: <996d3ceefd98ed9a7c40508e6f62039ba5a15325.1790014793.git.zack.rusin@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 28 Sep 2026 18:03:36 +0000 Message-Id: <20260928180337.6F9CE1F000FF@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > VMware accepts a structured guest-crash event, but a host configured with > backdoor.coredumpOnCrash may terminate the VM before the hypercall > returns. Keep this event separate from the pre-kdump log sender. >=20 > Register a panic-only kmsg dumper with late_initcall_sync(), after built-= in > dumpers registered by then. Skip the event while a crash kernel is loaded > so the host cannot terminate the guest before kdump saves its vmcore. >=20 > Issue the event at most once. With CONFIG_PRINTK=3Dn, use a late INT_MIN > panic notifier. An unexpected dumper registration failure with printk > enabled leaves reporting disabled rather than overtaking working dumpers. >=20 > Link: https://lore.kernel.org/r/20260309235250.2611115-4-alexey.makhalov@= broadcom.com > Co-developed-by: Brennan Lamoreaux > Signed-off-by: Brennan Lamoreaux > Co-developed-by: Alexey Makhalov > Signed-off-by: Alexey Makhalov > Signed-off-by: Zack Rusin Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/cover.1790014793.gi= t.zack.rusin@broadcom.com?part=3D6