From: Rob Herring <robh@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Arka Mondal" <arka@arkamondal.net>,
"Nuno Sá" <nuno.sa@analog.com>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
arkamondalofficial@gmail.com
Subject: Re: [PATCH 4/5] dt-bindings: iio: dac: adi,ad5758: Fix the 4 mA to 20 mA current range
Date: Mon, 28 Sep 2026 14:34:49 -0500 [thread overview]
Message-ID: <20260928193449.GA408126-robh@kernel.org> (raw)
In-Reply-To: <20260920193949.45606414@jic23-hlaptop>
On Sun, Sep 20, 2026 at 07:39:49PM +0100, Jonathan Cameron wrote:
> On Fri, 18 Sep 2026 21:20:31 +0900
> Arka Mondal <arka@arkamondal.net> wrote:
>
> > adi,range-microamp gives the 4 mA to 20 mA range as <4 24000>. The
> > values are in microamps, so this reads as 4 uA to 24 mA. The original
> > text binding described <4 24000> as the "4 mA to 20 mA current range",
> > and the data sheet (Rev. B, Table 32) confirms range code 1010 is
> > 4 mA to 20 mA.
> >
> > Add <4000 20000> and mark <4 24000> deprecated, so existing device
> > trees still validate.
> >
> > Fixes: 777baca07ef1 ("dt-bindings: iio: dac: Add docs for AD5758 DAC")
> > Signed-off-by: Arka Mondal <arka@arkamondal.net>
>
> DT reviewers. Better to paper over a dt that is specifying the wrong
> range as this does (deprecated) or just make it obvious by failing
> the binding checks? I'm thinking failing is better as gets any such
> dt fixed up faster. I also suspect no one actually it this because the
> disconnect they should have seen when reading the datasheet and considering
> what they wanted should have meant they saw this bug!
No in tree .dts (for which I don't want more warnings), so I would just
drop it.
Rob
next prev parent reply other threads:[~2026-09-28 19:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 12:20 [PATCH 0/5] iio: dac: ad5758: fix DMA alignment, raw range, offset and 4-20 mA Arka Mondal
2026-09-18 12:20 ` [PATCH 1/5] iio: dac: ad5758: Fix alignment for DMA safety Arka Mondal
2026-09-18 12:20 ` [PATCH 2/5] iio: dac: ad5758: Reject out-of-range raw values Arka Mondal
2026-09-18 12:20 ` [PATCH 3/5] iio: dac: ad5758: Fix the offset calculation Arka Mondal
2026-09-18 12:20 ` [PATCH 4/5] dt-bindings: iio: dac: adi,ad5758: Fix the 4 mA to 20 mA current range Arka Mondal
2026-09-20 18:39 ` Jonathan Cameron
2026-09-28 19:34 ` Rob Herring [this message]
2026-09-18 12:20 ` [PATCH 5/5] iio: dac: ad5758: " Arka Mondal
2026-09-18 15:22 ` [PATCH 0/5] iio: dac: ad5758: fix DMA alignment, raw range, offset and 4-20 mA Nuno Sá
2026-09-20 18:41 ` Jonathan Cameron
2026-09-27 20:52 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928193449.GA408126-robh@kernel.org \
--to=robh@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=arka@arkamondal.net \
--cc=arkamondalofficial@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®