From: Muhammad Bilal <meatuni001@gmail.com>
To: "Jorge Lopez" <jorge.lopez2@hp.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Muhammad Bilal <meatuni001@gmail.com>
Subject: [PATCH v2 0/3] platform/x86: hp-bioscfg: string buffer and password fixes
Date: Tue, 29 Sep 2026 01:03:15 +0500 [thread overview]
Message-ID: <20260928200318.63383-1-meatuni001@gmail.com> (raw)
This series addresses string buffer issues and password validation
in the hp-bioscfg driver.
Patch 1 fixes bounds checking, prescan OOB read, and character count
accounting in hp_get_string_from_buffer().
Patch 2 replaces the truncating manual conversion loop with a two-stage
conversion: utf16s_to_utf8s() into a scratch buffer followed by
string_escape_mem().
Patch 3 fixes validate_password_input() returning positive
INVALID_BIOS_AUTH (0x0E), which caused userspace writes of
out-of-range passwords to appear successful.
All patches tested on HP EliteBook 840 G2 (Fedora 44, Linux 7.2.7).
Changes in v2:
- Split hp_get_string_from_buffer() fixes into two logical patches
(bounds/OOB reads and UTF-8 conversion rewrite), as reviewed by
Ilpo Järvinen.
- Dropped lib/string_helpers patch: pass "\\\r\n\t" to string_escape_mem()
with existing flags (ESCAPE_SPACE | ESCAPE_SPECIAL) to escape the four
characters without altering quotes, as reviewed by Andy Shevchenko.
- Added password validation errno fix as patch 3/3.
Muhammad Bilal (3):
platform/x86: hp-bioscfg: fix OOB reads in hp_get_string_from_buffer()
platform/x86: hp-bioscfg: fix non-ASCII truncation in
hp_get_string_from_buffer()
platform/x86: hp-bioscfg: return -ERANGE from
validate_password_input()
drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 77 ++++++-------------
.../x86/hp/hp-bioscfg/passwdobj-attributes.c | 6 +-
2 files changed, 27 insertions(+), 56 deletions(-)
--
2.55.0
next reply other threads:[~2026-09-28 20:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 20:03 Muhammad Bilal [this message]
2026-09-28 20:03 ` [PATCH v2 1/3] platform/x86: hp-bioscfg: fix OOB reads in hp_get_string_from_buffer() Muhammad Bilal
2026-09-28 21:26 ` Andy Shevchenko
2026-09-28 20:03 ` [PATCH v2 2/3] platform/x86: hp-bioscfg: fix non-ASCII truncation " Muhammad Bilal
2026-09-28 21:32 ` Andy Shevchenko
2026-09-28 20:03 ` [PATCH v2 3/3] platform/x86: hp-bioscfg: return -ERANGE from validate_password_input() Muhammad Bilal
2026-09-28 21:34 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928200318.63383-1-meatuni001@gmail.com \
--to=meatuni001@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jorge.lopez2@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®