Re: [PATCH v4 1/2] dt-bindings: iio: pressure: add Sensirion SDP31

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2969 bytes --]

On Tue, Sep 29, 2026 at 02:54:21AM +0500, Muhammad Abu Bakar wrote:
> Add device tree bindings for the Sensirion SDP3x family of differential
> pressure sensors (SDP31, SDP32 and SDP33), I2C devices that also report
> temperature.
> 
> Signed-off-by: Muhammad Abu Bakar <m.abubakar365@yahoo.com>
> ---
>  .../iio/pressure/sensirion,sdp31.yaml         | 48 +++++++++++++++++++
>  MAINTAINERS                                   |  5 ++
>  2 files changed, 53 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/pressure/sensirion,sdp31.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/pressure/sensirion,sdp31.yaml b/Documentation/devicetree/bindings/iio/pressure/sensirion,sdp31.yaml
> new file mode 100644
> index 000000000..b9d3c6441
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/pressure/sensirion,sdp31.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/pressure/sensirion,sdp31.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sensirion SDP31, SDP32 and SDP33 differential pressure sensors
> +
> +maintainers:
> +  - Muhammad Abu Bakar <m.abubakar365@yahoo.com>
> +
> +description: |
> +  Differential pressure sensors from Sensirion with an I2C interface.
> +  The SDP31, SDP32 and SDP33 differ only in their measurement range.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - sensirion,sdp31
> +      - sensirion,sdp32
> +      - sensirion,sdp33

Given a skim of the driver, it does not seem like the difference in
measurement range affects the programming model? In that case, you
should probably pick sdp31 as a fallback compatible for the other
devices.

Otherwise, looks fine to me.
pw-bot: changes-requested

> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  vdd-supply: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      pressure@21 {
> +        compatible = "sensirion,sdp31";
> +        reg = <0x21>;
> +        vdd-supply = <&vdd_3v3>;
> +      };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 214aeee76..e285147be 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -24855,6 +24855,11 @@ S:	Maintained
>  F:	Documentation/devicetree/bindings/iio/chemical/sensirion,scd4x.yaml
>  F:	drivers/iio/chemical/scd4x.c
>  
> +SENSIRION SDP31 DIFFERENTIAL PRESSURE SENSOR DRIVER
> +M:	Muhammad Abu Bakar <m.abubakar365@yahoo.com>
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/iio/pressure/sensirion,sdp31.yaml
> +
>  SENSIRION SDP500 DIFFERENTIAL PRESSURE SENSOR DRIVER
>  M:	Petar Stoykov <petar.stoykov@prodrive-technologies.com>
>  S:	Maintained
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]