Re: [PATCH v3 01/12] dt-bindings: arm: fsl: Document Variscite i.MX6UL boards

[Krzysztof Kozlowski <krzk@kernel.org>]

On Sun, Sep 27, 2026 at 02:46:16PM +0200, Stefano Radaelli wrote:
> From: Stefano Radaelli <stefano.r@variscite.com>
> 
> Document the existing VAR-SOM-6UL Concerto compatibles and the new

Which are existing? Don't mix up different issues.

> VAR-SOM-6UL and DART-6UL board variants based on i.MX6UL, i.MX6ULL
> and i.MX6ULZ.
> 
> Add specific compatibles for the storage, wireless, audio and
> carrier combinations while retaining the legacy Concerto strings.
> 
> Signed-off-by: Stefano Radaelli <stefano.r@variscite.com>
> ---
>  .../devicetree/bindings/arm/fsl.yaml          | 148 ++++++++++++++++--
>  1 file changed, 138 insertions(+), 10 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 36e28e0e4ad9..726d563d1482 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -688,11 +688,51 @@ properties:
>            - const: phytec,imx6ul-pcl063   # PHYTEC phyCORE-i.MX 6UL
>            - const: fsl,imx6ul
>  
> -      - description: i.MX6UL Variscite VAR-SOM-6UL Boards
> -        items:
> -          - const: variscite,mx6ulconcerto
> -          - const: variscite,var-som-imx6ul
> -          - const: fsl,imx6ul
> +      - description: i.MX6UL Variscite VAR-SOM-6UL and DART-6UL Boards
> +        oneOf:

Please do not introduce own style.

> +          - items:
> +              - enum:
> +                  - variscite,mx6ulconcerto
> +                  - variscite,var-som-imx6ul-emmc-sd-card-wm8731-concerto-board

"board" is redundant

Also, look at other examples here, like Toradex. The actual variant
should be the last.

Best regards,
Krzysztof