From: Jianfeng Liu <liujianfeng1994@gmail.com>
To: "Christian König" <christian.koenig@amd.com>
Cc: Jianfeng Liu <liujianfeng1994@gmail.com>,
Rob Clark <rob.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Bryan O'Donoghue <bod.linux@nxsw.ie>,
Robin Murphy <robin.murphy@arm.com>,
dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] drm/msm: map page-less imported sg_tables from their DMA addresses
Date: Tue, 29 Sep 2026 11:27:35 +0800 [thread overview]
Message-ID: <20260929032744.37269-1-liujianfeng1994@gmail.com> (raw)
In-Reply-To: <bd4e5ece-1358-4e0b-bb04-ba9de62d26f6@amd.com>
Hi Christian,
On Mon, Sep 28, 2026 at 12:09 PM Christian König wrote:
> That is not in any way better than illegally using struct page. The
> point is we need to get away from using phys_addr at all here.
Agreed, I won't push this further. With your "import a shmemfd, not
a DMA-buf" remark in mind, the direction that makes sense to me is
the allocation model one: userspace allocates the decoder capture
buffers from msm GEM and the V4L2 device imports them, so msm stays
the exporter and never has to interpret memory it did not allocate.
Rob's series (drop the page array, mmap via the exporter) is the
prep work for that and is already in good shape. It is also how
panfrost/panthor already work - they program their own pagetables
from the sg_table's DMA addresses and never look at pages for
mapping.
I'll withdraw this series and come back once Rob has had time to
look at the msm side. Patch 1 is withdrawn too - Robin NAKed the
iommu_get_dma_domain() export, which is moot now anyway.
Thanks for the review, and for the earlier pointer to what msm is
doing wrong here.
Regards,
Jianfeng
prev parent reply other threads:[~2026-09-29 3:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 5:38 [PATCH v1 0/2] drm/msm: followup - map page-less imported sg_tables Jianfeng Liu
2026-09-28 5:38 ` [PATCH v1 1/2] iommu: export iommu_get_dma_domain() Jianfeng Liu
2026-09-28 11:26 ` Robin Murphy
2026-09-29 3:28 ` Jianfeng Liu
2026-09-28 5:38 ` [PATCH v1 2/2] drm/msm: map page-less imported sg_tables from their DMA addresses Jianfeng Liu
2026-09-28 10:09 ` Christian König
2026-09-29 3:27 ` Jianfeng Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929032744.37269-1-liujianfeng1994@gmail.com \
--to=liujianfeng1994@gmail.com \
--cc=bod.linux@nxsw.ie \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=rob.clark@oss.qualcomm.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®