From: Chen Pei <cp0613@linux.alibaba.com>
To: acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
namhyung@kernel.org
Cc: mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
james.clark@linaro.org, leo.yan@linux.dev,
john.g.garry@oracle.com, will@kernel.org, mike.leach@arm.com,
pjw@kernel.org, palmer@dabbelt.com, guoren@kernel.org,
linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/2] perf riscv: Implement rdtsc()
Date: Tue, 29 Sep 2026 11:41:31 +0800 [thread overview]
Message-ID: <20260929034133.2153-1-cp0613@linux.alibaba.com> (raw)
tools/perf falls back to the __weak rdtsc() stub in tools/perf/util/tsc.c
on every architecture that does not override it, riscv included. The
stub returns a constant 0, so anything that reaches for the counter gets
a value that means nothing and cannot tell it apart from a counter that
happens to be at 0.
The time CSR is a natural TSC equivalent on riscv: readable from user
mode, constant frequency, and the same counter that riscv's
arch_perf_update_userpage() feeds the user page conversion fields from,
ever since commit 83c5e13b8cbb ("riscv: Prepare for user-space perf
event mmap support"). This series registers that on the tools side.
The two patches are split so that the first stands on its own:
1. Implement rdtsc() over the time CSR for riscv64.
2. Have the build system say which architectures have a usable counter,
instead of a list of compiler macros inside the test.
What this is worth beyond the subtest result:
1. The subtest is the only reader of those conversion fields riscv
can run, so it guards arithmetic that has shipped unexercised;
registering the counter at the same time leaves a future riscv
auxtrace driver the reading and the conversion already in place.
2. The flag lets a caller ask whether the architecture has a counter
before it uses the value, without keeping its own copy of a list
that has to be edited every time an architecture grows an
implementation.
Changes since v1:
- Define rdtsc() for RV64 only. RV32 now keeps the weak stub.
- Declare the capability through the build system rather than through a
weak arch__rdtsc_supported() hook, following the PERF_HAVE_JITDUMP
pattern, as Leo Yan suggested.
Tests:
======
- riscv64 QEMU virt guest with sscofpmf, comparing the build before the
series with the build after it: before, the "TSC support" subtest skips
and the conversion subtest fails while comparing against the stub's
constant 0; after, both report Ok.
- riscv64 and riscv32 cross builds: the compile command of
tests/perf-time-to-tsc.o carries -DHAVE_RDTSC on rv64 and not on
rv32, so RV32 stays on the weak stub.
- x86_64 host and arm64 cross builds: -DHAVE_RDTSC is in effect for
both, and on the host the "TSC support" subtest still reports Ok.
Chen Pei (2):
perf riscv: Implement rdtsc()
perf tsc: Declare TSC support from the build system
tools/perf/Makefile.config | 4 ++++
tools/perf/arch/arm64/Makefile | 1 +
tools/perf/arch/riscv/Makefile | 1 +
tools/perf/arch/riscv/util/Build | 1 +
tools/perf/arch/riscv/util/tsc.c | 27 +++++++++++++++++++++++++++
tools/perf/arch/x86/Makefile | 1 +
tools/perf/tests/perf-time-to-tsc.c | 19 ++++---------------
7 files changed, 39 insertions(+), 15 deletions(-)
create mode 100644 tools/perf/arch/riscv/util/tsc.c
--
2.50.1
next reply other threads:[~2026-09-29 3:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 3:41 Chen Pei [this message]
2026-09-29 3:41 ` [PATCH v2 1/2] " Chen Pei
2026-09-29 3:41 ` [PATCH v2 2/2] perf tsc: Declare TSC support from the build system Chen Pei
2026-09-29 9:49 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929034133.2153-1-cp0613@linux.alibaba.com \
--to=cp0613@linux.alibaba.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=guoren@kernel.org \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=palmer@dabbelt.com \
--cc=peterz@infradead.org \
--cc=pjw@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®