From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-91.mta1.migadu.com [95.215.58.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A21B23B14B6 for ; Tue, 29 Sep 2026 08:20:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790670007; cv=none; b=Qf+wJE4YIVMX+G1SJRlO5MSx9bWQmh2O55QTYBYYh2s3m7tlo3hpUvqfU+QoFssr+dR2KSG3RqW4N++n7sAekErc5mBjZaF32ZbiDdSmj0LMPZ2nSNCodK50cbDMeFoQqTN4QyISuBEBBfWko9krp0b23ehGrk9Xr1sqtrFfTGY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790670007; c=relaxed/simple; bh=mEWPvX1FdDCMegEZd4lktZpkSzG9+EQuZUeCnBEnrM8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Z5XU5I91zPmo1xtyh6IHTv03Hc0VkSUOaWYIZzTfuQINvsnDcXowvDRmx4OP1JlaCTH5ExHcLnbe1kroVV92QOGISZt0IbB5IXDiSaxBOyGh3LlaVQTAwe+/JnpCCwtFv81OYHyVn0Q8OcW7Kyy+3/SRlm+Hbho/GDJHGmV0nY0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=fUywBQfm; arc=none smtp.client-ip=95.215.58.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="fUywBQfm" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=mEWPvX1FdDCMegEZd4lktZpkSzG9+EQuZUeCnBEnrM8=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1790670003; v=1; x=1791274803; b=fUywBQfmVrIpnyOcm5zCU9r/hPSXUL6ztvivVbohT+mRDCS39o56y3hUSieZJcbyW2Hbgf9+ kSRfKgp19gzcrttVynEBgB2kxzHW7pjP3fC6OX1JxIh4/cBrKb0GfPlY5nwg9uoHowoCPTZC0tA v+7bgBLuW+fIbyaGjk0dRlRo= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 343c75fff31967c5; Tue, 29 Sep 2026 08:20:02 +0000 X-Mizu-Trace-ID: 343c75fff31967c5 X-Migadu-Flow: FLOW_OUT From: Hao Ge To: Suren Baghdasaryan , =Kent Overstreet , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Andrew Morton , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Vlastimil Babka , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Uladzislau Rezki Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, Hao Ge , Sashiko , stable@vger.kernel.org Subject: [PATCH v11 3/7] alloc_tag: clean up the populate failure path Date: Tue, 29 Sep 2026 16:20:10 +0800 Message-Id: <20260929082014.160587-4-hao.ge@linux.dev> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260929082014.160587-1-hao.ge@linux.dev> References: <20260929082014.160587-1-hao.ge@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The reservation is already stored in the maple tree when vm_module_tags_populate() fails. A failed load never unloads the module, so nothing releases the entry. Release it and roll module_tags.size back. Without the rollback a concurrent load that already passed needs_section_mem() can reuse the freed gap, skip vm_module_tags_populate() and write to unmapped memory. Fixes: 4835f747d3ed ("alloc_tag: support for page allocation tag compression") Fixes: 0f9b685626da ("alloc_tag: populate memory for module tags as needed") Reported-by: Sashiko Cc: stable@vger.kernel.org Signed-off-by: Hao Ge --- mm/alloc_tag.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/alloc_tag.c b/mm/alloc_tag.c index 2070e682fe10..3e6306ee0764 100644 --- a/mm/alloc_tag.c +++ b/mm/alloc_tag.c @@ -947,6 +947,7 @@ static void *reserve_module_tags(struct module *mod, unsigned long size, return ret; if (module_tags.size < offset + size) { + unsigned long prev_size = module_tags.size; int grow_res; module_tags.size = offset + size; @@ -961,6 +962,8 @@ static void *reserve_module_tags(struct module *mod, unsigned long size, shutdown_mem_profiling(true); pr_err("Failed to allocate memory for allocation tags in the module %s. Memory allocation profiling is disabled!\n", mod->name); + release_module_tags(mod, false); + module_tags.size = prev_size; return ERR_PTR(grow_res); } } -- 2.25.1