From: Ruslan Koreev <koreev.r@gmail.com>
To: rillian.grant@gmail.com
Cc: lee@kernel.org, pavel@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Ruslan Koreev <koreev.r@gmail.com>
Subject: Re: [PATCH v2 0/4] leds: flash: LM3643 dual LED flash driver
Date: Tue, 29 Sep 2026 12:29:18 +0300 [thread overview]
Message-ID: <20260929092917.1782754-2-koreev.r@gmail.com> (raw)
In-Reply-To: <20260928094302.86966-1-rillian.grant@gmail.com>
Hi Rillian,
On Mon, Sep 28, 2026 at 10:42:33AM +0100, Rillian Grant wrote:
> This series adds a flash LED driver for the Texas Instruments
> LM3643. I wrote it to support the Windows Hello NIR illuminator on my
> ThinkPad X9-15 Gen 1, which has a single LED connected to both current
> sources. The driver has also been tested by Ruslan Koreev on a ThinkPad
> X1 Carbon Gen 14.
Thanks for folding my patches in. I retested v2 on the X1 Carbon Gen 14
(7.2.5): the DMI description is picked up, max_brightness is 71 and
writes above it are clamped, max_flash_brightness is 600000, torch off
puts the chip back in standby (ENABLE reads 0x00), and a flash strobe
times out and reports flash-timeout-exceeded as expected.
About the Sashiko comment on 2/4: led_classdev_register_ext() reads
max-brightness from the fwnode before it creates the class device, so
the window only exists when the firmware node has a max-brightness
larger than what led-max-microamp allows. The DMI nodes don't set it.
If you want to close it anyway, clamping the code in
lm3643_torch_set_brightness() against the limit derived from
led-max-microamp would make it independent of max_brightness.
For 3/4, dev_dbg() is fine with me.
Ruslan
prev parent reply other threads:[~2026-09-29 9:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 9:42 Rillian Grant
2026-09-28 9:42 ` [PATCH v2 1/4] dt-bindings: leds: Document TI " Rillian Grant
2026-09-28 9:42 ` [PATCH v2 2/4] leds: flash: Add support for the " Rillian Grant
2026-09-28 9:42 ` [PATCH v2 3/4] leds: flash: lm3643: Describe the LED of ACPI boards without LED nodes Rillian Grant
2026-09-28 9:42 ` [PATCH v2 4/4] leds: flash: lm3643: Describe the LED on the Lenovo ThinkPad X9-15 Gen 1 Rillian Grant
2026-09-29 9:29 ` Ruslan Koreev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929092917.1782754-2-koreev.r@gmail.com \
--to=koreev.r@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=rillian.grant@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®