From: SJ Park <sj@kernel.org>
To: Gutierrez Asier <gutierrez.asier@huawei-partners.com>
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 1/8] mm/damon/core: introduce damos_quota_goal->complement
Date: Tue, 29 Sep 2026 03:34:03 -0700 [thread overview]
Message-ID: <20260929103404.48154-1-sj@kernel.org> (raw)
In-Reply-To: <9e07dbdd-3b02-4175-b343-c8cb6f9885e0@huawei-partners.com>
On Tue, 29 Sep 2026 13:24:20 +0300 Gutierrez Asier <gutierrez.asier@huawei-partners.com> wrote:
> Hi SJ,
>
> On 9/29/2026 11:01 AM, SJ Park wrote:
[...]
> > + /* updte current_value to complemented value */
> There is a typo there. It should be "update".
Good catch, thank you. Andrew, could you please fix it up when you take this?
Let me know if you prefer reposting.
> Also, what is the
> purpose of this comment? It doesn't explain anything, which may
> not be obvious.> +
The purpose is explaining the code below does what the comment says.
Thanks,
SJ
[...]
next prev parent reply other threads:[~2026-09-29 10:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 8:01 [PATCH 0/8] mm/damon: introduce damos quota goal target metric complement flag SJ Park
2026-09-29 8:01 ` [PATCH 1/8] mm/damon/core: introduce damos_quota_goal->complement SJ Park
2026-09-29 10:24 ` Gutierrez Asier
2026-09-29 10:34 ` SJ Park [this message]
2026-09-29 8:01 ` [PATCH 2/8] mm/damon/core: add complement argument to damos_new_quota_goal() SJ Park
2026-09-29 10:25 ` Gutierrez Asier
2026-09-29 8:01 ` [PATCH 3/8] mm/damon/sysfs-schemes: support quota goal complement flag SJ Park
2026-09-29 8:01 ` [PATCH 4/8] mm/damon/tests/core-kunit: test quota_goal->complement commit SJ Park
2026-09-29 8:01 ` [PATCH 5/8] selftests/damon/sysfs.sh: test quota goal complement flag file SJ Park
2026-09-29 8:01 ` [PATCH 6/8] Docs/mm/damon/design: document damos quota goal complement flag SJ Park
2026-09-29 8:01 ` [PATCH 7/8] Docs/admin-guide/mm/damon/usage: update for quota goal complement file SJ Park
2026-09-29 8:01 ` [PATCH 8/8] Docs/ABI/damon: update for quota goal metric complement sysfs file SJ Park
2026-09-29 8:17 ` [PATCH 0/8] mm/damon: introduce damos quota goal target metric complement flag SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929103404.48154-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=gutierrez.asier@huawei-partners.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®