mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>,
	Johnson Tsai <wenjie.tsai@realtek.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Bitterblue Smith <rtl8821cerfe2@gmail.com>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] wifi: rtw89: fix LED dependencies
Date: Tue, 29 Sep 2026 12:41:52 +0200	[thread overview]
Message-ID: <20260929104159.3236854-1-arnd@kernel.org> (raw)

From: Arnd Bergmann <arnd@arndb.de>

The rtw89 driver fails to build when multicolor LED support is in
a loadable module but the rtw89 driver is built-in:

aarch64-linux-ld: drivers/net/wireless/realtek/rtw89/led_mc.o: in function `rtw89_led_mc_brightness_set':
led_mc.c:(.text+0x50): undefined reference to `led_mc_calc_color_components'
aarch64-linux-ld: drivers/net/wireless/realtek/rtw89/led_mc.o: in function `rtw89_led_mc_init':
led_mc.c:(.text+0x434): undefined reference to `led_classdev_multicolor_register_ext'

The problem is a misunderstanding of how Kconfig dependencies
work, as the 'imply' keyword is not sufficient to enable a
a user-visible dependency, and the boolean 'RTW89_LEDS_MC'
symbol cannot determine whether linking against the MC code is
valid.

Address this by using the correct construct to determing whether
linking agains the MAC80211_LEDS and LEDS_CLASS_MULTICOLOR
code is possible, respectively.

Fixes: d910631ff352 ("wifi: rtw89: add LED support to reflect the wireless association status")
Fixes: 721d90c8509a ("wifi: rtw89: add multicolor LED support for RTL8852CU valve board")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/wireless/realtek/rtw89/Kconfig | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw89/Kconfig b/drivers/net/wireless/realtek/rtw89/Kconfig
index 7c678dd1f6b3..4000ae344544 100644
--- a/drivers/net/wireless/realtek/rtw89/Kconfig
+++ b/drivers/net/wireless/realtek/rtw89/Kconfig
@@ -208,15 +208,13 @@ config RTW89_DEBUGFS
 config RTW89_LEDS
 	bool
 	depends on RTW89_CORE
-	depends on LEDS_CLASS=y || LEDS_CLASS=MAC80211
-	imply MAC80211_LEDS
+	depends on MAC80211_LEDS=y || MAC80211_LEDS=RTW89_CORE
 	default y
 
 config RTW89_LEDS_MC
 	bool
 	depends on RTW89_LEDS
-	depends on LEDS_CLASS_MULTICOLOR
-	imply LEDS_TRIGGER_TIMER
+	depends on LEDS_CLASS_MULTICOLOR=y || LEDS_CLASS_MULTICOLOR=RTW89_CORE
 	default y
 
 endif
-- 
2.53.0


                 reply	other threads:[~2026-09-29 10:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260929104159.3236854-1-arnd@kernel.org \
    --to=arnd@kernel.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    --cc=rtl8821cerfe2@gmail.com \
    --cc=wenjie.tsai@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®