From: Jisheng Zhang <jszhang@kernel.org>
To: Mark Brown <broonie@kernel.org>, Joseph Steel <recv.jo@gmail.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 3/5] spi: dw: remove duplicated "!rx_len && !tx_len" handling from dw_spi_irq
Date: Tue, 29 Sep 2026 20:18:15 +0800 [thread overview]
Message-ID: <20260929121817.20896-4-jszhang@kernel.org> (raw)
In-Reply-To: <20260929121817.20896-1-jszhang@kernel.org>
dw_spi_irq() need not handle enhanced-transfer's "!rx_len && !tx_len"
case as that state is already handled by dw_spi_enh_handler()
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
drivers/spi/spi-dw-core.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/spi/spi-dw-core.c b/drivers/spi/spi-dw-core.c
index f4c4e9dae25e..91de357f97f3 100644
--- a/drivers/spi/spi-dw-core.c
+++ b/drivers/spi/spi-dw-core.c
@@ -284,12 +284,6 @@ static irqreturn_t dw_spi_irq(int irq, void *dev_id)
dw_spi_mask_intr(dws, 0xff);
return IRQ_HANDLED;
}
- if (dws->transfer_handler == dw_spi_enh_handler &&
- !dws->rx_len && !dws->tx_len) {
- dw_spi_mask_intr(dws, 0xff);
- spi_finalize_current_transfer(ctlr);
- return IRQ_HANDLED;
- }
return dws->transfer_handler(dws);
}
--
2.53.0
next prev parent reply other threads:[~2026-09-29 12:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 12:18 [PATCH v4 0/5] spi: dw: use threaded interrupt Jisheng Zhang
2026-09-29 12:18 ` [PATCH v4 1/5] spi: dw: use DW_SPI_ISR directly Jisheng Zhang
2026-09-29 12:18 ` [PATCH v4 2/5] spi: dw: remove useless dws->transfer_handler check Jisheng Zhang
2026-09-29 12:18 ` Jisheng Zhang [this message]
2026-09-29 12:18 ` [PATCH v4 4/5] spi: dw: restore previous irq handling behavior when !ctlr->cur_msg Jisheng Zhang
2026-09-29 12:18 ` [PATCH v4 5/5] spi: dw: use threaded interrupt and optimize the threaded ISR Jisheng Zhang
2026-09-29 14:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929121817.20896-4-jszhang@kernel.org \
--to=jszhang@kernel.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=recv.jo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®