From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f12.google.com (mail-wr2-f12.google.com [74.125.225.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7CF95335B6 for ; Tue, 29 Sep 2026 16:57:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790701044; cv=none; b=T3hoKKa0/k5bX90d0ZIkaOKrcugKVp4SqHboxg46EuGVglICNcEOdK04QOgU3Hv7++3ND12t72n+H2Kxz45TVd3LRafdFWWNZMu+d/zYwDVCTEsPJuSfMWWL8KpdTaq6X8Y2YJ3hdJGrvLUnuyyYbAmJ6HfY2oLb8LEVLMRgJAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790701044; c=relaxed/simple; bh=1X+I4s/Qc88Q3mt8n2I89ghISwk4YJ11K1+GkdEX0lo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=O3mAYsx6uPCMVZcr2+HHiGTYWXSs4bnKBccbZ12CEFYi6Z7ppwyIUN97vJySSQkLVPB5cA/LKIEIqhPfErRl1illtA65IMRfWcW8r2NEGGwGOvwAl3uLMARKZfV3dXLTxDQ84vE0y679wy0maQgikLj4rKXNA6MQfum2598YR/c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oEs1KQ5X; arc=none smtp.client-ip=74.125.225.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oEs1KQ5X" Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-482f63546c5so3969351f8f.2 for ; Tue, 29 Sep 2026 09:57:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790701041; x=1791305841; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wJFH2IjoTkwJen4b0adRNofV230zNzAQykwUxRXPcMY=; b=oEs1KQ5XYeGt6Uno3GqAIF3EWs3zFQZroy8GNmPiespyfCko8nwviONyA5Zdg6itHu CbUbaMZlL3abWttJK8soCb4BDg8wzAN/jXbP8PlsdpDSM25Da7cGNpR7e0mL5ITd+DSr vde1BJV6v6in7krdH8rCbwPGRXnaaQ+nNURkfAysF6qKnMENUOLgaOGxixqRToyWqENF +FdEZ+5Z+Tfiv8Nbweb8xg9MumJYMsEd09hvb8gMFq40yDJmaOOS06VlKF49h2bDx4/Z +zE1ySBuw5c1Rzy7nCztAwSkiuj3Kd+CxFgcAeQ0+zvHMdHPc+mnnF/hi+s48kn3h709 TfqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790701041; x=1791305841; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=wJFH2IjoTkwJen4b0adRNofV230zNzAQykwUxRXPcMY=; b=sGNVX0HQ39bhUJhvVfaq3abrVHJAfBwyzafrk81mkKuLtfEEAcSx/siA6aeB5knXYw K1BsihQXZR05KrTy0oDbwi3KiteuVi6NLNB08+myXiTFTP0B6WhjGZ33DU6c64/JLQju KB0IIt0YGRpl9yixqGFIyi2gm+4sTgBfuh91T1lgWwXSHDHv+7FkiqidzMRPRP3rA+Dj RHTOgm1i7nOV/GsiRgkvPRN7iDE29y9QGTJb8T1EoiOQ4aA0+82EDjC20H+Kmli9bNIf eSLuNgOM4wFtEijg5ySVBvVtZDdf3GqZj0uOP7+e4vyuanGIGoiS7fNs9GEZUTHG69AK czJQ== X-Forwarded-Encrypted: i=1; AKwUvBzXka4Iv8znphkNH7CIOtVX3p3ztpWrufb+vhJKdCinvkWJN+gBjSOVXLf3V5EkmOX7L9I4r+KuVepiZeM=@vger.kernel.org X-Gm-Message-State: AFq9FYL6/Begn829BnOJ4MVfJKJURN1cq0tgP7uGNgNuuIBqm3HdVG9j HoVCK3MhNelJvHWUpFykHoq9UmXRP+lUlBDF7Gr2iv9D6LvtM9KaM4X4 X-Gm-Gg: AYBFou0OSyt9If1xEeKBpi6z9yxvJsqyqgKa8ipUy0hxFeRVirZj3b9YLe1rRLErdVM dsaF//NKd8Eef4MKY3IGWE8ehY4lXQkUxHR2UaiuM8FfPDBB7gmxb2b31HQ/9cBx4+jGvrU13yE w4zB9SyT9pzF6cURm1rJGqLTB6FKlnzA7SdIY3UDMxMqPFqNOxs3H9cfcZZ5mq421f7Vzc++xGb bXqf20QICwb8kUUZ8oVIqIFT/EloW4BHcXYA6b8SbRfpjXw6RSNnJD4yZpEc/E5Vavpn0TJlYrv vgSMXGSmpfTqhqqQ0+AejzA7Uv0WKV09Ih0GJn3OyMi0bHVdlpb6ByqlXGOuRy7igPANi1HB4ui MzaP/lI2yFu5xDeppBvUM2eSXq67/PAvMQdG64UA+zMfIF8FEAwL3tIU/6JnhNz7r2Bzjw5QaCw zFdYIvkTr8P1D+gBc+V2FVTA5A5Z5NjIdNMbYxkYYDAdUyx0WkE1ducXcSPVBOV6lDRdb6LnnZn 37pKy/x0ywnl8t/dD5UTkx+uxlXL6kXATBKNosS X-Received: by 2002:a05:6000:98f:b0:488:8823:f9ec with SMTP id ffacd0b85a97d-488882404c7mr18420237f8f.34.1790701040835; Tue, 29 Sep 2026 09:57:20 -0700 (PDT) Received: from ws1-mint.emulab.it ([2a01:b600:90d3:0:7e:12ca:700a:85e0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48afe61c876sm57777f8f.3.2026.09.29.09.57.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2026 09:57:20 -0700 (PDT) From: Simone Chifari To: Adamyno Cc: Andi Shyti , Andy Lutomirski , Stefan Schaeckeler , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/1] i2c: imc-skylake: add Intel Skylake-X iMC SMBus adapter Date: Tue, 29 Sep 2026 18:57:19 +0200 Message-ID: <20260929165719.403487-1-simone.chifari@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260928080640.550879-1-padamyno@gmail.com> References: <20260928080640.550879-1-padamyno@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Mon, Sep 28, 2026 at 10:06:26AM +0200, Adamyno wrote: > I tested this driver end-to-end on real hardware. Code as published at > https://github.com/systempal/i2c-imc-skylake (matching the v3/v4 series; > the v4 rework did not change anything relevant to this test). Hi Adamyno, thanks for testing, and for the detailed report. It is the first report from a board other than mine, and it will go into the next cover letter as such: a second vendor and BIOS, SMBCNTL reading 0 where mine reads 0xac000000, ee1004 on all eight modules, and the RGB write traffic through both adapters. For the record, since the tag lands on the v3 thread: the GitHub main you tested has the same transfer path as v4 and only adds shutdown handling that is not part of the series. I will carry Tested-by: Adamyno in the next revision, unless v4 is applied as is. If you have time for more, two read-only measurements would help with the question this series still leaves open: whether the firmware uses the engine behind the driver's back. The numbers in the v4 cover letter come from my board only, and yours has a different BIOS. Both scripts are in tools/ of the same repository (see tools/README.md) and only read config space: # OpenRGB closed, driver unloaded: anything that moves is firmware sudo modprobe -r i2c_imc_skylake sudo ./tools/watch-engine.sh --seconds 3600 sudo ./tools/dump-pcu-config.sh --settle 10 The raw output is what matters, and it would be credited to you in the cover letter. A suspend/resume cycle during the watch-engine hour would make it even more useful. > One observation that may be worth adding to the driver documentation: > the RGB controller ICs on G.Skill Trident Z RGB DIMMs answer at SMBus > addresses 0x70-0x73 on this bus (4 per channel), not the 0x39-0x3D > range that older OpenRGB-era documentation assumed. Useful to know, but I think it fits OpenRGB's documentation better than the driver's: the driver does not know about the devices behind it, and ENE controllers can be re-addressed at runtime (OpenRGB's detector does exactly that), so the address depends on the modules and on the firmware or software that set them up. Thanks, Simone