From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-4323.protonmail.ch (mail-4323.protonmail.ch [185.70.43.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0F5C354AE3 for ; Tue, 29 Sep 2026 19:30:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.43.23 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790710209; cv=none; b=rPaG8Sz6RAcxDJF0s5a6NO6VskYc5MD6fyBhxawi9tFcDPh1ZiqHLnfbjNqjSef16ITEnj2m5VLCGvMtLMG+dEUPEQHIR4vmnhRl2J9AnLob0WvpVqnr+RTMZWiDK5XREQkJTcNOE+7iTi5c0J/uaXMTOs10AX7ET+mEi0EkeE4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790710209; c=relaxed/simple; bh=UZHazEcVXVJS7l6C2Rm3n3+jkb4pWcZQZp3cmWOcWrU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=id/gpNG4lb9Ew5Q9lSaBy4yeo8piHST1biC6VO9+UM4jn3DHujNIbyov9oiFymY2fkbggyyZESwL097cn2soM4NZeQEcwKDpiG69Sg1AZnb8vY/Iicn2EZMuOjy/fzPLru3BjPdlWITPWqlB3AnvDWKdba8Ol7JTaSyvxt+Aa6w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ironrobin.net; spf=pass smtp.mailfrom=ironrobin.net; dkim=pass (2048-bit key) header.d=ironrobin.net header.i=@ironrobin.net header.b=qvnHIg0P; arc=none smtp.client-ip=185.70.43.23 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ironrobin.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ironrobin.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ironrobin.net header.i=@ironrobin.net header.b="qvnHIg0P" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ironrobin.net; s=protonmail3; t=1790710195; x=1790969395; bh=UZHazEcVXVJS7l6C2Rm3n3+jkb4pWcZQZp3cmWOcWrU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=qvnHIg0Pcxwg5hw3Km0vLT5wxj/oEz19mM2HZWCZCu7IFk07XDbabmPxGEne+TnyG q+60SNCBkBoK8FmOVD7cf0xmIQODfgdzbD6S8fuJnxlJy6Y44rJwEUZ8TgS7aTr82o /kWNOAkT97lJXYBDgevLsKNMBIUT7VmWabpZ9YnJqnrlBYHi7EQLisJe+yg1tH2kpR 33qE5lxJN4fs8Fp7/fNS2SdNepXINWRaFRjyEKhPWdKCoVWK5gyvLfkszAMV4OmhED LhHaAgGi4A/nh2YXuChSgWU+T7QTngeKJ/570CSK4ndNpDjfvTh7j9ID+uFmuiLcK7 w0nKZcd92vv0Q== Date: Tue, 29 Sep 2026 19:29:50 +0000 To: Hans de Goede , =?utf-8?Q?Ilpo_J=C3=A4rvinen?= From: Alex Robinson Cc: Bryan O'Donoghue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Steev Klimaszewski , platform-driver-x86@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 3/3] arm64: dts: qcom: sc8280xp-x13s: Add embedded controller Message-ID: <20260929192908.16507-4-alex@ironrobin.net> In-Reply-To: <20260929192908.16507-1-alex@ironrobin.net> References: <20260929192908.16507-1-alex@ironrobin.net> Feedback-ID: 54785507:user:proton X-Pm-Message-ID: 28a40f096bffcfa3e46b21560eee73fc5561a9e9 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Enable the ThinkPad X13s embedded controller so its driver can provide keyboard backlight support when booting with Device Tree. Use a pull-up on the EC interrupt line to match the firmware-inherited configuration measured before Linux configured the pin. Assisted-by: LLM Signed-off-by: Alex Robinson --- Review note: GPIO103 was measured at pinctrl probe before Linux claimed/configured the pin. TLMM CTL offset 0x67000 read 0x00000003; the pull field value of 3 decodes to pull-up on SC8280XP. diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/a= rch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts index 218573a97785b04528854b03a99c837558a33c1e..1e29bab37de6d192ec49dc407e2= 4e1a3bc9496bd 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts @@ -806,6 +806,25 @@ &i2c4 { =09}; }; =20 +&i2c8 { +=09clock-frequency =3D <400000>; + +=09pinctrl-0 =3D <&i2c8_default>; +=09pinctrl-names =3D "default"; + +=09status =3D "okay"; + +=09embedded-controller@28 { +=09=09compatible =3D "lenovo,thinkpad-x13s-ec"; +=09=09reg =3D <0x28>; +=09=09interrupts-extended =3D <&tlmm 103 IRQ_TYPE_EDGE_FALLING>; +=09=09power-state-gpios =3D <&tlmm 176 GPIO_ACTIVE_HIGH>; +=09=09pinctrl-0 =3D <&ec_int_n>, <&ec_power_state>; +=09=09pinctrl-names =3D "default"; +=09=09wakeup-source; +=09}; +}; + &i2c11 { =09clock-frequency =3D <400000>; =20 @@ -1571,6 +1590,20 @@ cam_rgb_default: cam-rgb-default-state { =09=09}; =09}; =20 +=09ec_int_n: ec-int-n-state { +=09=09pins =3D "gpio103"; +=09=09function =3D "gpio"; +=09=09input-enable; +=09=09bias-pull-up; +=09}; + +=09ec_power_state: ec-power-state { +=09=09pins =3D "gpio176"; +=09=09function =3D "gpio"; +=09=09drive-strength =3D <2>; +=09=09bias-disable; +=09}; + =09edp_reg_en: edp-reg-en-state { =09=09pins =3D "gpio25"; =09=09function =3D "gpio"; @@ -1591,6 +1624,13 @@ i2c4_default: i2c4-default-state { =09=09bias-disable; =09}; =20 +=09i2c8_default: i2c8-default-state { +=09=09pins =3D "gpio43", "gpio44"; +=09=09function =3D "qup8"; +=09=09drive-strength =3D <2>; +=09=09bias-pull-up; +=09}; + =09i2c11_default: i2c11-default-state { =09=09pins =3D "gpio18", "gpio19"; =09=09function =3D "qup11";