From: Beleswar Padhi <b-padhi@ti.com>
To: <nm@ti.com>, <kristo@kernel.org>, <ssantosh@kernel.org>,
<afd@ti.com>, <vigneshr@ti.com>, <u-kumar1@ti.com>
Cc: <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <b-padhi@ti.com>
Subject: [PATCH 06/22] firmware: ti_sci: Handle xfer cleanup inside ti_sci_do_xfer()
Date: Wed, 30 Sep 2026 01:47:30 +0530 [thread overview]
Message-ID: <20260929201746.4078803-7-b-padhi@ti.com> (raw)
In-Reply-To: <20260929201746.4078803-1-b-padhi@ti.com>
From: Andrew Davis <afd@ti.com>
Pass the response struct to ti_sci_do_xfer() and have it fill it
when a response is received. This makes the xfer struct no longer needed
after this point and so it can be cleaned up after the transfer. This
prevents accidentally not freeing the xfer by the caller and after a
follow up patch makes allocation and free of xfers handled entirely
inside the ti_sci_do_xfer() function.
Signed-off-by: Andrew Davis <afd@ti.com>
Co-developed-by: Beleswar Padhi <b-padhi@ti.com>
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
---
drivers/firmware/ti_sci.c | 471 +++++++++++++++-----------------------
1 file changed, 179 insertions(+), 292 deletions(-)
diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
index 9081288bd133c..c1f783bc67353 100644
--- a/drivers/firmware/ti_sci.c
+++ b/drivers/firmware/ti_sci.c
@@ -43,6 +43,7 @@ static DEFINE_MUTEX(ti_sci_list_mutex);
/**
* struct ti_sci_xfer - Structure representing a message flow
* @tx_message: Transmit message
+ * @rx_buf: Pointer to store received message
* @rx_len: Receive message length
* @xfer_buf: Preallocated buffer to store receive message
* Since we work with request-ACK protocol, we can
@@ -52,6 +53,7 @@ static DEFINE_MUTEX(ti_sci_list_mutex);
*/
struct ti_sci_xfer {
struct ti_msgmgr_message tx_message;
+ void *rx_buf;
u8 rx_len;
u8 *xfer_buf;
struct completion done;
@@ -298,6 +300,7 @@ static void ti_sci_rx_callback(struct mbox_client *cl, void *m)
* @msg_type: Message type
* @msg_flags: Flag to set for the message
* @tx_message_size: transmit message size
+ * @rx_message: receive message storage location
* @rx_message_size: receive message size
*
* Helper function which is used by various command functions that are
@@ -312,7 +315,7 @@ static void ti_sci_rx_callback(struct mbox_client *cl, void *m)
static struct ti_sci_xfer *ti_sci_get_one_xfer(struct ti_sci_info *info,
u16 msg_type, u32 msg_flags,
size_t tx_message_size,
- size_t rx_message_size)
+ void *rx_message, size_t rx_message_size)
{
struct ti_sci_xfers_info *minfo = &info->minfo;
struct device *dev = info->dev;
@@ -368,6 +371,7 @@ static struct ti_sci_xfer *ti_sci_get_one_xfer(struct ti_sci_info *info,
xfer->tx_message.len = tx_message_size;
xfer->tx_message.chan_rx = info->chan_rx;
xfer->tx_message.timeout_rx_ms = info->desc->max_rx_timeout_ms;
+ xfer->rx_buf = rx_message;
xfer->rx_len = (u8)rx_message_size;
reinit_completion(&xfer->done);
@@ -447,7 +451,7 @@ static inline int ti_sci_do_xfer(struct ti_sci_info *info,
ret = mbox_send_message(info->chan_tx, &xfer->tx_message);
if (ret < 0) {
dev_err(dev, "Mbox send fail %d (caller: %pS)\n", ret, (void *)_RET_IP_);
- return ret;
+ goto fail;
}
ret = 0;
@@ -489,9 +493,14 @@ static inline int ti_sci_do_xfer(struct ti_sci_info *info,
dev_warn(dev, "Message response not acknowledged (caller: %pS)\n",
(void *)_RET_IP_);
ret = -ENODEV;
+ } else {
+ memcpy(xfer->rx_buf, xfer->xfer_buf, xfer->rx_len);
}
}
+fail:
+ ti_sci_put_one_xfer(&info->minfo, xfer);
+
return ret;
}
@@ -507,32 +516,28 @@ static int ti_sci_cmd_get_revision(struct ti_sci_info *info)
{
struct ti_sci_handle *handle = &info->handle;
struct ti_sci_version_info *ver = &handle->version;
- struct ti_sci_msg_resp_version *resp;
+ struct ti_sci_msg_resp_version resp;
struct ti_sci_xfer *xfer;
int ret;
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_VERSION,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
sizeof(struct ti_sci_msg_hdr),
- sizeof(*resp));
+ &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
- resp = (struct ti_sci_msg_resp_version *)xfer->xfer_buf;
+ return ret;
- ver->abi_major = resp->abi_major;
- ver->abi_minor = resp->abi_minor;
- ver->firmware_revision = resp->firmware_revision;
- strscpy(ver->firmware_description, resp->firmware_description,
+ ver->abi_major = resp.abi_major;
+ ver->abi_minor = resp.abi_minor;
+ ver->firmware_revision = resp.firmware_revision;
+ strscpy(ver->firmware_description, resp.firmware_description,
sizeof(ver->firmware_description));
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
- return ret;
+ return 0;
}
/**
@@ -549,7 +554,7 @@ static int ti_sci_set_device_state(const struct ti_sci_handle *handle,
{
struct ti_sci_info *info;
struct ti_sci_msg_req_set_device_state *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_xfer *xfer;
int ret = 0;
@@ -562,7 +567,7 @@ static int ti_sci_set_device_state(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_SET_DEVICE_STATE,
flags | TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -572,12 +577,9 @@ static int ti_sci_set_device_state(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ return ret;
- return ret;
+ return 0;
}
/**
@@ -597,7 +599,7 @@ static int ti_sci_get_device_state(const struct ti_sci_handle *handle,
{
struct ti_sci_info *info;
struct ti_sci_msg_req_get_device_state *req;
- struct ti_sci_msg_resp_get_device_state *resp;
+ struct ti_sci_msg_resp_get_device_state resp;
struct ti_sci_xfer *xfer;
int ret = 0;
@@ -613,7 +615,7 @@ static int ti_sci_get_device_state(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_GET_DEVICE_STATE,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -622,22 +624,18 @@ static int ti_sci_get_device_state(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
- resp = (struct ti_sci_msg_resp_get_device_state *)xfer->xfer_buf;
+ return ret;
if (clcnt)
- *clcnt = resp->context_loss_count;
+ *clcnt = resp.context_loss_count;
if (resets)
- *resets = resp->resets;
+ *resets = resp.resets;
if (p_state)
- *p_state = resp->programmed_state;
+ *p_state = resp.programmed_state;
if (c_state)
- *c_state = resp->current_state;
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ *c_state = resp.current_state;
- return ret;
+ return 0;
}
/**
@@ -892,7 +890,7 @@ static int ti_sci_cmd_set_device_resets(const struct ti_sci_handle *handle,
{
struct ti_sci_info *info;
struct ti_sci_msg_req_set_device_resets *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_xfer *xfer;
int ret = 0;
@@ -905,7 +903,7 @@ static int ti_sci_cmd_set_device_resets(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_SET_DEVICE_RESETS,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -915,12 +913,9 @@ static int ti_sci_cmd_set_device_resets(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ return ret;
- return ret;
+ return 0;
}
/**
@@ -957,7 +952,7 @@ static int ti_sci_set_clock_state(const struct ti_sci_handle *handle,
{
struct ti_sci_info *info;
struct ti_sci_msg_req_set_clock_state *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_xfer *xfer;
int ret = 0;
@@ -970,7 +965,7 @@ static int ti_sci_set_clock_state(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_SET_CLOCK_STATE,
flags | TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -986,12 +981,9 @@ static int ti_sci_set_clock_state(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ return ret;
- return ret;
+ return 0;
}
/**
@@ -1012,7 +1004,7 @@ static int ti_sci_cmd_get_clock_state(const struct ti_sci_handle *handle,
{
struct ti_sci_info *info;
struct ti_sci_msg_req_get_clock_state *req;
- struct ti_sci_msg_resp_get_clock_state *resp;
+ struct ti_sci_msg_resp_get_clock_state resp;
struct ti_sci_xfer *xfer;
int ret = 0;
@@ -1028,7 +1020,7 @@ static int ti_sci_cmd_get_clock_state(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_GET_CLOCK_STATE,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -1043,19 +1035,14 @@ static int ti_sci_cmd_get_clock_state(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
- resp = (struct ti_sci_msg_resp_get_clock_state *)xfer->xfer_buf;
+ return ret;
if (programmed_state)
- *programmed_state = resp->programmed_state;
+ *programmed_state = resp.programmed_state;
if (current_state)
- *current_state = resp->current_state;
+ *current_state = resp.current_state;
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
-
- return ret;
+ return 0;
}
/**
@@ -1235,7 +1222,7 @@ static int ti_sci_cmd_clk_set_parent(const struct ti_sci_handle *handle,
{
struct ti_sci_info *info;
struct ti_sci_msg_req_set_clock_parent *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_xfer *xfer;
int ret = 0;
@@ -1248,7 +1235,7 @@ static int ti_sci_cmd_clk_set_parent(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_SET_CLOCK_PARENT,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -1269,12 +1256,9 @@ static int ti_sci_cmd_clk_set_parent(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ return ret;
- return ret;
+ return 0;
}
/**
@@ -1293,7 +1277,7 @@ static int ti_sci_cmd_clk_get_parent(const struct ti_sci_handle *handle,
{
struct ti_sci_info *info;
struct ti_sci_msg_req_get_clock_parent *req;
- struct ti_sci_msg_resp_get_clock_parent *resp;
+ struct ti_sci_msg_resp_get_clock_parent resp;
struct ti_sci_xfer *xfer;
int ret = 0;
@@ -1306,7 +1290,7 @@ static int ti_sci_cmd_clk_get_parent(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_GET_CLOCK_PARENT,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -1321,19 +1305,14 @@ static int ti_sci_cmd_clk_get_parent(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
- resp = (struct ti_sci_msg_resp_get_clock_parent *)xfer->xfer_buf;
+ return ret;
- if (resp->parent_id < 255)
- *parent_id = resp->parent_id;
+ if (resp.parent_id < 255)
+ *parent_id = resp.parent_id;
else
- *parent_id = resp->parent_id_32;
+ *parent_id = resp.parent_id_32;
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
-
- return ret;
+ return 0;
}
/**
@@ -1353,7 +1332,7 @@ static int ti_sci_cmd_clk_get_num_parents(const struct ti_sci_handle *handle,
{
struct ti_sci_info *info;
struct ti_sci_msg_req_get_clock_num_parents *req;
- struct ti_sci_msg_resp_get_clock_num_parents *resp;
+ struct ti_sci_msg_resp_get_clock_num_parents resp;
struct ti_sci_xfer *xfer;
int ret = 0;
@@ -1366,7 +1345,7 @@ static int ti_sci_cmd_clk_get_num_parents(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_GET_NUM_CLOCK_PARENTS,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -1381,19 +1360,14 @@ static int ti_sci_cmd_clk_get_num_parents(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
- resp = (struct ti_sci_msg_resp_get_clock_num_parents *)xfer->xfer_buf;
+ return ret;
- if (resp->num_parents < 255)
- *num_parents = resp->num_parents;
+ if (resp.num_parents < 255)
+ *num_parents = resp.num_parents;
else
- *num_parents = resp->num_parents_32;
+ *num_parents = resp.num_parents_32;
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
-
- return ret;
+ return 0;
}
/**
@@ -1422,7 +1396,7 @@ static int ti_sci_cmd_clk_get_match_freq(const struct ti_sci_handle *handle,
{
struct ti_sci_info *info;
struct ti_sci_msg_req_query_clock_freq *req;
- struct ti_sci_msg_resp_query_clock_freq *resp;
+ struct ti_sci_msg_resp_query_clock_freq resp;
struct ti_sci_xfer *xfer;
int ret = 0;
@@ -1435,7 +1409,7 @@ static int ti_sci_cmd_clk_get_match_freq(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_QUERY_CLOCK_FREQ,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -1453,16 +1427,11 @@ static int ti_sci_cmd_clk_get_match_freq(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
- resp = (struct ti_sci_msg_resp_query_clock_freq *)xfer->xfer_buf;
-
- *match_freq = resp->freq_hz;
+ return ret;
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ *match_freq = resp.freq_hz;
- return ret;
+ return 0;
}
/**
@@ -1489,7 +1458,7 @@ static int ti_sci_cmd_clk_set_freq(const struct ti_sci_handle *handle,
{
struct ti_sci_info *info;
struct ti_sci_msg_req_set_clock_freq *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_xfer *xfer;
int ret = 0;
@@ -1502,7 +1471,7 @@ static int ti_sci_cmd_clk_set_freq(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_SET_CLOCK_FREQ,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -1520,12 +1489,9 @@ static int ti_sci_cmd_clk_set_freq(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ return ret;
- return ret;
+ return 0;
}
/**
@@ -1544,7 +1510,7 @@ static int ti_sci_cmd_clk_get_freq(const struct ti_sci_handle *handle,
{
struct ti_sci_info *info;
struct ti_sci_msg_req_get_clock_freq *req;
- struct ti_sci_msg_resp_get_clock_freq *resp;
+ struct ti_sci_msg_resp_get_clock_freq resp;
struct ti_sci_xfer *xfer;
int ret = 0;
@@ -1557,7 +1523,7 @@ static int ti_sci_cmd_clk_get_freq(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_GET_CLOCK_FREQ,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -1572,16 +1538,11 @@ static int ti_sci_cmd_clk_get_freq(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
- resp = (struct ti_sci_msg_resp_get_clock_freq *)xfer->xfer_buf;
-
- *freq = resp->freq_hz;
+ return ret;
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ *freq = resp.freq_hz;
- return ret;
+ return 0;
}
/**
@@ -1602,7 +1563,7 @@ static int ti_sci_cmd_prepare_sleep(const struct ti_sci_handle *handle, u8 mode,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED;
struct ti_sci_info *info;
struct ti_sci_msg_req_prepare_sleep *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_xfer *xfer;
struct device *dev;
int ret = 0;
@@ -1617,7 +1578,7 @@ static int ti_sci_cmd_prepare_sleep(const struct ti_sci_handle *handle, u8 mode,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_PREPARE_SLEEP,
msg_flags,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -1630,13 +1591,10 @@ static int ti_sci_cmd_prepare_sleep(const struct ti_sci_handle *handle, u8 mode,
ret = ti_sci_do_xfer(info, xfer);
if (ret) {
dev_err(dev, "Failed to prepare sleep\n");
- goto fail;
+ return ret;
}
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
-
- return ret;
+ return 0;
}
/**
@@ -1655,7 +1613,7 @@ static int ti_sci_msg_cmd_query_fw_caps(const struct ti_sci_handle *handle,
{
struct ti_sci_info *info;
struct ti_sci_xfer *xfer;
- struct ti_sci_msg_resp_query_fw_caps *resp;
+ struct ti_sci_msg_resp_query_fw_caps resp;
struct device *dev;
int ret = 0;
@@ -1670,25 +1628,20 @@ static int ti_sci_msg_cmd_query_fw_caps(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_QUERY_FW_CAPS,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
sizeof(struct ti_sci_msg_hdr),
- sizeof(*resp));
+ &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
ret = ti_sci_do_xfer(info, xfer);
if (ret) {
dev_err(dev, "Failed to get capabilities\n");
- goto fail;
+ return ret;
}
- resp = (struct ti_sci_msg_resp_query_fw_caps *)xfer->xfer_buf;
-
if (fw_caps)
- *fw_caps = resp->fw_caps;
-
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ *fw_caps = resp.fw_caps;
- return ret;
+ return 0;
}
/**
@@ -1703,7 +1656,7 @@ static int ti_sci_cmd_set_io_isolation(const struct ti_sci_handle *handle,
{
struct ti_sci_info *info;
struct ti_sci_msg_req_set_io_isolation *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_xfer *xfer;
struct device *dev;
int ret = 0;
@@ -1718,7 +1671,7 @@ static int ti_sci_cmd_set_io_isolation(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_SET_IO_ISOLATION,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -1728,13 +1681,10 @@ static int ti_sci_cmd_set_io_isolation(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret) {
dev_err(dev, "Failed to set IO isolation\n");
- goto fail;
+ return ret;
}
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
-
- return ret;
+ return 0;
}
/**
@@ -1752,7 +1702,7 @@ static int ti_sci_msg_cmd_lpm_wake_reason(const struct ti_sci_handle *handle,
{
struct ti_sci_info *info;
struct ti_sci_xfer *xfer;
- struct ti_sci_msg_resp_lpm_wake_reason *resp;
+ struct ti_sci_msg_resp_lpm_wake_reason resp;
struct device *dev;
int ret = 0;
@@ -1767,31 +1717,26 @@ static int ti_sci_msg_cmd_lpm_wake_reason(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_LPM_WAKE_REASON,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
sizeof(struct ti_sci_msg_hdr),
- sizeof(*resp));
+ &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
ret = ti_sci_do_xfer(info, xfer);
if (ret) {
dev_err(dev, "Failed to get wake reason\n");
- goto fail;
+ return ret;
}
- resp = (struct ti_sci_msg_resp_lpm_wake_reason *)xfer->xfer_buf;
-
if (source)
- *source = resp->wake_source;
+ *source = resp.wake_source;
if (timestamp)
- *timestamp = resp->wake_timestamp;
+ *timestamp = resp.wake_timestamp;
if (pin)
- *pin = resp->wake_pin;
+ *pin = resp.wake_pin;
if (mode)
- *mode = resp->mode;
-
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ *mode = resp.mode;
- return ret;
+ return 0;
}
/**
@@ -1807,7 +1752,7 @@ static int ti_sci_cmd_set_device_constraint(const struct ti_sci_handle *handle,
{
struct ti_sci_info *info;
struct ti_sci_msg_req_lpm_set_device_constraint *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_xfer *xfer;
struct device *dev;
int ret = 0;
@@ -1822,7 +1767,7 @@ static int ti_sci_cmd_set_device_constraint(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_LPM_SET_DEVICE_CONSTRAINT,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -1833,13 +1778,10 @@ static int ti_sci_cmd_set_device_constraint(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret) {
dev_err(dev, "Failed to set device constraint\n");
- goto fail;
+ return ret;
}
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
-
- return ret;
+ return 0;
}
/**
@@ -1855,7 +1797,7 @@ static int ti_sci_cmd_set_latency_constraint(const struct ti_sci_handle *handle,
{
struct ti_sci_info *info;
struct ti_sci_msg_req_lpm_set_latency_constraint *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_xfer *xfer;
struct device *dev;
int ret = 0;
@@ -1870,7 +1812,7 @@ static int ti_sci_cmd_set_latency_constraint(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_LPM_SET_LATENCY_CONSTRAINT,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -1881,13 +1823,10 @@ static int ti_sci_cmd_set_latency_constraint(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret) {
dev_err(dev, "Failed to set device constraint\n");
- goto fail;
+ return ret;
}
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
-
- return ret;
+ return 0;
}
/**
@@ -1900,13 +1839,13 @@ static int ti_sci_cmd_lpm_abort(struct device *dev)
{
struct ti_sci_info *info = dev_get_drvdata(dev);
struct ti_sci_msg_hdr *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_xfer *xfer;
int ret = 0;
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_LPM_ABORT,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -1914,19 +1853,16 @@ static int ti_sci_cmd_lpm_abort(struct device *dev)
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ return ret;
- return ret;
+ return 0;
}
static int ti_sci_cmd_core_reboot(const struct ti_sci_handle *handle)
{
struct ti_sci_info *info;
struct ti_sci_msg_req_reboot *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_xfer *xfer;
int ret = 0;
@@ -1939,7 +1875,7 @@ static int ti_sci_cmd_core_reboot(const struct ti_sci_handle *handle)
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_SYS_RESET,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -1947,12 +1883,9 @@ static int ti_sci_cmd_core_reboot(const struct ti_sci_handle *handle)
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ return ret;
- return ret;
+ return 0;
}
/**
@@ -1973,7 +1906,7 @@ static int ti_sci_get_resource_range(const struct ti_sci_handle *handle,
u32 dev_id, u8 subtype, u8 s_host,
struct ti_sci_resource_desc *desc)
{
- struct ti_sci_msg_resp_get_resource_range *resp;
+ struct ti_sci_msg_resp_get_resource_range resp;
struct ti_sci_msg_req_get_resource_range *req;
struct ti_sci_xfer *xfer;
struct ti_sci_info *info;
@@ -1988,7 +1921,7 @@ static int ti_sci_get_resource_range(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_GET_RESOURCE_RANGE,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -1999,23 +1932,18 @@ static int ti_sci_get_resource_range(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
- resp = (struct ti_sci_msg_resp_get_resource_range *)xfer->xfer_buf;
+ return ret;
- if (!resp->range_num && !resp->range_num_sec) {
+ if (!resp.range_num && !resp.range_num_sec) {
/* Neither of the two resource range is valid */
ret = -ENODEV;
} else {
- desc->start = resp->range_start;
- desc->num = resp->range_num;
- desc->start_sec = resp->range_start_sec;
- desc->num_sec = resp->range_num_sec;
+ desc->start = resp.range_start;
+ desc->num = resp.range_num;
+ desc->start_sec = resp.range_start_sec;
+ desc->num_sec = resp.range_num_sec;
}
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
-
return ret;
}
@@ -2087,7 +2015,7 @@ static int ti_sci_manage_irq(const struct ti_sci_handle *handle,
u16 type)
{
struct ti_sci_msg_req_manage_irq *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_xfer *xfer;
struct ti_sci_info *info;
int ret = 0;
@@ -2100,7 +2028,7 @@ static int ti_sci_manage_irq(const struct ti_sci_handle *handle,
info = handle_to_ti_sci_info(handle);
xfer = ti_sci_get_one_xfer(info, type, TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -2118,12 +2046,9 @@ static int ti_sci_manage_irq(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ return ret;
- return ret;
+ return 0;
}
/**
@@ -2402,7 +2327,7 @@ static int ti_sci_cmd_rm_ring_cfg(const struct ti_sci_handle *handle,
const struct ti_sci_msg_rm_ring_cfg *params)
{
struct ti_sci_msg_rm_ring_cfg_req *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_xfer *xfer;
struct ti_sci_info *info;
int ret = 0;
@@ -2414,7 +2339,7 @@ static int ti_sci_cmd_rm_ring_cfg(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_RM_RING_CFG,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -2433,12 +2358,9 @@ static int ti_sci_cmd_rm_ring_cfg(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ return ret;
- return ret;
+ return 0;
}
/**
@@ -2455,7 +2377,7 @@ static int ti_sci_cmd_rm_psil_pair(const struct ti_sci_handle *handle,
u32 nav_id, u32 src_thread, u32 dst_thread)
{
struct ti_sci_msg_psil_pair *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_xfer *xfer;
struct ti_sci_info *info;
int ret = 0;
@@ -2469,7 +2391,7 @@ static int ti_sci_cmd_rm_psil_pair(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_RM_PSIL_PAIR,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -2480,12 +2402,9 @@ static int ti_sci_cmd_rm_psil_pair(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ return ret;
- return ret;
+ return 0;
}
/**
@@ -2502,7 +2421,7 @@ static int ti_sci_cmd_rm_psil_unpair(const struct ti_sci_handle *handle,
u32 nav_id, u32 src_thread, u32 dst_thread)
{
struct ti_sci_msg_psil_unpair *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_xfer *xfer;
struct ti_sci_info *info;
int ret = 0;
@@ -2516,7 +2435,7 @@ static int ti_sci_cmd_rm_psil_unpair(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_RM_PSIL_UNPAIR,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -2527,12 +2446,9 @@ static int ti_sci_cmd_rm_psil_unpair(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ return ret;
- return ret;
+ return 0;
}
/**
@@ -2550,7 +2466,7 @@ static int ti_sci_cmd_rm_udmap_tx_ch_cfg(const struct ti_sci_handle *handle,
const struct ti_sci_msg_rm_udmap_tx_ch_cfg *params)
{
struct ti_sci_msg_rm_udmap_tx_ch_cfg_req *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_xfer *xfer;
struct ti_sci_info *info;
int ret = 0;
@@ -2562,7 +2478,7 @@ static int ti_sci_cmd_rm_udmap_tx_ch_cfg(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TISCI_MSG_RM_UDMAP_TX_CH_CFG,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -2590,12 +2506,9 @@ static int ti_sci_cmd_rm_udmap_tx_ch_cfg(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ return ret;
- return ret;
+ return 0;
}
/**
@@ -2613,7 +2526,7 @@ static int ti_sci_cmd_rm_udmap_rx_ch_cfg(const struct ti_sci_handle *handle,
const struct ti_sci_msg_rm_udmap_rx_ch_cfg *params)
{
struct ti_sci_msg_rm_udmap_rx_ch_cfg_req *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_xfer *xfer;
struct ti_sci_info *info;
int ret = 0;
@@ -2625,7 +2538,7 @@ static int ti_sci_cmd_rm_udmap_rx_ch_cfg(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TISCI_MSG_RM_UDMAP_RX_CH_CFG,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -2650,12 +2563,9 @@ static int ti_sci_cmd_rm_udmap_rx_ch_cfg(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ return ret;
- return ret;
+ return 0;
}
/**
@@ -2673,7 +2583,7 @@ static int ti_sci_cmd_rm_udmap_rx_flow_cfg(const struct ti_sci_handle *handle,
const struct ti_sci_msg_rm_udmap_flow_cfg *params)
{
struct ti_sci_msg_rm_udmap_flow_cfg_req *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_xfer *xfer;
struct ti_sci_info *info;
int ret = 0;
@@ -2685,7 +2595,7 @@ static int ti_sci_cmd_rm_udmap_rx_flow_cfg(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TISCI_MSG_RM_UDMAP_FLOW_CFG,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -2715,12 +2625,9 @@ static int ti_sci_cmd_rm_udmap_rx_flow_cfg(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ return ret;
- return ret;
+ return 0;
}
/**
@@ -2734,7 +2641,7 @@ static int ti_sci_cmd_proc_request(const struct ti_sci_handle *handle,
u8 proc_id)
{
struct ti_sci_msg_req_proc_request *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_info *info;
struct ti_sci_xfer *xfer;
int ret = 0;
@@ -2748,7 +2655,7 @@ static int ti_sci_cmd_proc_request(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_PROC_REQUEST,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -2757,12 +2664,9 @@ static int ti_sci_cmd_proc_request(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ return ret;
- return ret;
+ return 0;
}
/**
@@ -2776,7 +2680,7 @@ static int ti_sci_cmd_proc_release(const struct ti_sci_handle *handle,
u8 proc_id)
{
struct ti_sci_msg_req_proc_release *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_info *info;
struct ti_sci_xfer *xfer;
int ret = 0;
@@ -2790,7 +2694,7 @@ static int ti_sci_cmd_proc_release(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_PROC_RELEASE,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -2799,12 +2703,9 @@ static int ti_sci_cmd_proc_release(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ return ret;
- return ret;
+ return 0;
}
/**
@@ -2821,7 +2722,7 @@ static int ti_sci_cmd_proc_handover(const struct ti_sci_handle *handle,
u8 proc_id, u8 host_id)
{
struct ti_sci_msg_req_proc_handover *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_info *info;
struct ti_sci_xfer *xfer;
int ret = 0;
@@ -2835,7 +2736,7 @@ static int ti_sci_cmd_proc_handover(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_PROC_HANDOVER,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -2845,12 +2746,9 @@ static int ti_sci_cmd_proc_handover(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ return ret;
- return ret;
+ return 0;
}
/**
@@ -2870,7 +2768,7 @@ static int ti_sci_cmd_proc_set_config(const struct ti_sci_handle *handle,
u32 config_flags_clear)
{
struct ti_sci_msg_req_set_config *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_info *info;
struct ti_sci_xfer *xfer;
int ret = 0;
@@ -2884,7 +2782,7 @@ static int ti_sci_cmd_proc_set_config(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_SET_CONFIG,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -2898,12 +2796,9 @@ static int ti_sci_cmd_proc_set_config(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ return ret;
- return ret;
+ return 0;
}
/**
@@ -2921,7 +2816,7 @@ static int ti_sci_cmd_proc_set_control(const struct ti_sci_handle *handle,
u32 control_flags_clear)
{
struct ti_sci_msg_req_set_ctrl *req;
- struct ti_sci_msg_hdr *resp;
+ struct ti_sci_msg_hdr resp;
struct ti_sci_info *info;
struct ti_sci_xfer *xfer;
int ret = 0;
@@ -2935,7 +2830,7 @@ static int ti_sci_cmd_proc_set_control(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_SET_CTRL,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -2946,12 +2841,9 @@ static int ti_sci_cmd_proc_set_control(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
+ return ret;
- return ret;
+ return 0;
}
/**
@@ -2969,7 +2861,7 @@ static int ti_sci_cmd_proc_get_status(const struct ti_sci_handle *handle,
u8 proc_id, u64 *bv, u32 *cfg_flags,
u32 *ctrl_flags, u32 *sts_flags)
{
- struct ti_sci_msg_resp_get_status *resp;
+ struct ti_sci_msg_resp_get_status resp;
struct ti_sci_msg_req_get_status *req;
struct ti_sci_info *info;
struct ti_sci_xfer *xfer;
@@ -2984,7 +2876,7 @@ static int ti_sci_cmd_proc_get_status(const struct ti_sci_handle *handle,
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_GET_STATUS,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
- sizeof(*req), sizeof(*resp));
+ sizeof(*req), &resp, sizeof(resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
@@ -2993,21 +2885,16 @@ static int ti_sci_cmd_proc_get_status(const struct ti_sci_handle *handle,
ret = ti_sci_do_xfer(info, xfer);
if (ret)
- goto fail;
-
- resp = (struct ti_sci_msg_resp_get_status *)xfer->tx_message.buf;
+ return ret;
- *bv = (resp->bootvector_low & TI_SCI_ADDR_LOW_MASK) |
- (((u64)resp->bootvector_high << TI_SCI_ADDR_HIGH_SHIFT) &
+ *bv = (resp.bootvector_low & TI_SCI_ADDR_LOW_MASK) |
+ (((u64)resp.bootvector_high << TI_SCI_ADDR_HIGH_SHIFT) &
TI_SCI_ADDR_HIGH_MASK);
- *cfg_flags = resp->config_flags;
- *ctrl_flags = resp->control_flags;
- *sts_flags = resp->status_flags;
+ *cfg_flags = resp.config_flags;
+ *ctrl_flags = resp.control_flags;
+ *sts_flags = resp.status_flags;
-fail:
- ti_sci_put_one_xfer(&info->minfo, xfer);
-
- return ret;
+ return 0;
}
/*
--
2.34.1
next prev parent reply other threads:[~2026-09-29 20:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 20:17 [PATCH 00/22] Cleanup and Refactor TI-SCI driver Beleswar Padhi
2026-09-29 20:17 ` [PATCH 01/22] firmware: ti_sci: Move error message handling into ti_sci_get_one_xfer() Beleswar Padhi
2026-09-29 20:17 ` [PATCH 02/22] firmware: ti_sci: Move error message handling into ti_sci_do_xfer() Beleswar Padhi
2026-09-29 20:17 ` [PATCH 03/22] firmware: ti_sci: Move check for ACK " Beleswar Padhi
2026-09-29 20:17 ` [PATCH 04/22] firmware: ti_sci: Remove out of place RM debug messages Beleswar Padhi
2026-09-29 20:17 ` [PATCH 05/22] firmware: ti_sci: Name response variable resp for consistency Beleswar Padhi
2026-09-29 20:17 ` Beleswar Padhi [this message]
2026-09-29 20:17 ` [PATCH 07/22] firmware: ti_sci: Pass request struct into ti_sci_do_xfer() Beleswar Padhi
2026-09-29 20:17 ` [PATCH 08/22] firmware: ti_sci: Combine xfer allocation and transfer functions Beleswar Padhi
2026-09-29 20:17 ` [PATCH 09/22] firmware: ti_sci: Fetch info struct from handle inside ti_sci_do_xfer() Beleswar Padhi
2026-09-29 20:17 ` [PATCH 10/22] firmware: ti_sci: Use tx_message as message buffer directly Beleswar Padhi
2026-09-29 20:17 ` [PATCH 11/22] firmware: ti_sci: Use rx_message as message receive buffer Beleswar Padhi
2026-09-29 20:17 ` [PATCH 12/22] firmware: ti_sci: Fix some kernel-doc references in structs Beleswar Padhi
2026-09-29 20:17 ` [PATCH 13/22] soc: ti: ti_sci_protocol.h: Add missing documentation for structs Beleswar Padhi
2026-09-29 20:17 ` [PATCH 14/22] firmware: ti_sci: Do not export reboot control Beleswar Padhi
2026-09-29 20:17 ` [PATCH 15/22] firmware: ti_sci: Use pmops fxn pointers in suspend/resume hooks Beleswar Padhi
2026-09-29 20:17 ` [PATCH 16/22] firmware: ti_sci: Move the huge ti_sci file into its own directory Beleswar Padhi
2026-09-29 20:17 ` [PATCH 17/22] firmware: ti: ti_sci: Add missing includes for self-contained headers Beleswar Padhi
2026-09-29 20:17 ` [PATCH 18/22] firmware: ti: ti_sci_device: Move device ops into its own file Beleswar Padhi
2026-09-29 20:17 ` [PATCH 19/22] firmware: ti: ti_sci_clock: Move clock " Beleswar Padhi
2026-09-29 20:17 ` [PATCH 20/22] firmware: ti: ti_sci_pm: Move pm " Beleswar Padhi
2026-09-29 20:17 ` [PATCH 21/22] firmware: ti: ti_sci_rm: Move rm " Beleswar Padhi
2026-09-29 20:17 ` [PATCH 22/22] firmware: ti: ti_sci_proc: Move processor " Beleswar Padhi
2026-09-30 5:38 ` [PATCH 00/22] Cleanup and Refactor TI-SCI driver Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929201746.4078803-7-b-padhi@ti.com \
--to=b-padhi@ti.com \
--cc=afd@ti.com \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=ssantosh@kernel.org \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®