From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52990486422; Tue, 29 Sep 2026 21:23:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790716984; cv=none; b=XKXdBJ8fgpVDwICRiRcs8Yt/viNjK/HFtNFY9FGL17XX3oUufbL6v6rBJIFwAmlbUuhn+LMQ/l4gJQomkH9jOMJJwRjq3lX829xbcHMz8WhBQLIAt7c2vACQuwQmmpgEAPmNvB+5a7y9O8oF5J0VR/9Ta9RgT29uum0qWE7aM1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790716984; c=relaxed/simple; bh=ysRORcJ0jmsq7CF6yE7D2wJatofEaSVpJ0WCEsLlyKk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ng1+8BSn9EI/oiyMeAIClcrGRClf9QusYaGKYfhq1bWP6DV/UOID/amEkq7BtVEJW0Ly2FuJyChg9PDBjWudQR8HKriPe5A5+FHi2J7Jju/M5jpe07KcpZm3SyCZb1WJxsU/67l98lEP6sBGMlw2X8pYBjWHhTPDsgzH75mkJYo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HrqCoHS5; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HrqCoHS5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4912C1F00893; Tue, 29 Sep 2026 21:23:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790716982; bh=3VWIQhIz2i9wNjdgCB0kdugp0ZEYVUaa5KzaswNLw5Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=HrqCoHS5fokdH9kqYdVF7gKkdppvbviAXCU3wz9mYk4hL2WxocDsiVZxNUvZyQ52W CTusQisHHRA/tI9LQSpP0AxH2ayvRgGatQVTqzIUx9GmzTHPnt8a+OB4yUAgh0tG/8 8UdBoxrTKDWZjGnjoGXR3ydJ7RijkWBA0WBbu3fweLW2tZ1pq6ytAtPABFg4UXFMgO yfMRjWO1qsPxbkQbgvYFC8gnX9x2mMdEthcp34/VzhhUEyNqAnQsqv+ezPMlHLJRy8 GRZEYTRdMn+FpuuLZ+9eodlN2Qf12mLH9nRWY8X8OZ0YasTBvp43/meB3zNWBfLytb /EPgTuZ6hRiaA== From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Thomas Gleixner , James Clark , Jiri Olsa , Ian Rogers , Adrian Hunter , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo Subject: [PATCH 3/5] perf report: Add --no-progress option Date: Tue, 29 Sep 2026 23:22:44 +0200 Message-ID: <20260929212246.2532021-4-acme@kernel.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260929212246.2532021-1-acme@kernel.org> References: <20260929212246.2532021-1-acme@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnaldo Carvalho de Melo Add the counterpart of --progress: the TUI and GTK browsers present progress of their own and there is no way to turn it off, while the option just added allows asking for it when there is none. Install the no-op ui_progress ops, the ones already used until a backend sets theirs, after setup_browser() installed them. The phases are still counted, nothing is shown for them, and --no-progress takes precedence over --progress. Suggested-by: Namhyung Kim Assisted-by: LLM Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/Documentation/perf-report.txt | 5 +++++ tools/perf/builtin-report.c | 17 ++++++++++++++--- tools/perf/ui/progress.c | 6 ++++++ tools/perf/ui/progress.h | 2 ++ 4 files changed, 27 insertions(+), 3 deletions(-) diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt index a7429a30ec28f903..bc0f2031b100f425 100644 --- a/tools/perf/Documentation/perf-report.txt +++ b/tools/perf/Documentation/perf-report.txt @@ -43,6 +43,11 @@ OPTIONS present progress information, or when --quiet is used, that asks for no messages at all. +--no-progress:: + Do not show progress while processing the perf.data file. It + also turns off the progress the TUI and GTK browsers present, + which is their own, and takes precedence over --progress. + -n:: --show-nr-samples:: Show the number of samples for each symbol diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 963808b561e547c3..8d23c077fab5f874 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -88,6 +88,7 @@ struct report { #endif bool use_stdio; bool progress; + bool no_progress; bool show_full_info; bool show_threads; bool inverted_callchain; @@ -1385,8 +1386,16 @@ int cmd_report(int argc, const char **argv) "Use the stdio interface"), OPT_BOOLEAN(0, "weights", &symbol_conf.annotate_weight, "Show or hide weight columns in annotation. Default show if non-zero."), - OPT_BOOLEAN(0, "progress", &report.progress, - "Show progress while processing the perf.data file"), + /* + * Not auto negatable: parse-options turns --no-progress into the + * negation of this option before it ever reaches the --no-progress + * below, which is the one that also turns off the TUI and GTK progress. + */ + OPT_BOOLEAN_FLAG(0, "progress", &report.progress, + "Show progress while processing the perf.data file", + PARSE_OPT_NOAUTONEG), + OPT_BOOLEAN(0, "no-progress", &report.no_progress, + "Do not show progress while processing the perf.data file"), OPT_BOOLEAN(0, "header", &report.header, "Show data header."), OPT_BOOLEAN(0, "header-only", &report.header_only, "Show only data header."), @@ -1798,7 +1807,9 @@ int cmd_report(int argc, const char **argv) * processed so far for each processing phase. --quiet asks for no * messages at all, so it leaves the phases uncounted. */ - if (report.progress && !quiet && use_browser == 0) + if (report.no_progress) + ui_progress__noop_init(); + else if (report.progress && !quiet && use_browser == 0) stdio_progress__init(); if (report.data_type && use_browser == 1) { diff --git a/tools/perf/ui/progress.c b/tools/perf/ui/progress.c index 99d60223c74b2957..362680989ace606a 100644 --- a/tools/perf/ui/progress.c +++ b/tools/perf/ui/progress.c @@ -13,6 +13,12 @@ static struct ui_progress_ops null_progress__ops = struct ui_progress_ops *ui_progress__ops = &null_progress__ops; +/* Everything counts but nothing is shown, the way it starts out. */ +void ui_progress__noop_init(void) +{ + ui_progress__ops = &null_progress__ops; +} + void ui_progress__update(struct ui_progress *p, u64 adv) { u64 last = p->curr; diff --git a/tools/perf/ui/progress.h b/tools/perf/ui/progress.h index 03f1a8bb260ba076..e8c4f9f768aaf12b 100644 --- a/tools/perf/ui/progress.h +++ b/tools/perf/ui/progress.h @@ -25,6 +25,8 @@ void ui_progress__update(struct ui_progress *p, u64 adv); void stdio_progress__init(void); +void ui_progress__noop_init(void); + struct ui_progress_ops { void (*init)(struct ui_progress *p); void (*update)(struct ui_progress *p); -- 2.55.0