From: Tim auf der Landwehr <tadl-git@taufderl.de>
To: Kristian Brox <isyourbrainfoss@proton.me>
Cc: David Heidelberg <david@ixit.cz>,
luca.weiss@fairphone.com, oe-linux-nfc@lists.linux.dev,
linux-kernel@vger.kernel.org,
Tim auf der Landwehr <tadl-git@taufderl.de>
Subject: [PATCH 0/3] nfc: st-nci: three ST21NFCD fixes found bringing v4 up on the Fairphone 4
Date: Wed, 30 Sep 2026 00:41:22 +0200 [thread overview]
Message-ID: <20260929224125.3656680-1-tadl-git@taufderl.de> (raw)
In-Reply-To: <20260902-fp5-st21nfcd-v4-v4-0-ded2f1c501be@proton.me>
These are the three fixes from bringing your v4 st,st21nfcd series up on the
Fairphone 4 (sm7225, Adreno). They apply on top of v4. Sending them here so you
can fold whatever is useful into v5; z3ntu (Luca) asked me to sync them into your
series (sm6350-mainline/linux#14).
1. Map the proprietary RF protocol 0x90 to NFC_PROTO_MIFARE_MASK, or
nci_add_new_protocol drops a MIFARE Classic as unmappable.
2. Restart the reference clock on power-up, scoped to the raw-NCI part. This is
the wedge Luca reported: after a poll enable/disable/enable the controller
stops answering NCI (DEV_UP CORE_RESET times out), and it only recovers when
the input clock is stopped and restarted, not on a reset pulse alone. On FP4
this took DEV_UP from 0/6 to 12/12 across cycles.
3. Treat the idle 0x7e first read as no-data, or buf[2] is taken as a length and
the next real frame desyncs off the bus ("invalid frame len").
All three checkpatch --strict clean; verified on an FP4 with the mic/NFC DTS.
Tim auf der Landwehr (3):
nfc: st-nci: map proprietary RF 0x90 to MIFARE
nfc: st-nci: restart the reference clock on power-up
nfc: st-nci: treat the idle 0x7e read as no-data
drivers/nfc/st-nci/core.c | 15 +++++++++++--
drivers/nfc/st-nci/i2c.c | 44 +++++++++++++++++++++++++++++++--------
2 files changed, 48 insertions(+), 11 deletions(-)
--
2.55.0
next prev parent reply other threads:[~2026-09-29 22:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 21:22 [PATCH v4 0/3] nfc: st-nci: Fairphone 5 NFC bring-up (ST21NFCD) Kristian Brox
2026-09-02 21:22 ` [PATCH v4 1/3] dt-bindings: net: nfc: add st,st21nfcd Kristian Brox
2026-09-03 13:47 ` Krzysztof Kozlowski
2026-09-02 21:22 ` [PATCH v4 2/3] nfc: st-nci: add raw NCI path for ST21NFCD Kristian Brox
2026-09-02 21:22 ` [PATCH v4 3/3] arm64: dts: qcom: qcm6490-fairphone-fp5: add ST21NFCD NFC Kristian Brox
2026-09-03 6:49 ` Konrad Dybcio
2026-09-03 7:49 ` Abel Vesa
2026-09-18 8:08 ` [PATCH v4 0/3] nfc: st-nci: Fairphone 5 NFC bring-up (ST21NFCD) Luca Weiss
2026-09-23 19:35 ` Kristian Brox
2026-09-29 22:41 ` Tim auf der Landwehr [this message]
2026-09-29 22:41 ` [PATCH 1/3] nfc: st-nci: map proprietary RF 0x90 to MIFARE Tim auf der Landwehr
2026-09-29 22:41 ` [PATCH 2/3] nfc: st-nci: restart the reference clock on power-up Tim auf der Landwehr
2026-09-29 22:41 ` [PATCH 3/3] nfc: st-nci: treat the idle 0x7e read as no-data Tim auf der Landwehr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929224125.3656680-1-tadl-git@taufderl.de \
--to=tadl-git@taufderl.de \
--cc=david@ixit.cz \
--cc=isyourbrainfoss@proton.me \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=oe-linux-nfc@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®