From: Alice Ryhl <aliceryhl@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Carlos Llamas <cmllamas@google.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Tamir Duberstein" <tamird@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Onur Özkan" <work@onurozkan.dev>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
"Alice Ryhl" <aliceryhl@google.com>
Subject: [PATCH 1/3] rust_binder: start debug_id at 1
Date: Wed, 30 Sep 2026 12:48:42 +0000 [thread overview]
Message-ID: <20260930-binder-transaction-log-v1-1-3d832fb30388@google.com> (raw)
In-Reply-To: <20260930-binder-transaction-log-v1-0-3d832fb30388@google.com>
In the C Binder driver, debug IDs are allocated with
atomic_inc_return(&binder_last_id), so valid debug IDs start at 1 and 0
is never assigned.
Start NEXT_DEBUG_ID at 1 in Rust Binder as well so that 0 can be used as
a sentinel for an absent or uninitialized debug_id (such as in
TransactionInfo::to_node_debug_id and in transaction log entries).
Assisted-by: LLM
Signed-off-by: Alice Ryhl <aliceryhl@google.com>
---
drivers/android/binder/rust_binder_main.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/android/binder/rust_binder_main.rs b/drivers/android/binder/rust_binder_main.rs
index 955c4c348f73..e360df991d51 100644
--- a/drivers/android/binder/rust_binder_main.rs
+++ b/drivers/android/binder/rust_binder_main.rs
@@ -96,7 +96,7 @@ fn default() -> Self {
};
fn next_debug_id() -> usize {
- static NEXT_DEBUG_ID: Atomic<usize> = Atomic::new(0);
+ static NEXT_DEBUG_ID: Atomic<usize> = Atomic::new(1);
NEXT_DEBUG_ID.fetch_add(1, Relaxed)
}
--
2.56.0.rc1.315.gc6ed9934b7-goog
next prev parent reply other threads:[~2026-09-30 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 12:48 [PATCH 0/3] rust_binder: error line numbers and failed_transaction_log Alice Ryhl
2026-09-30 12:48 ` Alice Ryhl [this message]
2026-09-30 12:48 ` [PATCH 2/3] rust_binder: track caller location in BinderError Alice Ryhl
2026-09-30 12:48 ` [PATCH 3/3] rust_binder: add transaction_log and failed_transaction_log Alice Ryhl
2026-09-30 13:30 ` [PATCH 0/3] rust_binder: error line numbers " Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930-binder-transaction-log-v1-1-3d832fb30388@google.com \
--to=aliceryhl@google.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=cmllamas@google.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®