From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AF375208D9 for ; Wed, 30 Sep 2026 17:32:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790789552; cv=none; b=ueeXu3Mik+8Pji2bBIQ+fuhbtGD54n+PVauCoCjUxRZRusdg+A2dUUkpxL2s5Qfr08ZkucZHPSQIK+qCHZiAQTcBKX0Iofil6tdLWyLZWmO3o4B2cZTybIZRR9K+KIYSkBFA+4o3BM5RJzOhD5R6//AmIq87Hxd24eViifpz4SM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790789552; c=relaxed/simple; bh=wROnZH5w/HgEnfohcLPrucgfChxgdtNv1tAynP5CqZU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RxZ37EShZJQgieU/sN271fqf2jfZuw2n8Y0T5Uo7kQi8MGmEL+75ozZtXUc8OsbXztGmhej8S9YE5U8g5+t4zqFHlr8iPuDZpMUuRZAcGPaWLc5sf4flbHZMjLj4koITMjCP97Qs+OrxnjSn1QzSjtNUku5Sdr/TKYXevJ3VUfk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de; spf=pass smtp.mailfrom=posteo.de; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b=LLvQA0b7; arc=none smtp.client-ip=185.67.36.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="LLvQA0b7" Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id B5BD8240104 for ; Wed, 30 Sep 2026 19:32:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=1984.8680eb; t=1790789548; bh=shN8NFGcstwZPmTOc1xNbjhCshXXahtAgSO3rVvQXEI=; h=From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:To:Cc:Autocrypt:OpenPGP:From; b=LLvQA0b7qokZZQH6sTTzmJy2+gfMhptW26Pw3b1X0FJ2DjJgobAD7IATxHpqez1vx aQsCZkalO3hUcrR9w6+1MIy0ZEsjSeB0oVaSal7+UE4R6CT0TtE7zBRNXccGr0tcXX Xyj6D4DAHj6snH8w22l76kcJSOkHnaxhEcQ83IPU7YiP+MYAWMBqJRql8RvPJpiZ34 iiK2JZQOQRY7My2IQAO0gt4YF9oh6LUZa2LkjfMSHqvlObP3hbNkMhaodZtMmxDpDS zFEepLiKtcjhMf1HkZ+FpeUMQjiAR5Kn5ISj4EZnW3sDpSrh+NuQQ4OJgQNMVepKMg 19Q/DE2KcR7lA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4hw2DT3B05z9rxD; Wed, 30 Sep 2026 19:32:25 +0200 (CEST) From: Markus Probst Date: Wed, 30 Sep 2026 17:32:27 +0000 Subject: [PATCH v3 1/4] tty: serdev: Add mutex lock Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260930-rust_serdev_probe_refactor-v3-1-d1b6e77135e0@posteo.de> References: <20260930-rust_serdev_probe_refactor-v3-0-d1b6e77135e0@posteo.de> In-Reply-To: <20260930-rust_serdev_probe_refactor-v3-0-d1b6e77135e0@posteo.de> To: Ayush Singh , Johan Hovold , Alex Elder , Greg Kroah-Hartman , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?utf-8?q?Onur_=C3=96zkan?= , Eric Biggers , Ard Biesheuvel , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki , Jiri Slaby , "Rafael J. Wysocki" Cc: greybus-dev@lists.linaro.org, linux-serial@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, Markus Probst X-Developer-Signature: v=1; a=openpgp-sha256; l=5000; i=markus.probst@posteo.de; h=from:subject:message-id; bh=wROnZH5w/HgEnfohcLPrucgfChxgdtNv1tAynP5CqZU=; b=owEBiQJ2/ZANAwAIATR2H/jnrUPSAcsmYgBqvUel7Y+6iGUkcZRV6FoC5OUM7ycgG4wQt+TuT /VawAsVHOSJAk8EAAEIADkWIQSCdBjE9KxY53IwxHM0dh/4561D0gUCar1HpRsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQNHYf+OetQ9Inag/+MA8Mz53D2UH2yd9YO0b+lUC6eRljgzj BhXWYHD4VrLjXpvSwKyyWX5e4oljO9E3seHqovaORH+btosH8mgYy9VigZN6wOquh3WZBKcBm1R TTQeOlEDUUJlwXkuPevDxWI0P2y1qVEESHvIQv0B80wocYS3GMEe+sbxMCA9gml411MSq+X3vbF o9xddzNIMl4bHS4wGA163WHsqh0UjQPSyrUZizWhIf7xDGSaEedI+XVb3raf+sSMKgP2R52LHuT JQMNg/IKIT4K9rqy4cNLV5SkPSOqwTfEBbrNRoOB3op4gbYBbHxLF4asD6KKhIRA2Zz6DQQFpHu +gGjuCU329lcDUZiIr+7h5P3/oKjdm5LQXzgXa13cpc+AoBLcAFTkoB7csRle8GSekwaQYlganW FRof0k2auCsq7r2QCiNXoN3S890yae4Yjut4nLnNI0E0pbyBYrmvlQPIANLkXVioqV99F0Sjjbo Ja6yyliHMuc2xTc6SXWBHL1cTlUd+NItoGY9JBfPjbKayXidyabr4m5M9gRcGjghd0f/NfBAeZF WONXVpYSKOGFDU1uNJ6gufrjCkfTfUJvUfmkyz422i91Q1xuwiqQnA1RWskYjIku8I4KgYc5uct 2WUqDi5h/MMuRTvb+z87wC9K2zNP4oKHtvqk4HJ2LomCsoFCyU+8= X-Developer-Key: i=markus.probst@posteo.de; a=openpgp; fpr=827418C4F4AC58E77230C47334761FF8E7AD43D2 Autocrypt: addr=markus.probst@posteo.de; prefer-encrypt=mutual; keydata=xsFNBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93qReNLkO WguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVAm76Ww+ /pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt9k5JA RhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbmfAja oT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwTjRQ xBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1J+ FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN6 OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJC XCeMe4BO4iaxUQARAQABzRdtYXJrdXMucHJvYnN0QHBvc3Rlby5kZcLBkQQTAQgAOxYhBIJ0GMT0 rFjncjDEczR2H/jnrUPSBQJog714AhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEDR2 H/jnrUPSgdkQAISaTk2D345ehXEkn5z2yUEjaVjHIE7ziqRaOgn/QanCgeTUinIv6L6QXUFvvIfH 1OLPwQ1hfvEg9NnNLyFezWSy6jvoVBTIPqicD/r3FkithnQ1IDkdSjrarPMxJkvuh3l7XZHo49GV HQ8i5zh5w4YISrcEtE99lJisvni2Jqx7we5tey9voQFDyM8jxlSWv3pmoUTCtBkX/eKHJXosgsuS B4TGDCVPOjla/emI5c9MhMG7O4WEEmoSdPbmraPw66YZD6uLyhV4DPHbiDWRzXWnClHSyjB9rky9 lausFxogvu4l9H+KDsXIadNDWdLdu1/enS/wDd9zh5S78rY2jeXaG4mnf4seEKamZ7KQ6FIHrcyP ezdDzssPQcTQcGRMQzCn6wP3tlGk7rsfmyHMlFqdRoNNv+ZER/OkmZFPW655zRfbMi0vtrqK2Awm 9ggobb1oktfd9PPNXMUY+DNVlgR2G7jLnenSoQausLUm0pHoNE8TWFv851Y6SOYnvn488sP1Tki5 F3rKwclawQFHUXTCQw+QSh9ay8xgnNZfH+u9NY7w3gPoeKBOAFcBc2BtzcgekeWS8qgEmm2/oNFV G0ivPQbRx8FjRKbuF7g3YhgNZZ0ac8FneuUtJ2PkSIFTZhaAiC0utvxk0ndmWFiW4acEkMZGrLaM L2zWNjrqwsD2zsFNBGiDvXgBEADCXQy1n7wjRxG12DOVADawjghKcG+5LtEf31WftHKLFbp/HArj BhkT6mj+CCI1ClqY+FYU5CK/s0ScMfLxRGLZ0Ktzawb78vOgBVFT3yB1yWBTewsAXdqNqRooaUNo 8cG/NNJLjhccH/7PO/FWX5qftOVUJ/AIsAhKQJ18Tc8Ik73v427EDxuKb9mTAnYQFA3Ev3hAiVbO 6Rv39amVOfJ8sqwiSUGidj2Fctg2aB5JbeMln0KCUbTD1LhEFepeKypfofAXQbGwaCjAhmkWy/q3 IT1mUrPxOngbxdRoOx1tGUC0HCMUW1sFaJgQPMmDcR0JGPOpgsKnitsSnN7ShcCr1buel7vLnUMD +TAZ5opdoF6HjAvAnBQaijtK6minkrM0seNXnCg0KkV8xhMNa6zCs1rq4GgjNLJue2EmuyHooHA4 7JMoLVHcxVeuNTp6K2+XRx0Pk4e2Lj8IVy9yEYyrywEOC5XRW37KJjsiOAsumi1rkvM7QREWgUDe Xs0+RpxI3QrrANh71fLMRo7LKRF3Gvw13NVCCC9ea20P4PwhgWKStkwO2NO+YJsAoS1QycMi/vKu 0EHhknYXamaSV50oZzHKmX56vEeJHTcngrM8R1SwJCYopCx9gkz90bTVYlitJa5hloWTYeMD7FNj Y6jfVSzgM/K4gMgUNDW/PPGeMwARAQABwsF2BBgBCAAgFiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IF AmiDvXgCGwwACgkQNHYf+OetQ9LHDBAAhk+ab8+WrbS/b1/gYW3q1KDiXU719nCtfkUVXKidW5Ec Idlr5HGt8ilLoxSWT2Zi368iHCXS0WenGgPwlv8ifvB7TOZiiTDZROZkXjEBmU4nYjJ7GymawpWv oQwjMsPuq6ysbzWtOZ7eILx7cI0FjQeJ/Q2baRJub0uAZNwBOxCkAS6lpk5Fntd2u8CWmDQo4SYp xeuQ+pwkp0yEP30RhN2BO2DXiBEGSZSYh+ioGbCHQPIV3iVj0h6lcCPOqopZqyeCfigeacBI0nvN jHWz/spzF3+4OS+3RJvoHtAQmProxyGib8iVsTxgZO3UUi4TSODeEt0i0kHSPY4sCciOyXfAyYoD DFqhRjOEwBBxhr+scU4C1T2AflozvDwq3VSONjrKJUkhd8+WsdXxMdPFgBQuiKKwUy11mz6KQfcR wmDehF3UaUoxa+YIhWPbKmycxuX/D8SvnqavzAeAL1OcRbEI/HsoroVlEFbBRNBZLJUlnTPs8ZcU 4+8rq5YX1GUrJL3jf6SAfSgO7UdkEET3PdcKFYtS+ruV1Cp5V0q4kCfI5jk25iiz8grM2wOzVSsc l1mEkhiEPH87HP0whhb544iioSnumd3HJKL7dzhRegsMizatupp8D65A2JziW0WKopa1iw9fti3A aBeNN4ijKZchBXHPgVx+YtWRHfcm4l8= OpenPGP: url=https://posteo.de/keys/markus.probst@posteo.de.asc; preference=encrypt Besides more predictable behaviour, this allows for several hardened behaviour changes: Return -EALREADY in `serdev_device_open` if the device is already open instead of causing undefined behaviour. Allow calling `serdev_device_close`, even if the device is already closed instead of causing a null pointer dereference. If the device is left open by the driver after remove, close it and warn instead of leaving it in a invalid state. Signed-off-by: Markus Probst --- drivers/tty/serdev/core.c | 10 +++++++--- drivers/tty/serdev/serdev-ttyport.c | 35 +++++++++++++++++++++++++++++------ include/linux/serdev.h | 2 +- 3 files changed, 37 insertions(+), 10 deletions(-) diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c index 7500efcdfc21..77e8e1d4d2a6 100644 --- a/drivers/tty/serdev/core.c +++ b/drivers/tty/serdev/core.c @@ -142,6 +142,11 @@ void serdev_device_remove(struct serdev_device *serdev) struct serdev_controller *ctrl = serdev->ctrl; device_unregister(&serdev->dev); + + /* Warn if driver did not close the serial device. */ + if (ctrl->ops->close && WARN_ON(ctrl->ops->close(ctrl))) + pm_runtime_put(&ctrl->dev); + ctrl->serdev = NULL; } EXPORT_SYMBOL_GPL(serdev_device_remove); @@ -181,9 +186,8 @@ void serdev_device_close(struct serdev_device *serdev) if (!ctrl || !ctrl->ops->close) return; - pm_runtime_put(&ctrl->dev); - - ctrl->ops->close(ctrl); + if (ctrl->ops->close(ctrl)) + pm_runtime_put(&ctrl->dev); } EXPORT_SYMBOL_GPL(serdev_device_close); diff --git a/drivers/tty/serdev/serdev-ttyport.c b/drivers/tty/serdev/serdev-ttyport.c index bab1b143b8a6..c11908f5e1ce 100644 --- a/drivers/tty/serdev/serdev-ttyport.c +++ b/drivers/tty/serdev/serdev-ttyport.c @@ -16,6 +16,7 @@ struct serport { struct tty_driver *tty_drv; int tty_idx; unsigned long flags; + struct mutex lock; /* lock preventing modification of flags */ }; /* @@ -29,6 +30,8 @@ static size_t ttyport_receive_buf(struct tty_port *port, const u8 *cp, struct serport *serport = serdev_controller_get_drvdata(ctrl); size_t ret; + guard(mutex)(&serport->lock); + if (!test_bit(SERPORT_ACTIVE, &serport->flags)) return 0; @@ -99,14 +102,23 @@ static int ttyport_open(struct serdev_controller *ctrl) struct ktermios ktermios; int ret; + mutex_lock(&serport->lock); + + if (test_bit(SERPORT_ACTIVE, &serport->flags)) { + ret = -EALREADY; + goto err_flags_unlock; + } + tty = tty_init_dev(serport->tty_drv, serport->tty_idx); - if (IS_ERR(tty)) - return PTR_ERR(tty); + if (IS_ERR(tty)) { + ret = PTR_ERR(tty); + goto err_flags_unlock; + } serport->tty = tty; if (!tty->ops->open || !tty->ops->close) { ret = -ENODEV; - goto err_unlock; + goto err_tty_unlock; } ret = tty->ops->open(serport->tty, NULL); @@ -130,23 +142,30 @@ static int ttyport_open(struct serdev_controller *ctrl) set_bit(SERPORT_ACTIVE, &serport->flags); + mutex_unlock(&serport->lock); + return 0; err_close: tty->ops->close(tty, NULL); -err_unlock: +err_tty_unlock: tty_unlock(tty); tty_release_struct(tty, serport->tty_idx); +err_flags_unlock: + mutex_unlock(&serport->lock); return ret; } -static void ttyport_close(struct serdev_controller *ctrl) +static bool ttyport_close(struct serdev_controller *ctrl) { struct serport *serport = serdev_controller_get_drvdata(ctrl); struct tty_struct *tty = serport->tty; - clear_bit(SERPORT_ACTIVE, &serport->flags); + guard(mutex)(&serport->lock); + + if (!__test_and_clear_bit(SERPORT_ACTIVE, &serport->flags)) + return false; tty_lock(tty); if (tty->ops->close) @@ -154,6 +173,8 @@ static void ttyport_close(struct serdev_controller *ctrl) tty_unlock(tty); tty_release_struct(tty, serport->tty_idx); + + return true; } static unsigned int ttyport_set_baudrate(struct serdev_controller *ctrl, unsigned int speed) @@ -288,6 +309,8 @@ struct device *serdev_tty_port_register(struct tty_port *port, port->client_ops = &client_ops; port->client_data = ctrl; + mutex_init(&serport->lock); + ret = serdev_controller_add(ctrl); if (ret) goto err_reset_data; diff --git a/include/linux/serdev.h b/include/linux/serdev.h index b6c3d957ec15..0f4e81c0950d 100644 --- a/include/linux/serdev.h +++ b/include/linux/serdev.h @@ -81,7 +81,7 @@ struct serdev_controller_ops { ssize_t (*write_buf)(struct serdev_controller *, const u8 *, size_t); void (*write_flush)(struct serdev_controller *); int (*open)(struct serdev_controller *); - void (*close)(struct serdev_controller *); + bool (*close)(struct serdev_controller *); void (*set_flow_control)(struct serdev_controller *, bool); int (*set_parity)(struct serdev_controller *, enum serdev_parity); unsigned int (*set_baudrate)(struct serdev_controller *, unsigned int); -- 2.55.0