From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo2-f43.google.com (mail-oo2-f43.google.com [74.125.231.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FD8C3EB0E7 for ; Thu, 1 Oct 2026 04:39:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.231.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790829567; cv=none; b=slFqPKzixWTbQUKljUQ8sBMUudFwv6Az5sFZZw189/Qq/wTyObxgnhL2QTqHCZfFIFf5QOtFVHMADDbN7eDh2rJoiyJjL6OSr3pMCw90V3eVz/1eA04J6hE7ANN9fLnmqPxUNHr0W41rK877rpVXBv6FgxFpTP4arpcvaNRjcM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790829567; c=relaxed/simple; bh=SxL7aIselSeVkJQgx98etKVzBZMns7vJQbD/l7L+jFI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=Xsp0RUXHUi6n8K8qKQb0Gd99zrxbxMTmSppTQmwii+s+dlJTKejUuUmpt8tYdfK1hO54qdn56PTlvBVttK76T/yeXaSSk/JIDjtm7bapg5m95goifK/p9SpjBfa/E2NL8TaErmLM5XTlnK0WNqRFCL7U3Zvh71exzOcwaQm/Tl8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PEFLDcfn; arc=none smtp.client-ip=74.125.231.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PEFLDcfn" Received: by mail-oo2-f43.google.com with SMTP id 46e09a7af769-81b02c279beso3663227a34.2 for ; Wed, 30 Sep 2026 21:39:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790829565; x=1791434365; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=3lo2Y0hgRgiPSnYGSDe7Yf1GMCBIGPwRSlX2+EmhVtc=; b=PEFLDcfnsnAGhyfEZkE0rRag3W7PX3qCUnYBZpWp1sbyF6GwWfd5rStaLfpztuwo4t LsDl/l+WrZKjBZ5mk+Z5sY/GFUBNQTx7L5jC+NFj3RibT1u3nkvhxkRJeNSn6pdhgzmT DPKgvF7Ma4Rbn+U73H35H9/cc02SK5F2SLDEi+NclZ2bOkZrkbFzOPTguz5jOrCNCEx7 mX2m7a+5OTsOd45v5AOiGx29IcSrui9bt5BLUInviJwsP9gchTblNLqqlDziDpFsznsq tMnTI0BLWBTD51eUT9E7AotMxNUAOYPGajA2w98t8uixq8wK1mJFVeiuY1AFt4vXZtJC v7lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790829565; x=1791434365; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=3lo2Y0hgRgiPSnYGSDe7Yf1GMCBIGPwRSlX2+EmhVtc=; b=OkXt+HJBiZMTZ1We/gC68ITplQPLp2zL1lLhcujZjgT27RKJr+mO7AZlGIrvISB50F AYJEZEVFNSK4DLm7UCyjPn39/nCnGTBnBZg4w9rkAkxFbXuU/zD0vHBemJoS/1fby/8r groKaq6BoRkwaeCyjP9INszK1A9hnPN63ZO0k05QftAmVjEL+80w6H+hOMLEZ43f52br HnaK1uDL4k99dMSmHFBzIItThTQraiky0sqTp1ICfuaSGZ7Jt6ehxaKvbUmY3BfPwOns QHIrzT19CsP5EzAMTBUPipCJKdTcl/rbG6AfPgPDSxAsgwkUZC5GpnYPwy5WsA+XBcee K5mw== X-Forwarded-Encrypted: i=1; AKwUvBwuuljgMuzyqd4QSHtn2b/1C9HS7pJF00BVN6lJo0RImI86ryDAazA/BKFHDlXYgntqfDAARAwlWxFyNLk=@vger.kernel.org X-Gm-Message-State: AFuF++mFGN6Q/++5mXHBtHY4cgUJui9UhkAt3YbcI2kiY8YeCZRj0Ybt U87l4GIpAR6uw9NlE2SoCqfUEXnJVHRiNfI4RpT+HQ48LFxkhPx21eN8 X-Gm-Gg: AYBFou1o7j9awOYeRYdXGvnHnrBvxIX9M3SOT8iqhQo2YGkgc8k/2PxRENDv+N7iaAb OKyv4NH5QsWZLW07xQDoZA4nERsBH6d3BJI4L8XHjBU8R3ukdjRAlGW7Hlyfr8lVPlDkil60L1Z /7hDoLNOWFeZrJC/+0qspBb9hZ6AgNzsY+zxFnsLXVbbNzy4MSH7TVdDF+EGCfmNY4eALjtMMRN hBT2HyZKvr4HsxGjLvOSUcLm/o42ZwWOa/+4oSRDEefpCO1J7b7kn3TpZIPgo/Ct8bdzDjd6BQT ElbAo8ZlYquoU67v61i3R/YXF913S6E6yTjBY3jRqzwEiE679z8lIeBFT009ACdJqH1ZT7wrLYH S8taWpARpZZ6+UMMpQtQV4S7sax4+tMuXl2I+IoC1JsnKza2WMs74AlgKQTUlqebu03F240ad1e 4wXuNakte+9GP72VziodhHDoGstY/mTA5F+H9auokYaHswRadpGAAUYCJoZ0R+uRVsP/btlxHIC LMdN+tmhJXuoAQUdZAg9CdNvO7cMFLNW05qglFTr4iirfNpg3+kAkCwp+E4AIHIsW3ZTfHLVYKv AQAhX3NkI3llJhCrQB6xn6/s2f/dYlKesiNZF31c2ThaKsZ/+BZE7LDlOH1JfH5VA6XHPU1Rb/H EsWWYrlWj7gF3isFcdNjr1kitkwXFuepI X-Received: by 2002:a05:6830:6d4e:b0:7f4:eb76:881d with SMTP id 46e09a7af769-82049119577mr4659618a34.5.1790829565141; Wed, 30 Sep 2026 21:39:25 -0700 (PDT) Received: from [127.0.1.1] (174-29-1-49.hlrn.qwest.net. [174.29.1.49]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-8212aa1a2b8sm1792815a34.13.2026.09.30.21.39.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2026 21:39:24 -0700 (PDT) From: James Hilliard Date: Wed, 30 Sep 2026 22:39:22 -0600 Subject: [PATCH net] net: stmmac: leave the datapath running for normal-size MTU changes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260930-stmmac-mtu-fastpath-v1-1-fd73f378c071@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/y2NwQ6DIBBEf8XsuSQIFrS/0njYxaVyQC1g08T47 yVtj28mb+aAzClwhltzQOJXyGFdKrSXBtyMy4NFmCqDksrIQUuRS4zoRCy78JjLhmUWpu9bzTh pGiRUc0vsw/u7eoeFC4y/MPFzrw/l3xBmFm6NMZRbg5Y8Ena90qxda65ESsrO2Y69t04OxlhFz sJ4nh/Y9ncutgAAAA== X-Change-ID: 20260930-stmmac-mtu-fastpath-68813ead3b90 To: netdev@vger.kernel.org, Paolo Abeni , Jakub Kicinski , Maxime Chevallier , Andrew Lunn , Eric Dumazet , Maxime Coquelin , Alexandre Torgue , Christian Marangi Cc: "David S. Miller" , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Eric Dumazet , James Hilliard X-Mailer: b4 0.15.2 When both MTUs are at most ETH_DATA_LEN, the receive buffer size and MAC receive limit do not change. Update the MTU without restarting the datapath. This also avoids rebinding a live AF_XDP pool to a temporary RXQ. XDP rejects jumbo MTUs, so all supported XDP MTU changes take this path. Jumbo transitions remain on the reopen path until the rollback change. Fixes: 3470079687448 ("net: ethernet: stmicro: stmmac: permit MTU change with interface up") Signed-off-by: James Hilliard --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 3f34d491c959..03cd14d10356 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -6161,7 +6161,12 @@ static int stmmac_change_mtu(struct net_device *dev, int new_mtu) if ((txfifosz < new_mtu) || (new_mtu > BUF_SIZE_16KiB)) return -EINVAL; - if (netif_running(dev)) { + /* Normal-size frames use the same buffers and MAC receive limits. + * In particular, do not disturb a live AF_XDP pool: XDP does not + * support jumbo frames, so it never needs the ring replacement below. + */ + if (netif_running(dev) && + (dev->mtu > ETH_DATA_LEN || mtu > ETH_DATA_LEN)) { netdev_dbg(priv->dev, "restarting interface to change its MTU\n"); /* Try to allocate the new DMA conf with the new mtu */ dma_conf = stmmac_setup_dma_desc(priv, mtu); --- base-commit: a7bfaba4823e3c165bb2004c74eff7c096672bc7 change-id: 20260930-stmmac-mtu-fastpath-68813ead3b90 Best regards, -- James Hilliard