From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f38.google.com (mail-pj2-f38.google.com [74.125.227.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01F8737A48A for ; Wed, 30 Sep 2026 03:16:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.166 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790738172; cv=none; b=dha6YCQphgKhX+3DiLqCqvZoUBGKrsT53IrkkprabynSWhPpQpwKm7r4wiXwKFuE4JmkqYGkX+oBPgW//pX1hJYv5cUiLQcIOYOLxPrNNEQzR7MFuC/N9AF4GxnmEgt3LP7kcQ3hOmgNHzCRa+K2j4u6Y9h/HYbaq+strwmKMl0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790738172; c=relaxed/simple; bh=cCh5Yyrw+WTMc8LZj6fD2Tm+WKPAQKfaSqn6wwbd9no=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R7ZyDj6lr04RH4xmStlXZ6F4OH+cRDBNMCZv9iTd6lPBwxQLfeOqhwQr/rWUMQwwK+V1eaFfF1e6QO9o2wFelh+NyOpCzdcTVatqTqGd4FC3AW/Y58ZolwyseOHfSx67vvU4tTWLverRcwmycm1uKraeoWelJCOqYmwtBMSp+5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YDp0XEMy; arc=none smtp.client-ip=74.125.227.166 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YDp0XEMy" Received: by mail-pj2-f38.google.com with SMTP id 98e67ed59e1d1-3a4bd597d68so285482a91.2 for ; Tue, 29 Sep 2026 20:16:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790738170; x=1791342970; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kvCQxPtK7+AK7DvJPFUusYMdwxE4hgp8/u1LNz01hVY=; b=YDp0XEMyh/5RYiT7rZNaffXMRuK7G3FPz3AXgBriNThCzs2FOTdJcBCapZuKD/krK5 4wXkPcVkKX+ECANwQYuntiEjHaB9sorlZc9dG3GqjOUOqFTHXX4Qf6eHqWIhqexhPzH8 Gksd8G+glexXTDABU1LuDfgY04W/i02Jzwnp3VjzPJxoPjgwy3rgYQ1vJTpBz2yBU2Sm akF3B2bolNjgdNUrO6wnUOqIbbxuAJB7M1hZx7urKiV6rsFXvaMRyh6/Xx4XpikqV/4m 37wAdr1gNSCMDGSsoF31PbQFI/Omho25kgYkgVaU8/j+VLApXu4yirLbrTKsf+d3gLvz B+AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790738170; x=1791342970; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=kvCQxPtK7+AK7DvJPFUusYMdwxE4hgp8/u1LNz01hVY=; b=XSEvjn6TkWBGAVmvn0JwhG3R2gbNIlHHC0xPZgmJoJs1O28S2mcRGzvjQg1LxjiYvX O0dJdczsCej/gWh49yzmzs4w7jBQ3oVUfYmWEfy6oEey3JzrjzUg9vXJI5a9jKTLTiXf qyc+Tou6yiR4tKKvKGBCHahS6NpNpWd7PbElzMGyB4TZHpaXdbYCc87DkWORKE5zwL/d OpVbiDoO9XXXJTp6ml4Bq1lR9ZFSpzkOgF0tUzWgAp8ICOvJSAl+uPr+xZ6lrQFOefne 3If6KC7rdvRGcXNcgUqJNMmoj3h8ZGrGBPgAZgxerwMB4FXDZYdRIf5oaYT9GxNyaVkQ ku1g== X-Forwarded-Encrypted: i=1; AKwUvBxxk4Nt2VhhCIA+ro13yd+rOPLucHpZ5OG1ycGD832nGboo/CiTXM8oVgKtm9LpQ8sPL8g4Wb0hYFUrdoM=@vger.kernel.org X-Gm-Message-State: AFq9FYLiL+J3JeRwfBnKEOXE6gYin0UwcyQGTFM/6leljJoZh1Xb1MIH 85ppNMGcGAcI5++EOpVVkW3b6wlOUfxnAjg2pcv3UHV/nhWaAaae7/YF X-Gm-Gg: AYBFou2tbrJsUaKdiBkHcz9/IV27LsH1txDQxsR/XAqmxCmZKrWAoi1zmY2K+YMsMVu slqQz7B9VYp0+3Zi1m+nTWoNbBicGGx8ekGwy6NubzVuhzl1wOEAZE+7xwsrPLNswz0y0qBSciH qrwFhzwqCZlcWRvyD5Xq+sUksxnVO+7CYn2PmbhMDhmKkYToe93ytaIUI5FaWxRU01o0bOmSFfJ HyZEkkMQFCY3ViCgL+Nf32l0M57+sasIjQTwasHH/P8Lu3BeduzrwePxHKIt9vYHDDM+RQx97nd ClXFxnuatv8fXGbP5OeYuj9QUX8H59XVanDTTxgSQkjKDRV1/pOM8RjsftK+dqXvfcnKnSn0VDX cLNurSyCpel78hojHV2YFqMWjPdVTwP5cWmmFLN4jj9QWfEV1WEdS5FgV49DgSSUOWvyKhwB5hT hCipS9lf36ZK2C/PalzX8utNVURlAMSJWBjJj99tnRmzOH3b2pERz26kY38mL9Kak+WInk9gOLp vzYb9wTmZg5d3DHrARFxCzLDiqVc9hQ/eSGHshfDIfGNazrEzt7Y8VM2XjfjhNfzNbhXmIthYIw SrS2BpojOg== X-Received: by 2002:a17:90b:2888:b0:3a0:9c9d:eb0b with SMTP id 98e67ed59e1d1-3a4d19262ddmr104610a91.58.1790738170170; Tue, 29 Sep 2026 20:16:10 -0700 (PDT) Received: from phui-2.c.googlers.com.com (25.187.82.34.bc.googleusercontent.com. [34.82.187.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a4ce1c9045sm588743a91.12.2026.09.29.20.16.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2026 20:16:09 -0700 (PDT) From: Hui Peng To: Anders Larsen Cc: Matthias Goergens , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Hui Peng Subject: [PATCH v4 6/6] qnx6: validate sb_blocksize before dividing in qnx6_mmi_fill_super() Date: Wed, 30 Sep 2026 03:16:04 +0000 Message-ID: <20260930031604.70544-7-benquike@gmail.com> X-Mailer: git-send-email 2.56.0.rc1.315.gc6ed9934b7-goog In-Reply-To: <20260924073920.2782917-1-benquike@gmail.com> References: <20260924073920.2782917-1-benquike@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In qnx6_mmi_fill_super(), sb1->sb_blocksize is read from disk and used as a divisor in QNX6_SUPERBLOCK_AREA / fs32_to_cpu(sbi, sb1->sb_blocksize). If sb1->sb_blocksize is 0, it causes a division by zero in kernel space. Validate sb1->sb_blocksize is non-zero before performing the division and abort mount if it is zero. Tested in QEMU against tip of mainline commit 62f4c998b297 ("Merge tag 'parisc-for-7.3-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux") using a loop-device reproducer mounting an image with sb_blocksize = 0: verified that mount is rejected cleanly with -EINVAL (rc=-1 errno=22) before division occurs. Fixes: 5d026c724220 ("fs: initial qnx6fs addition") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Hui Peng --- Changes in v4: - Rebased cleanly onto upstream mainline commit 62f4c998b297. - Added QEMU test procedure and verification details in commit message body. fs/qnx6/super_mmi.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fs/qnx6/super_mmi.c b/fs/qnx6/super_mmi.c index 5f62df30467b..5d41f028bf80 100644 --- a/fs/qnx6/super_mmi.c +++ b/fs/qnx6/super_mmi.c @@ -63,6 +63,11 @@ struct qnx6_super_block *qnx6_mmi_fill_super(struct super_block *s, int silent) goto out; } + if (!fs32_to_cpu(sbi, sb1->sb_blocksize)) { + pr_err("invalid blocksize 0 in superblock #1\n"); + goto out; + } + /* calculate second superblock blocknumber */ offset = fs32_to_cpu(sbi, sb1->sb_num_blocks) + QNX6_SUPERBLOCK_AREA / fs32_to_cpu(sbi, sb1->sb_blocksize); -- 2.55.0.1082.g2b9226bbc0-goog