From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Quchaosheng <quchaosheng000406@163.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Clark Williams <clrkwllms@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
John Stultz <jstultz@google.com>,
Valentin Schneider <vschneid@redhat.com>,
linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev
Subject: Re: [PATCH] sched/proxy: Correct the SCHED_PROXY_EXEC dependency comment
Date: Wed, 30 Sep 2026 08:25:54 +0200 [thread overview]
Message-ID: <20260930062554.2AwbY2nX@linutronix.de> (raw)
In-Reply-To: <20260930025824.79296-1-quchaosheng000406@163.com>
On 2026-09-30 10:58:24 [+0800], Quchaosheng wrote:
> The comment on the !PREEMPT_RT dependency reads
>
> # Avoid some build failures w/ PREEMPT_RT until it can be fixed
>
> That describes what happens once the dependency is removed, not the
> reason it is there, and "fixed" is never defined, so nothing says when
> the dependency can be dropped.
No, please leave it as-it. This information is the for the end-user not
necessarily a developer. What you add is an information for someone who
can read code. This information adds no value IMHO.
This is enough as it is. Someone familiar with the scheduler can
certainly remove the dependency while adding the needed code and
replacing the current PI bits.
Sebastian
next prev parent reply other threads:[~2026-09-30 6:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 2:58 Quchaosheng
2026-09-30 6:25 ` Sebastian Andrzej Siewior [this message]
2026-09-30 6:32 ` Chaosheng Qu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930062554.2AwbY2nX@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=clrkwllms@kernel.org \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=quchaosheng000406@163.com \
--cc=rostedt@goodmis.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®